SQLite cannot update a column to NULL [#1139638]

... because of a stupid error in the condition inversion code.

Comment	File	Size	Author
#2	1139638-sqlite-update-to-null-8.patch	1.71 KB	Damien Tournoud
#2
#2	1139638-sqlite-update-to-null-7.patch	1.71 KB	Damien Tournoud
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Damien Tournoud CreditAttribution: Damien Tournoud commented 27 April 2011 at 07:30

Status:	Active	» Needs work
Issue tags:		+Needs tests, +Needs backport to D7

Gist of the fix:


diff --git a/includes/database/sqlite/query.inc b/includes/database/sqlite/query.inc
index d456afa..a176ed6 100644
--- a/includes/database/sqlite/query.inc
+++ b/includes/database/sqlite/query.inc
@@ -101,7 +101,7 @@ class UpdateQuery_sqlite extends UpdateQuery {
       }
       elseif (!isset($data)) {
         // The field will be set to NULL.
-        $condition->isNull($field);
+        $condition->isNotNull($field);
       }
       else {
         $condition->condition($field, $data, '<>');

We need to increase the test coverage of UpdateQuery.