There's code in here that should be displaying a message on ?q=contact when there are no categories defined, but it's not firing.

The attempt to get this message to print is coming from an '#error' FAPI property which appears to be completely useless, since it's only referenced here and in form.inc and nowhere else (grepped contrib as well).

So, this patch removes #error, changes the error message to a drupal_set_message, and adds a sentence (with link) to describe how to actually configure the form.

CommentFileSizeAuthor
contact-error.patch1.25 KBwebchick
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dmitrig01’s picture

dmitrig01 CreditAttribution: dmitrig01 commented

form_error and form_set_error are used in validate functions. try grepping for that...

dmitrig01’s picture

dmitrig01 CreditAttribution: dmitrig01 commented
Status: Needs review » Closed (works as designed)
bdragon’s picture

bdragon CreditAttribution: bdragon commented
Status: Closed (works as designed) » Reviewed & tested by the community

I disagree.

This does look like an oversight.

Patch applies still (fuzzy as hell), I say RTBC.

Dries’s picture

Dries CreditAttribution: Dries commented

Committed to CVS HEAD. Thanks.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed
Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)