String freeze: fix misleading message when users register [#110474]

drat, i wish i noticed this before the 5.0 release and resulting string freeze. :(

when users register on a site that requires admin approval, core always prints out the following message to the screen:

Thank you for applying for an account. Your account is currently pending approval by the site administrator.
In the meantime, your password and further instructions have been sent to your e-mail address.

however, that's not always true. sites can configure the welcome message to include as little or as much info as they want in the admin settings pages. in particular, the password is not always included, and in fact, if you use the http://drupal.org/project/user_status module, the password should *not* be included in the initial welcome email, only once the account has been approved.

so, i'm proposing the following text, which is always true:

Thank you for applying for an account. Your account is currently pending approval by the site administrator.
In the meantime, a welcome message has been sent to your e-mail address.

i know this will (again) break translations, but any chance of fixing this in 5.x?

cheers,
-derek

Comment	File	Size	Author
#5	110474-3.patch	1.05 KB	dww
#5
#4	110474-2.patch	1.12 KB	keith.smith
#4
	user_register_admin_approval_welcome_text.patch.txt	1.07 KB	dww

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

drumm

he/him

NY, US

CreditAttribution: drumm commented 29 January 2007 at 20:33

Version:

5.x-dev

» 6.x-dev

Comment #2

Dries CreditAttribution: Dries commented 30 January 2007 at 21:51

Status:

Needs review

» Needs work

Mmm, I don't think the proposed replacement is an improvement. In 95% of the cases, it will become less clear. A "welcome message" is something I don't care about. However, a "password mail" is. I think we need very clear instruction rather than generic yadda-yadda. :-)

Comment #3

dww

we/he/they

CreditAttribution: dww commented 30 January 2007 at 22:19

then perhaps we should make this drupal_set_message() text a setting, too. because it's going to be incorrect in general depending on how people customize their welcome email text. also, drumm pointed out in IRC that it's actually broken in 5.x, since there's no password at all in the initial email, only a 1-time login.

i guess, even with a setting, we need a default. so, how about:

Thank you for applying for an account. Your account is currently pending approval by the site administrator.
In the meantime, a welcome message with further instructions has been sent to your e-mail address.

Comment #4

keith.smith CreditAttribution: keith.smith commented 11 December 2007 at 21:55

Title:	fix misleading message when users register	» String freeze: fix misleading message when users register
Component:	user system	» documentation
Status:	Needs work	» Needs review