Hi. I'm finding the Views, Panels and Panels Everywhere combo ridiculously powerful and am extremely grateful for them, so thank you so much for making these invaluable toolsets!
I've noticed a little bug (I think) today, though. I'm running Panels 6.x-3.9, Panels Everywhere 6.x-1.x-dev and Views 6.x-3.x-dev. For the taxonomy term page, I wanted to list all direct children terms (along with their associated node counts) in 3 columns.
I began to add in 3 panes, each one based on exactly the same view, but showing different offsets (i.e. results 1-7, 8-14 and 15-21 respectively). I'd set the view up and just left it with its default display, which I sent the panel arguments to in each pane. When I selected the 'Use different pager settings from view settings' the other settings appeared. To cut a long story short, if the 'Use pager' setting isn't checked, then the 'Num posts' number isn't respected at all: the offset works fine, but the view displays all remaining items. With the pager switched on, it works correctly (but ruins the point of listing the remaining items!).
I don't know if this is an issue with using the same view display three times - actually, it's not: I just tried it with a single panel on a new page and the same issue arose. Without the pager option checked, the num posts value is being ignored.
(I've managed to use a workaround of creating 3 different content pane displays in views and setting their offsets and number to display within views itself.)
I'm not sure if this is a panels or views issue, so I hope it's in the right place.
Thanks.
Comment | File | Size | Author |
---|---|---|---|
#9 | 1091554-fix-pager-api.patch | 5.87 KB | dawehner |
#7 | 1099502-pager-api-test.patch | 1.65 KB | dawehner |
#7 | 1091554-fix-pager-api.patch | 4.47 KB | dawehner |
#6 | views-1091554-6.patch | 554 bytes | tim.plunkett |
#4 | ctools-num_posts_not_respected-1091554-4.patch | 665 bytes | acrollet |
Comments
Comment #1
mtrolle CreditAttribution: mtrolle commentedI'm seeing the same issue in 7.x-3.?
Comment #2
Letharion CreditAttribution: Letharion commented@merlinofchaos I don't know which module takes responsibility for what in this particular case, so I'm assigning it to you.
Comment #3
spencer95@gmail.com CreditAttribution: spencer95@gmail.com commentedI'm also seeing this in Views 7.x-3.1. Intermittently, admittedly and sometimes varying between browsers.
Comment #4
acrollet CreditAttribution: acrollet commentedI've run into this issue as well. The views content type plugin was using the get_items_per_page() method to determine how to set the pager type. However, this method was not returning anything, and so the pager type was always being set to 'none'. Patch attached which simply uses $conf['nodes_per_page']. I've tested this with all permutations of the pager over-ride settings, with complete success.
Comment #5
jordi_bcktt CreditAttribution: jordi_bcktt commentedWorking for me. Thank you.
Comment #6
tim.plunkettI don't think this isn't really the right fix.
Only a couple lines above is http://drupalcode.org/project/ctools.git/blob/06e628c:/views_content/plu...
$view->set_items_per_page($conf['nodes_per_page']);
I'm tentatively moving this to Views to see if it should be fixed in
get_items_per_page()
itself.Comment #7
dawehnerI fear there is basically every pager api function "broken".
Comment #9
dawehnerAt least it's good to see that tests all kind of different bugs.
Comment #10
tim.plunkettComment #11
dawehnerThere are quite some tests, the fix itself is in as well, so let's commit it. Committed to 7.x-3.x