If there is at least a disabled language the language neutral option is not available when creating new nodes.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plach’s picture

Status: Active » Needs review
Issue tags: +Quick fix
FileSize
1.86 KB
1.17 KB

easy fix

ogi’s picture

subscribe

klonos’s picture

...confirming issue + patch fixes it.

plach’s picture

Status: Needs review » Reviewed & tested by the community

Results are not coming back but patches pass/fail tests as they are supposed to. Setting to RTBC per #3.

plach’s picture

Version: 7.x-dev » 8.x-dev
Issue tags: +Needs backport to D7

Bugs are fixed in the development version first, backported then.

The patch still applies and tests pass, so confirming RTBC status.

plach’s picture

#1: translation-1078980-1.patch queued for re-testing.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 7.x and 8.x. Thanks!

Dries’s picture

When I committed this, something odd happened.

See http://drupalcode.org/project/drupal.git/commit/5dbe8aa92b9e746962b43f9a....

dries@git.drupal.org's password: 
Counting objects: 32, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (18/18), done.
Writing objects: 100% (18/18), 2.03 KiB, done.
Total 18 (delta 14), reused 0 (delta 0)
To dries@git.drupal.org:project/drupal.git
   6cb0a70..faf9841  8.x -> 8.x
 ! [rejected]        7.x -> 7.x (non-fast-forward)
error: failed to push some refs to 'dries@git.drupal.org:project/drupal.git'
To prevent you from losing history, non-fast-forward updates were rejected
Merge the remote changes (e.g. 'git pull') before pushing again.  See the
'Note about fast-forwards' section of 'git push --help' for details.
deimos:drupal-head dries$ git pull
dries@git.drupal.org's password: 
Merge made by recursive.
 includes/common.inc                         |   13 ++-
 includes/database/database.inc              |   57 +++++++++++++
 includes/database/mysql/query.inc           |    8 +-
 includes/database/pgsql/query.inc           |    4 +-
 includes/database/query.inc                 |   22 +++---
 includes/database/select.inc                |    5 +-
 includes/database/sqlite/query.inc          |    8 +-
 includes/menu.inc                           |    2 +-
 modules/comment/comment.module              |    8 +-
 modules/field/field.attach.inc              |   25 ++++--
 modules/node/node.install                   |   34 +++++---
 modules/node/node.module                    |   10 +-
 modules/openid/openid.module                |   10 +--
 modules/openid/openid.test                  |   12 ++--
 modules/simpletest/tests/database_test.test |   21 +++++
 modules/simpletest/tests/menu.test          |   58 +++++++++++++
 modules/system/system.api.php               |   24 +++---
 modules/taxonomy/taxonomy.module            |    4 +-
 modules/user/user.module                    |  119 ++++++++++++---------------
 19 files changed, 295 insertions(+), 149 deletions(-)
deimos:drupal-head dries$ git push
dries@git.drupal.org's password: 
Counting objects: 31, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (19/19), done.
Writing objects: 100% (19/19), 2.19 KiB, done.
Total 19 (delta 15), reused 0 (delta 0)
To dries@git.drupal.org:project/drupal.git
   267b9c4..5dbe8aa  7.x -> 7.x

I wonder if that was because of webchick's commits.

webchick’s picture

Yep, I think so. Before going on a commit spree, it's a good idea to do:

git pull --rebase

This will ensure that all of my stuff gets pulled in and your stuff layered on top of that. (Or something like that. :P Silly Git.)

plach’s picture

Anyway, the code belonging to the patch seems to have landed correctly on both branches, thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix, -Needs backport to D7

Automatically closed -- issue fixed for 2 weeks with no activity.