Updated: Comment #3

Problem/Motivation

There is the string 'Scale' used in two different context in core;

  • Used as title of the number of digits in number.module.
  • Used as label of an image effect in image.module.

In Japanese, and other languages, different translations are required for each.

Proposed resolution

Add a context to the string.

Remaining tasks

none

User interface changes

Interface translation will change.

API changes

none

CommentFileSizeAuthor
#9 1078618-9.patch1.67 KBswentel
#3 drupal-number-add-scale-context-1078618-3.patch1.64 KBSutharsan
number.module.1.patch664 bytesTakafumi
used_in.png33.85 KBTakafumi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yoroy’s picture

yoroy CreditAttribution: yoroy commented
Status: Needs review » Needs work

Spreadsheet apps call these "decimal places" or "number of decimals". The current patch has too much overlap with the description.

droplet’s picture

droplet CreditAttribution: droplet commented
Version: 7.x-dev » 8.x-dev
Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
drupal-number-add-scale-context-1078618-3.patch1.64 KB

This patch uses 'decimal places' as context. Number module has now two occurrences of "Scale", both receive this context.

Status: Needs review » Needs work

The last submitted patch, 3: drupal-number-add-scale-context-1078618-3.patch, failed testing.

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan commented
Status: Needs work » Needs review

3: drupal-number-add-scale-context-1078618-3.patch queued for re-testing.

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs review » Reviewed & tested by the community

grepped the sources, only 2 occurrences. Patch still apply.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Closed (fixed) » Needs review
FileSize
1078618-9.patch1.67 KB

@Sutharsan isn't argument missing the 'context' key ? See attached patch.

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan commented
Status: Needs review » Reviewed & tested by the community

@swentel You couldn't be more right.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: 1078618-9.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Reviewed & tested by the community

Bot hickup

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

I think this deserves a new issue to keep issue credit etc sane - also this was closed 2 years ago.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

@swentel made you a follow-up, can you re-upload to this follow-up issue for credit? #2656442: Argument missing the 'context' key for 'decimal places' context

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.