In modules/simpletest/test/error.test, it actually has wired into the code the exact line number it expects to see in the error. Well, in the Great Git Migration, one line ($Id$) is removed from the file. #fail.

This patch will make it a little less fragile by omitting the line number.

CommentFileSizeAuthor
#3 my_one_commit.png20.48 KBrfay
#1 drupal.fragile_test_1064264_01.patch2.71 KBrfay
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented
Status: Active » Needs review
FileSize
drupal.fragile_test_1064264_01.patch2.71 KB

Here is the simple patch.

Why is this such a problem? Because the testbots can't complete a test successfully because of this.

Note: This patch works fine in both the current test environment *and* in the git testing environment.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented
FileSize
my_one_commit.png20.48 KB

Update: As a quick hack for the next day or two of testing, I committed this on git-testing:

I got my 1 minute (1 commit) of fame:

my_one_commit.png

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks. :)

Status: Fixed » Closed (fixed)
Issue tags: -git deployment blocker

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +git deployment blocker

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.