Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
We hard code the path themes/engines and thus don't allow engines to reside in the sites directory .. Discovered while porting the fine PHPTAL engine to 5.0 - http://drupal.org/node/105702
Comment | File | Size | Author |
---|---|---|---|
#4 | patch_181 | 1.47 KB | moshe weitzman |
patch_178 | 1.51 KB | moshe weitzman |
Comments
Comment #1
drumm- Remove commented debug code
- While we are here, those changed lines need to punctuate '. $variables .' according to code style.
What is a good way to test this? Does PHPTAL in contrib HEAD work well enough?
Comment #2
ChrisKennedy CreditAttribution: ChrisKennedy commentedI don't know much about theme engines so I can't really comment on the merits of the patch (it looks good to me), but just to nitpick the debugging line needs to be removed and the string concatenation spacing needs to be fixed.
Comment #3
Dries CreditAttribution: Dries commentedWhy is this critical? It's not a regression compared to Drupal 4.7, is it?
Comment #4
moshe weitzman CreditAttribution: moshe weitzman commentedi made the requested changes, and downgraded priority.
Comment #5
eaton CreditAttribution: eaton commentedThis isn't a regression; rather, it's a feature that is intended to work in a particular way (allowing themes, modules, engines, etc to be stored in sites/all rather than the root drupal directory). It's not working in that intended fashion, mostly because we never tested it with additional non-core theme engines.
It changes no APIs, as none of the code involved is used externally; it just makes things work the way we say they do in the documentation, etc. :-)
Comment #6
Dries CreditAttribution: Dries commentedEaton: I know and we should fix this. It's just that it doesn't have to hold up a release, IMO. Critical bugs are meant to be showstopping bugs.
Comment #7
eaton CreditAttribution: eaton commentedFair enough -- normal is probably the best priority level for it. :)
Comment #8
drummCommitted to HEAD.
Comment #9
(not verified) CreditAttribution: commented