Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The upgrade path is currently broken:
http://pastie.org/private/5riqtsjbsbv33vn9jqtasa
What seems to happen is after provision-save of the site, the drush alias for @hostmaster becomes a *server* context alias and not a *site* alias. We seem to see this happen occasionally elsewhere.
It might be related to http://git.aegirproject.org/?p=provision.git;a=commitdiff;h=0ae46243707c...
Comments
Comment #1
anarcat CreditAttribution: anarcat commentedSee also #1001620: verifying an existing platform (and site) doesn't work the first time for that weird bug.
Comment #2
omega8cc CreditAttribution: omega8cc commentedThen also this commit looks connected to the broken upgrade issue: http://git.aegirproject.org/?p=provision.git;a=commitdiff;h=b50120f0aab1...
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedI don't see how that's related, all that commit can do is introduce Drush 4 compatability. I am only testing on 3.3.
Comment #4
omega8cc CreditAttribution: omega8cc commentedAh, I was already confused by broken upgrade with Drush 3.3 on Nginx and moving those (both) commits out and back in etc. Maybe it is not related, in fact.
Comment #5
Anonymous (not verified) CreditAttribution: Anonymous commentedReverting this commit does indeed fix it as I thought it might
http://git.aegirproject.org/?p=provision.git;a=commit;h=0ae46243707c628a...
Now I need to understand why. I think it is something to do with us now only merging in options provided from cli, stdin etc if the alias name is @self. I tried to make it also do it if $name == '@hostmaster' but that didn't work either :s
Comment #6
Anonymous (not verified) CreditAttribution: Anonymous commentedCrap, this may not even be limited to the upgrade path for hostmaster, but for Migrate itself!
Tested on HEAD, a simple migrate of a site:
http://pastie.org/private/mde664nlw6cftmlliv2lpq
Comment #7
omega8cc CreditAttribution: omega8cc commentedThis commit breaks the context stuff completely, for example it creates
hostmaster.alias.drushrc.php
with contents looking like it wasserver_master.alias.drushrc.php
just ending with admin_email record, like below:It looks like the logic for
if ($this->name == '@self') {
is wrong.I don't understand that patch enough but I believe you can't restrict the array using that
if
and still expect the rest will work.Comment #8
omega8cc CreditAttribution: omega8cc commentedJust tested it both with Drush 3.3 and Drush 5/HEAD - same result, the context is broken and the drush aliases are rewritten with server instead of site context. It still allows to install the hostmaster, but upgrade fails.
Comment #9
Anonymous (not verified) CreditAttribution: Anonymous commentedI reverted this: at the end of the day, this patch by unconed simply needs work as it breaks other stuff that is critical to function properly (Migrate).
I am marking this a duplicate and re-opening with #needswork the Cluster ticket #1016890: Create Server as cluster is broken after save, as that's what this patch tried to fix.