Admin setting for font subsetting for TCPDF [#1049892]

TCPDF generates a single PDF for minutes. This is all because font subsetting (embedded font contains only these characters that are actually used) is enabled by default. When the following line is added to _print_pdf_tcpdf(), PDF is generated "instantly":

$pdf->setFontSubsetting(FALSE);

Please include checkbox in admin/config/print/pdf for disabling font subsetting. Generated PDFs will be larger but it's an enormous difference between 1s and 1min!

Comment	File	Size	Author
#1	modules_print_print_pdf.patch	2.01 KB	pillarsdotnet
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

pillarsdotnet CreditAttribution: pillarsdotnet commented 26 February 2011 at 03:25

Status:

Active

» Needs review

File	Size
modules_print_print_pdf.patch	2.01 KB

Patch needs testing.

Comment #2

jcnventura CreditAttribution: jcnventura commented 4 March 2011 at 15:13

Status:

Needs review

» Fixed

Thanks for the patch! I've committed it to git.

Comment #3

ogi CreditAttribution: ogi commented 4 March 2011 at 15:48

Status:

Fixed

» Needs work

A syntax error slipped in. > is missing.

+  $pdf-setFontSubsetting(variable_get('print_pdf_tcpdf_subsetting',FALSE));

Comment #4

jcnventura CreditAttribution: jcnventura commented 4 March 2011 at 15:56

Status:

Needs work

» Fixed

Thanks for the warning.. I have been trying to clear the queue, and I haven't really started re-testing the whole module.

Comment #5

ogi CreditAttribution: ogi commented 4 March 2011 at 22:57

Status:

Fixed

» Needs work

An error is introduced again

-  $pdf->setFontSubsetting(variable_get('print_pdf_tcpdf_subsetting',FALSE));
+  $pdf->setFontSubsetting(variable_get('print_pdf_font_subsetting',FALSE));