i just updated s.d.o to 5.x-dev (HEAD) to make it easier for folks to test the project* port. ignoring the fact that bluebeach isn't quite ported (or, if it is, it's not checked into the private repo), things went fairly smoothly.

*however*, there's a nearly-critical bug in forum.module now visible on the front page of s.d.o: the forum navigation links are showing up in the forum teasers. :(

IMHO, the existance of these links at all is a bug, not a feature. ;) however, it's INSANE that they're showing up in the teaser (and therefore, the front page). :( who wants a bunch of random links to random forum posts when you promote a given forum topic to the front page? it makes the site look busy, confusing, and vastly lowers the signal to noise (aka content to junk) ratio of the main view of a drupal site.

futhermore, it looks like these navigation links are generated via a fairly expensive query in the theme layer (3 INNER JOINS). i'd love a feature to turn off these links, even when viewing the full page view of a forum...

however, in the interest of getting this bug fixed, i'm keeping my patch small, only generating these links in forum_view() if we're in $teaser==FALSE mode. i'll consider waging war against these links via another issue, if i have the energy/time. ;)

CommentFileSizeAuthor
forum_navigation_not_in_teaser.patch.txt771 bytesdww
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hunmonk’s picture

+1 on the concept -- those links in teasers are kind of confusing. code looks pretty straightforward and sane.

chx’s picture

Status: Needs review » Reviewed & tested by the community

Indeed prev/next has nothing to do in lists.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

dww’s picture

excellent. ;) s.d.o is updated and *much* better now. thanks!

Anonymous’s picture

Status: Fixed » Closed (fixed)