Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When I enable "Aggregate and compress CSS files" with Garland as the default theme, the background images disappear in IE7 and IE6 (tested by Chriskennedy). The layout is still fine on Opera 9.02.
Without the preprocessor enabled, Garland displays as it should.
(Apache/2.2.2 (Win32), PHP/5.1.4)
Comment | File | Size | Author |
---|---|---|---|
#10 | css_parentheses_whitespace.patch | 968 bytes | Steven |
#6 | css_whitespace_0.patch | 734 bytes | ChrisKennedy |
#4 | css_whitespace.patch | 686 bytes | ChrisKennedy |
#1 | css_keepwhitespace.patch | 892 bytes | ChrisKennedy |
CropperCapture[8].Png | 49.02 KB | Heine |
Comments
Comment #1
ChrisKennedy CreditAttribution: ChrisKennedy commentedTaking out the whitespace optimizations appears to fix this bug and http://drupal.org/node/102487
Patch attached, tested in IE6.
Comment #2
chx CreditAttribution: chx commentedI believe this is good to go. While it is a regression, no user interface or API is affected so we can fix this post RC without affecting anything/anyone. (Once again, IE rains the parade :( how sad.)
Comment #3
chx CreditAttribution: chx commentedAnd, even if we can/do not fix this past RC, we can ship D5 without the whitespace removal in core. It would be not as perfect but nothing is :(
Comment #4
ChrisKennedy CreditAttribution: ChrisKennedy commentedAttached patch fixes both issues by removing the first regex substitution but keeps the second two.
Comment #5
m3avrck CreditAttribution: m3avrck commentedI bet this is a problem with @import -- unfort I don't have anytime to verify, but with a quick glance that is my best guess. Steven could probably comment more, that was his regex :-p
Comment #6
ChrisKennedy CreditAttribution: ChrisKennedy commentedIt turned out that the \) was causing the error. This patch uses chx's suggestion to just str_replace an extra space after parentheses.
Comment #7
Heine CreditAttribution: Heine commentedSolves the issue on IE7
Comment #8
Heine CreditAttribution: Heine commented#6 solves the issue on IE7 and has no negative consequences for Opera.
Comment #9
jacauc CreditAttribution: jacauc commentedworked for me. see http://drupal.org/node/102487
Comment #10
Steven CreditAttribution: Steven commentedPatch attached which leaves a single space around parentheses, but still strips on the inside. I also added the comma as a separator.
Comment #11
Steven CreditAttribution: Steven commentedCommitted to HEAD after IRC approval.
Comment #12
(not verified) CreditAttribution: commented