Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The form_set_error uses the wrong form api element to set the error.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | D7-favicon-error-1025286-8.patch | 492 bytes | Tor Arne Thune |
| #5 | favicon-error-1025286-5.patch | 512 bytes | Devin Carlson |
| #4 | 1025286_without_patch.jpg | 33 KB | opi |
| #4 | 1025286_with_patch.jpg | 34.13 KB | opi |
| #2 | favicon-error-1025286-2.patch | 492 bytes | Tor Arne Thune |
Comments
Comment #1
chx CreditAttribution: chx commentedComment #2
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedStill a valid issue in Drupal 7.2. Re-rolled the patch against branch 8.x.
Comment #3
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedComment #4
opiThe patch in #2 works fine for me, see attached screenshots
Comment #5
Devin Carlson CreditAttribution: Devin Carlson commentedAnother +1 to the patch in #2. It works (see the screenshots in #4), but it requires a re-roll as it was created before D8 moved everything to /core.
The attached patch is a simple re-roll.
I'll mark this issue as RTBC assuming the patch passes tests.
Comment #6
Devin Carlson CreditAttribution: Devin Carlson commentedComment #7
catchThis makes sense. It's a sufficiently minor bug (and on only visual) that I don't think we need an automated test for it. So I've gone ahead and committed/pushed to 8.x.
Marking for backport.
Comment #8
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedD7 re-roll.
Comment #10
Tor Arne Thune CreditAttribution: Tor Arne Thune commented#8: D7-favicon-error-1025286-8.patch queued for re-testing.
Comment #11
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedSince it's just a D7 re-roll...
Comment #12
webchickCommitted and pushed to 7.x. Thanks!