While building a fieldset with description, I saw that it has no any css style applied. Looing the style.css file I noticed that "fieldset .definition" should be renamed to "fieldset .fieldset-definition". I've also moved the definition just below the rest of fieldset stylings in the patch.

Finally, even when applied, I found that the bottom margin sould be increased a little bit, because the description finishes just where the first form element starts, very difficult to see from usability point of view (see the screenshot included), however I'm not sure about how much margin to put between description and the field, so I've included 20px as starting point.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ilo’s picture

Status: Active » Needs review

I changed my mind, I'd have waited for more opinions, but lets put this to NR.

Status: Needs review » Needs work

The last submitted patch, fieldset_description.patch, failed testing.

ilo’s picture

Status: Needs work » Needs review
FileSize
836 bytes

oh, I forgot the paths...

amateescu’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
732 bytes

The patch is correct about changing the class to .fieldset-description, and also about moving this rule below fieldset .fieldset-wrapper.

I changed the bottom margin to 1em, which is consistent with bottom spacing throughout bartik's style.

tim.plunkett’s picture

Also tested and confirmed.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.