While building a fieldset with description, I saw that it has no any css style applied. Looing the style.css file I noticed that "fieldset .definition" should be renamed to "fieldset .fieldset-definition". I've also moved the definition just below the rest of fieldset stylings in the patch.
Finally, even when applied, I found that the bottom margin sould be increased a little bit, because the description finishes just where the first form element starts, very difficult to see from usability point of view (see the screenshot included), however I'm not sure about how much margin to put between description and the field, so I've included 20px as starting point.
Comment | File | Size | Author |
---|---|---|---|
#4 | 1024898-bartik_fieldset_description.patch | 732 bytes | amateescu |
#3 | fieldset_description.patch | 836 bytes | ilo |
fieldset_description.patch | 800 bytes | ilo | |
patched.png | 8.02 KB | ilo | |
before.png | 15.17 KB | ilo |
Comments
Comment #1
ilo CreditAttribution: ilo commentedI changed my mind, I'd have waited for more opinions, but lets put this to NR.
Comment #3
ilo CreditAttribution: ilo commentedoh, I forgot the paths...
Comment #4
amateescu CreditAttribution: amateescu commentedThe patch is correct about changing the class to .fieldset-description, and also about moving this rule below fieldset .fieldset-wrapper.
I changed the bottom margin to 1em, which is consistent with bottom spacing throughout bartik's style.
Comment #5
tim.plunkettAlso tested and confirmed.
Comment #6
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.