Hi,

I've just been playing around with the buddy module with acknowledgement required, and think presentation of the different states the requests can be in needs a fix/could be improved. The main problem:

If user A invites user B, user B can both accept the invite or invite user A (natural thing to do; you look at the invite profile, then click invite on their page). This leads you to having two outstanding invites for the same pair, one in each direction. It can then get a bit messy too, as one can accept and the other decline, leading to a miss-formed confirmation message ;o)

In a similar area, once you've invited someone, the link is still available to invite them; clicking gives you the appropriate message telling you it is pending, but the experience is less positive for it.

The solution (and bug fix) is probably simply around providing better links/messages based on the state:

  • The invite link should be an accept link if the target has an outstanding invite to you
  • The invite link should be a pending message if you have an outstanding invite with the target
  • The above bug therefore can't occur (i.e. there is no oportunity to cross-invite)

Hope this makes sense; it's my first post on drupal.org having started looking at it all a few days ago, so hope this is the right place/parameters!

Cheers,
Simon

Comments

dldege’s picture

I also noted this and here is a simple outline of the problem

A invites B
B invites A despite the pending invite from A (because there is still a link to request this action when viewing A's profile)

then...

both accept
both decline
one accepts/one declines

in all cases there are problems and database errors.

Thanks for the great module

fago’s picture

Status: Active » Fixed

I've just fixed that for both 4.7 and 5.0 branches. Now one can directly approve/deny requests on the user page.

Anonymous’s picture

Status: Fixed » Closed (fixed)