I have a fair bit of custom theming on my node forms which I think is why this hasn't been noticed yet. Basically, when I upload a file of a type that's not allowed I get the error message:

The selected file xyz.zip cannot be uploaded. Only files with the following extensions are allowed: png, gif, jpg, jpeg.

This is to be expected. This is contained within a div adding by filefield.js with the classes "messages error file-upload-js-error". But this div is placed /within/ the "file-button" div, which I don't think makes a lot of sense. I think instead the error message div should be placed at the same level as the file-button since it applies to the entire field, not just the button. This patch raises the level of the error message div so that it's placed at the same level.

Of course, it's possible that I need to change my custom theming if this patch doesn't actually make sense :).

CommentFileSizeAuthor
#1 filefield_1016746.patch680 byteshadsie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hadsie’s picture

FileSize
680 bytes
quicksketch’s picture

Category: bug » task
Status: Needs review » Fixed

This all seems reasonable to me. Committed. It'll be in the 3.10 version.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.