drupal_lookup_path() returns NULL instead of FALSE [#100957]

this is a regression of Path alias memory cache is broken

per docs drupal_lookup_path() should return FALSE if we did not find an alias or source-path.
Since this commit we return NULL...

because of this I can't redo the patch url() does not recognize if $path == frontpage.

Comment	File	Size	Author
#7	drupal_lookup_path_simplify.patch	1.02 KB	chx
#7
#2	path.patch_1.txt	692 bytes	chx
	drupal_lookup_path_regression.patch.txt	1.32 KB	Tobias Maier

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Tobias Maier CreditAttribution: Tobias Maier commented 2 December 2006 at 13:19

Title:

drupal_lookup_path returns NULL instead of FALSE

» drupal_lookup_path() returns NULL instead of FALSE

Comment #2

chx CreditAttribution: chx commented 2 December 2006 at 16:39

File	Size
path.patch_1.txt	692 bytes

I can't say I like the patch -- the idea is sound, but the implementation is a bit chatty. How about this one?

Comment #3

Tobias Maier CreditAttribution: Tobias Maier commented 2 December 2006 at 16:57

great!
I like it

Comment #4

robertDouglass CreditAttribution: robertDouglass commented 2 December 2006 at 20:35

Whee! More drupal_lookup_path excitement, how nice. Haven't tested yet, just subscribing.

Comment #5

chx CreditAttribution: chx commented 3 December 2006 at 00:16

Status:

Needs review

» Reviewed & tested by the community

Actually... I implemented this for http://drupal.org/node/100301 and that patch has been applied to drupal.org where it runs for days now so this has been tested to death already :)

Comment #6

Dries CreditAttribution: Dries commented 4 December 2006 at 10:49

Status:

Reviewed & tested by the community

» Fixed

Committed to CVS HEAD. Thanks.

Comment #7

chx CreditAttribution: chx commented 4 December 2006 at 13:21

Status:

Fixed

» Needs review

File	Size
drupal_lookup_path_simplify.patch	1.02 KB

as you have comitted the db_result patch there is no more need for this one as db_result now can't return NULL. Sorry for not making this clear previously.