It is impossible to theme menus differently. You need developer skills and a fair amount of knowledge about the menu system to alter the output of a certain menu.

Attached patch fixes this bug by leveraging the theme system's capability of theme function suggestions.

No API change, no functional change, just an additional theme suggestion.

CommentFileSizeAuthor
#14 drupal.menu-theme.14.patch1.11 KBeffulgentsia
#2 drupal.menu-theme.2.patch1.15 KBsun
drupal.menu-theme.patch1.28 KBsun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

Just found #588148: theme_links() is not really themeable, which tries to do the same to theme_links.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
FileSize
drupal.menu-theme.2.patch1.15 KB

Updated for the more failsafe naming standard mentioned in #588148: theme_links() is not really themeable

mooffie’s picture

mooffie CreditAttribution: mooffie commented

In addition to your proposal,

Wouldn't it be nice to do drupal_alter('menu_tree_output', $output, $menu_name) on the result of menu_tree_output()?

Rationale:

Overriding theme_menu_link() and theme_menu_tree() is nice, but inside these two functions you still don't know about the surrounding items. E.g., inside theme_menu_link() you don't know your position so you can't add 'odd' / 'even' classes.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

For that, you can use http://api.drupal.org/api/function/hook_block_view_alter/7

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

Anything left here?

sun requested that failed test be re-tested.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

Marked #408148: Create sub-theme functions for rendering menus as dup.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

So is this RTBC?

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

Looks great. We're a bit too late for #408150: Add "Welcome, $username" to user links but still nice to have

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented

Please also see #653622: Make the '__' pattern for theme suggestions easier to use.

Status: Reviewed & tested by the community » Needs review

Re-test of drupal.menu-theme.2.patch from comment #2 was requested by webchick.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented
Status: Needs review » Reviewed & tested by the community

as per #9

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work

I committed #653622: Make the '__' pattern for theme suggestions easier to use. This one will need a re-roll.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented
Status: Needs work » Reviewed & tested by the community
FileSize
drupal.menu-theme.14.patch1.11 KB

re-rolled.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs documentation

In retrospect, it's probably a bit late for all three of these patches, but since I committed the first in the series, I guess we might as well finish the set. At least it doesn't break anything. :) (famous last words)

Committed to HEAD. Needs documenting in the theme upgrade guide.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented
Assigned: sun » Unassigned

I started to document this, but stopped, realizing that a bug that was fixed in D6, but not yet in D7 is preventing this particular use-case from working. I think it makes sense to have #241570: Theme preprocess functions do not get retained when using patterns get resolved before telling theme developers about this cool new toy that doesn't work yet.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented
Status: Needs work » Postponed

Changing status to reflect #16.

hass’s picture

hass CreditAttribution: hass commented

#338027: Better menu template suggestion has been marked as duplicate

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented
Status: Postponed » Fixed

#241570: Theme preprocess functions do not get retained when using patterns landed, so: http://drupal.org/update/theme/6/7#theme-suggestions-for-menus.

Please see #588148-39: theme_links() is not really themeable for a still open question about how to best document the same for theme_links().

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

frogrod’s picture

frogrod CreditAttribution: frogrod commented

it doesn't work when the menu name is longer than one word.

[menu_name] => secondary-menu

you can't have dashes in php function names

themeName_menu_link__management -works

but it never pics up the secondary menu

intel_agate_menu_link__secondary_menu it's trying to match the - and not an underscore.

jitse’s picture

jitse CreditAttribution: jitse commented

I would like to confirm #21.
As PHP does not allow dashes in function signatures using the proposed naming method does not work for newly created menus as new menunames are always prepended with menu.

No time to look into the theme suggestions so no further contributions there.

Elijah Lynn’s picture

Elijah Lynn
Location Portland, Oregon
CreditAttribution: Elijah Lynn commented
Issue summary: View changes
Related issues: +#1001146: Cannot theme links in a menu when menu_name contains a hyphen.