By dries on

I'm increasingly confident in Drupal 4.1.0's release readiness. As such, chances are we'll release Drupal 4.1.0 within two weeks. I've seen quite a few production sites that use the Drupal 4.1.0 release candidate, yet it is desirable to have it tested in a diverse set of setups. If you have a Drupal 4.0.0 site and you want to help quality assurance testing, consider upgrading now. We tend to be much more responsive to bug reports and upgrade problems _before_ the actual release, so there is little to loose (as long you have a backup, that is).

Please report back after upgrading; good or bad. Thanks.

(Note that the modules and themes in the contributions repository might be dated and that they are not officially supported. To the authors and maintainers of such modules and themes; this would mark the appropriate time to put the champagne aside and to update your work.)

Comments

taybin@piratesvsninjas.com’s picture

taybin@piratesvsninjas.com commented

My site, piratesvsninjas.com, works fine with the release candidate.

Anonymous’s picture

(not verified) commented

Is this the same snapshot as the initial 4.1.0 RC or is it updated CVS code (patches, etc.)?

ax’s picture

ax commented

http://drupal.org/node.php?id=874:

The release candidate is repackaged twice a day so make sure to download a fresh copy every now and then to get the latest fixes.

alexmc’s picture

alexmc commented

I think it is unhelpful to have the release candidate repackaged every day. It should be fairly static and only have a few bugs fixed explicitly each time. If I report a bug on the release candidate I thus have to tell you what day it was downloaded on.... yuck.

AlexMc

dries’s picture

dries commented

You don't have to tell us; we know what we have fixed (and thus whether you have an old version or not).

David Poblador i Garcia’s picture

David Poblador i Garcia commented

After 3 days of testing I've migrated PUNTBARRA.COM to 4.1 and everything works fine.

ax’s picture

ax commented

those are easy to fix. i'll submit patches if nobody else will (and if someone comments on this).

moshe weitzman’s picture

moshe weitzman commented

i would welcome patches on these. they don't affect me really, but i know others will become frustrated

jibbajabba@iaslash.org’s picture

jibbajabba@iaslash.org commented

Through trial and error, I found that theme names with spaces in theme were causing the blank screen problem. I think this is fixed by changing:

$system["name"] = "Stone Age";

to

$system["name"] = "StoneAge";

Can this be confirmed? If this is correct, can the theme names be changed in the RC and CVS?

dries’s picture

dries commented

I fixed the problem in both Drupal CVS and Drupal 4.1.0-rc. I had to rename "Stone Age" to "example" though. Drop me a line when the problem persists. Thanks.

ax’s picture

ax commented

as well? ie. something like

UPDATE system set name = 'example' WHERE name = 'Stone Age'
UPDATE variable set theme_default = 'example' WHERE theme_default = 'Stone Age'
UPDATE users set theme = 'example' WHERE theme = 'Stone Age'

(or isn't this necessary?)

ax’s picture

ax commented
ax’s picture

ax commented

now only two left open

Anonymous’s picture

(not verified) commented

How could I fix it? Where could I find the patches?

best
hdhd

Steven’s picture

Steven commented

I just updated acko.net and experienced the following problems:

  • PHP pages have become unusable because the HTML-tag stripper is applied to them, causing havoc in code.
  • PHP pages cannot be promoted to the front-page (not sure if this was the intention) because the teaser will contain only part of the code.
  • Backslashes are magically disappearing, with all magic_quotes disabled, like Drupal reminded me to do. There is a difference between the slashes present in a post when previewing and when viewing later. Test:
    • One slash:
    • Two slashes: \
    • Three slashes: \
    • Four slashes: \\
    • Eight slashes: \\\\

    By previewing, another round of slashstripping is applied, which I avoided now immediately submitting.

ax’s picture

ax commented

i noticed that on drupal.org, exclamation marks get stripped as well. test:

  • One exclamation mark:
  • Two exclamation marks:
  • Three exclamation marks:
  • Four exclamation marks:
  • Eight exclamation marks:
ax’s picture

ax commented

this doesn't happen on my latest, fresh rc install, though. hmmm ...

dries’s picture

dries commented

I'm afraid the exclamation mark problem is specific to Drupal.org (not Drupal); I'm afraid it is a bug in the PHP version Drupal.org is running on. Investigation learns that it triggers in the HTML filter code, node_filter_html() which makes me believe it is a bug in PHP's strip_tags().

ax’s picture

ax commented

4.3.0-dev? then the reason might be this php bug (PHP Bugs: #20664: strip_tags strips out exclaimation () points). according to the bug report, this has been fixed in php CVS on 27 Nov 2002, so it should go away after upgrading to 4.3.0 final (which has been released on 27-Dec-2002).

note that when upgrading php, i would go for the latest stable 4.3 snapshot (available from http://snaps.php.net/) instead of the official 4.3 release because former fixes (sometimes quite annoying) bugs. see http://cvs.php.net/cvs.php/php4/NEWS (Branch: PHP_4_3 only)

mathieu’s picture

mathieu commented

I am trying to setup my site and it works pretty well, except for a few things.. :

When I try to translate (adming->locales) a string using a translation that contains an apostrophe (single quote), I get a error in the sql query (invalid query). Seems like an addslashes() is missing somewhere; I'd try adding a call to addslashes($value) in the call to db_query(...) in function locale_save($lid) in locale.module, but I really don't know Drupal (and pear) well enough to be sure about this.

I can't seem to import an rdf feed (rss works fine, though). Specifically, I can't import kuro5hin feed (www.kuro5hin.org/backend.rdf). Is it a problem with this feed or is it something with Drupal?

Maybe these are already fixed in cvs... is it safe to use the version in cvs?

Thanks

dries’s picture

dries commented

mathieu, could you tell us what query fails and for which example string?

mathieu’s picture

mathieu commented

Well, I forgot the string (it was late, I was tired, ... ) Only local images are allowed.. After posting my original post, I tried again, with other strings, and it worked. I suppose that I'll see ("stumble upon") the original string again soon as we are in the process of translating the site. I'll post the query then...

Sorry.

As for kuro5hin, we can get it by myrss ... though, myrss doesn't create a really good feed. Maybe I'll ask on kuro5hin.

Thanks.

David Poblador i Garcia’s picture

David Poblador i Garcia commented

I've never been able to import k5 feed since I'm using Drupal (4.0 and 4.1). I bet it is not a Drupal problem. If you look at K5 export you'll see its slightly different (may be another RDF version??) than others.

Anonymous’s picture

(not verified) commented

I've seen no mention of this issue being addressed, which I posted
to the support list on Jan 3, located at: http://list.drupal.org/drupal-support/2003-January/003741.html

The (slightly edited) text of the message is here:

A couple days ago, I made a post about anonymous users being able
to post a story and it will be immediately available on the site,
unmoderated and with a moderator knowledge.

The reason is because the default value of the 'status' field on node
table is '1', or 'published'. I have the queue module disabled. I
haven't looked, but is it possible that the the sql selecting a set of
nodes to display, only does a "where status = 1" and doesn't restrict by
the moderation field. I have the queue module disabled.

You can see what I was able to do here:
http://mshiltonj.com/kt-shot.png

Immediate after doing that (I wasn't sure it was possible at the time), I emailed the
KernalTrap editors. They have since deleted the stories. I also emailed the drupal support list.

The stories don't go to the front page, but if you have the taxonomy_html
module enabled, which I will and kernal trap does, links to the 'inside' sections
are in the navigation, and that is where the unapproved-but-visible stories
are accessable.

A malicious user could have posted any sort or spam, or porn,
or fake-but-seemingly-approved news story.

If I may, and I hope to not sound presumptuous, I suggest: make the
default value of the 'status' column in the node table to be 0 and not
1. This makes stories 'unpublished' by default.

This means that moderators, to post a story, would have to set the
"moderation" to "approved" *and* "published" to "enabled" for a story to
be live on the site, unless you code it to be smart enough to do both on
one action.

Also, in the "content management" administration, there is no option
that does a select on nodes where status = 0 and moderation = 1
(unpublished, needs-moderation) The only way to view such stories
is to view 'new nodes.' But new nodes can be both published and moderated.

dries’s picture

dries commented

Kerneltrap is not running Drupal 4.1.0-rc; it is running a modified Drupal 4.0.0. Are you sure the problem hasn't been fixed in Drupal 4.1.0-rc?

Anonymous’s picture

(not verified) commented

I was running the code from the drupal-4.1.0-rc.tgz file
index.php: $Id: index.php,v 1.54.2.1 2002/12/26 12:14:53 dries Exp $
node.php: $Id: node.php,v 1.46 2002/11/03 20:56:16 dries Exp $
modules/node.php: $Id: node.module,v 1.159.2.6 2002/12/21 19:36:56 kjartan Exp $

Anonymous’s picture

(not verified) commented

comment moderation seems to work fine, however, it seems the comment_moderation() function has been silently deprecated. What's the proper usage now?

moshe weitzman’s picture

moshe weitzman commented

could you please elaborate. comment moderation is enabled in Admin and then used by appropriately priveleged users.

anarcat’s picture

anarcat commented

Yes, comment moderation works. It's just that there is no way to see the score of a particular comment apart from trying to pinpoint it using the threshold functions.

I should have been more specific. The comment_moderation() function, as I understand it, should return the score of a comment. It is used in many themes to display the score of the comment in a comment box. Right now, the function does nothing and returns nothing, so comment scores are not displayed in comments. That is the problem I'm trying to raise here, if it is a problem. If it's a design decision, then the devel handbook should be updated.

Thank you

moshe weitzman’s picture

moshe weitzman commented

the comment_moderation() function used to return an HTML form with options for submitting a vote. this function is no longer needed, since comment.module inserts the same form using the _link() hook. no theme interaction needed. i have updated the relevant book page, thanks for pointing this out.

if you want to access the current score in your theme, just use $comment->score (untested - please report a bug if this is unavailable).

MaraudeR’s picture

MaraudeR commented

Excuse my other comment, I've just beggining to use Drupal and I'm a bit lost still even about searching answers. Thanks a million.

MaraudeR’s picture

MaraudeR commented

It seems like that function has been deprecated:

From comment.module:

// backward compatibility with some themes
function comment_moderation() {
}

but I've not found another function to do it. Is there an answer to this question?

amy-at-spiffariffic.com’s picture

amy-at-spiffariffic.com commented

My statistics module seems to work for the most part but for the block and the "front page" of the statistics section that is supposed to show today's top nodes, all time top nodes, and last nodes viewed. The other sections ( view referrers, view access log ) work, so the data is being collected.

This is for osxgoodies.com, which is running 4.1RC as of a couple days ago I believe. (Where's the easiest place to find my version #?)

gene@csof.net’s picture

gene@csof.net commented

if the admin panels displayed it somewhere obvious that would be nice

ax’s picture

ax commented

chances are we'll release Drupal 4.1.0 within two weeks

01/23/2003 (today) - 01/02/2003 (day of post) = 21 days = 3 weeks ...

Anonymous’s picture

(not verified) commented

Well, I was wondering when CVS would be back up, so I thought I'd ask in the news forums. I don't have a username, so I can't post topics. I thought I'd create a username. Created one. Never got the email. Set up your MX records right. Get cvs.drupal.org up and running. Not very impressed.

ben-2’s picture

ben-2 commented
  1. Demanding volunteers to do something is no way to influence a project.
  2. I seriously doubt they are doing this to impress you...
  3. Are you sure you actually know what an MX record is? drupal.org's primary mail exchanger is listed as mail.drupal.org. That machine is up and running and accepting SMTP connections. Why do you think the MX is not set up properly?

Just be nice to folks working on a volunteer basis.

bertboerland’s picture

bertboerland commented

yes, drupal moved hardware, isp, dns, os etc so some minor stuff -including cvs- wasnt working for a couple of days... instead of screaming, it looks better to ask to help the people. as far as the mx records go, you might want to rethink about that. has nothing to do with outgoing mail. mta's do however, and there was a slight problem.

so you are not impressed with drupal. and your judgement is based upon "all the right criteria", you have the freedom to move on and shout at another project.

please do.

--
groets

bertb

--
groets
bert boerland