Online Review: Review of the 7.x-1.x branch: ./unity3d_field.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming function unity3d_validate_image($element, &$form_state) { Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment. This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner. FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt -------------------------------------------------------------------------------- FOUND 1 ERROR(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 15 | ERROR | Files must end in a single new line character -------------------------------------------------------------------------------- FILE: ...es/all/modules/pareview_temp/test_candidate/theme/unity3d_field.tpl.php -------------------------------------------------------------------------------- FOUND 2 ERROR(S) AFFECTING 2 LINE(S) -------------------------------------------------------------------------------- 26 | ERROR | Comment indentation error, expected only 1 spaces 35 | ERROR | Files must end in a single new line character -------------------------------------------------------------------------------- FILE: ...tes/all/modules/pareview_temp/test_candidate/theme/unity3d_logo.tpl.php -------------------------------------------------------------------------------- FOUND 11 ERROR(S) AFFECTING 11 LINE(S) -------------------------------------------------------------------------------- 10 | ERROR | The control statement should use the ":" alternative syntax | | instead of curly braces in template files 12 | ERROR | The control statement should use the ":" alternative syntax | | instead of curly braces in template files 15 | ERROR | Whitespace found at end of line 28 | ERROR | The control statement should use the ":" alternative syntax | | instead of curly braces in template files 29 | ERROR | Spaces must be used to indent lines; tabs are not allowed 30 | ERROR | Spaces must be used to indent lines; tabs are not allowed 31 | ERROR | Spaces must be used to indent lines; tabs are not allowed 32 | ERROR | Spaces must be used to indent lines; tabs are not allowed 33 | ERROR | Spaces must be used to indent lines; tabs are not allowed 34 | ERROR | Spaces must be used to indent lines; tabs are not allowed 42 | ERROR | Files must end in a single new line character -------------------------------------------------------------------------------- FILE: ...eview/sites/all/modules/pareview_temp/test_candidate/unity3d_field.info -------------------------------------------------------------------------------- FOUND 1 ERROR(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 8 | ERROR | Files must end in a single new line character -------------------------------------------------------------------------------- FILE: ...iew/sites/all/modules/pareview_temp/test_candidate/unity3d_field.module -------------------------------------------------------------------------------- FOUND 24 ERROR(S) AFFECTING 21 LINE(S) -------------------------------------------------------------------------------- 2 | ERROR | Missing file doc comment 169 | ERROR | Array indentation error, expected 6 spaces but found 8 169 | ERROR | Array closing indentation error, expected 6 spaces but found 8 179 | ERROR | Array indentation error, expected 6 spaces but found 8 179 | ERROR | Array closing indentation error, expected 6 spaces but found 8 190 | ERROR | Missing parameter type at position 1 193 | ERROR | Last parameter comment requires a blank newline after it 193 | ERROR | Missing parameter type at position 2 202 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2 203 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2 238 | ERROR | Break statement indented incorrectly; expected 6 spaces, found 4 250 | ERROR | Break statement indented incorrectly; expected 6 spaces, found 4 267 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 4 268 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 4 275 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 4 276 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 4 277 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 4 284 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 4 285 | ERROR | Break statement indented incorrectly; expected 6 spaces, found 4 323 | ERROR | Break statement indented incorrectly; expected 6 spaces, found 4 350 | ERROR | Inline control structures are not allowed 356 | ERROR | Concatenating translatable strings is not allowed, use | | placeholders instead and only one string literal 357 | ERROR | Concatenating translatable strings is not allowed, use | | placeholders instead and only one string literal 395 | ERROR | Files must end in a single new line character -------------------------------------------------------------------------------- Source: http://ventral.org/pareview - PAReview.sh online service --------------------------------------------------------------------------------