From 315aeb602ef54285159cd412294792366c5274d2 Mon Sep 17 00:00:00 2001 From: Claudiu Cristea Date: Sun, 25 Aug 2013 14:20:53 +0300 Subject: [PATCH] Issue #2066879 by claudiu.cristea: Apply coding standards for interface method declarations. --- core/lib/Drupal/Component/Gettext/PoMetadataInterface.php | 9 +++++---- core/lib/Drupal/Component/Gettext/PoReaderInterface.php | 3 ++- core/lib/Drupal/Component/Gettext/PoStreamInterface.php | 9 +++++---- core/lib/Drupal/Component/Gettext/PoWriterInterface.php | 5 +++-- core/lib/Drupal/Core/FileTransfer/ChmodInterface.php | 3 ++- .../Core/KeyValueStore/KeyValueStoreExpirableInterface.php | 6 +++--- .../Drupal/Core/StreamWrapper/StreamWrapperInterface.php | 3 ++- .../Drupal/ckeditor/CKEditorPluginConfigurableInterface.php | 2 +- .../ContentTranslationControllerInterface.php | 1 + .../lib/Drupal/editor/Plugin/EditorPluginInterface.php | 13 +++++++------ 10 files changed, 31 insertions(+), 23 deletions(-) diff --git a/core/lib/Drupal/Component/Gettext/PoMetadataInterface.php b/core/lib/Drupal/Component/Gettext/PoMetadataInterface.php index f5bb3db..18ae1fc 100644 --- a/core/lib/Drupal/Component/Gettext/PoMetadataInterface.php +++ b/core/lib/Drupal/Component/Gettext/PoMetadataInterface.php @@ -23,7 +23,7 @@ * @param string $langcode * Language code string. */ - function setLangcode($langcode); + public function setLangcode($langcode); /** * Get language code. @@ -31,7 +31,7 @@ function setLangcode($langcode); * @return string * Language code string. */ - function getLangcode(); + public function getLangcode(); /** * Set header metadata. @@ -39,7 +39,7 @@ function getLangcode(); * @param Drupal\Component\Gettext\PoHeader $header * Header object representing metadata in a PO header. */ - function setHeader(PoHeader $header); + public function setHeader(PoHeader $header); /** * Get header metadata. @@ -47,5 +47,6 @@ function setHeader(PoHeader $header); * @return Drupal\Component\Gettext\PoHeader $header * Header instance representing metadata in a PO header. */ - function getHeader(); + public function getHeader(); + } diff --git a/core/lib/Drupal/Component/Gettext/PoReaderInterface.php b/core/lib/Drupal/Component/Gettext/PoReaderInterface.php index e9c0125..5e45e4a 100644 --- a/core/lib/Drupal/Component/Gettext/PoReaderInterface.php +++ b/core/lib/Drupal/Component/Gettext/PoReaderInterface.php @@ -20,5 +20,6 @@ * @return Drupal\Component\Gettext\PoItem * Wrapper for item data instance. */ - function readItem(); + public function readItem(); + } diff --git a/core/lib/Drupal/Component/Gettext/PoStreamInterface.php b/core/lib/Drupal/Component/Gettext/PoStreamInterface.php index c9f9e34..8a0a809 100644 --- a/core/lib/Drupal/Component/Gettext/PoStreamInterface.php +++ b/core/lib/Drupal/Component/Gettext/PoStreamInterface.php @@ -18,12 +18,12 @@ /** * Open the stream. Set the URI for the stream earlier with setURI(). */ - function open(); + public function open(); /** * Close the stream. */ - function close(); + public function close(); /** * Get the URI of the PO stream that is being read or written. @@ -31,7 +31,7 @@ function close(); * @return * URI string for this stream. */ - function getURI(); + public function getURI(); /** * Set the URI of the PO stream that is going to be read or written. @@ -39,5 +39,6 @@ function getURI(); * @param $uri * URI string to set for this stream. */ - function setURI($uri); + public function setURI($uri); + } diff --git a/core/lib/Drupal/Component/Gettext/PoWriterInterface.php b/core/lib/Drupal/Component/Gettext/PoWriterInterface.php index 2a2348f..08c6836 100644 --- a/core/lib/Drupal/Component/Gettext/PoWriterInterface.php +++ b/core/lib/Drupal/Component/Gettext/PoWriterInterface.php @@ -21,7 +21,7 @@ * @param PoItem $item * One specific item to write. */ - function writeItem(PoItem $item); + public function writeItem(PoItem $item); /** * Writes all or the given amount of items. @@ -32,5 +32,6 @@ function writeItem(PoItem $item); * Amount of items to read from $reader to write. If -1, all items are * read from $reader. */ - function writeItems(PoReaderInterface $reader, $count = -1); + public function writeItems(PoReaderInterface $reader, $count = -1); + } diff --git a/core/lib/Drupal/Core/FileTransfer/ChmodInterface.php b/core/lib/Drupal/Core/FileTransfer/ChmodInterface.php index c1c68cb..1d716f4 100644 --- a/core/lib/Drupal/Core/FileTransfer/ChmodInterface.php +++ b/core/lib/Drupal/Core/FileTransfer/ChmodInterface.php @@ -24,5 +24,6 @@ * * @see http://php.net/chmod */ - function chmodJailed($path, $mode, $recursive); + public function chmodJailed($path, $mode, $recursive); + } diff --git a/core/lib/Drupal/Core/KeyValueStore/KeyValueStoreExpirableInterface.php b/core/lib/Drupal/Core/KeyValueStore/KeyValueStoreExpirableInterface.php index e39dbe5..2ccc4aa 100644 --- a/core/lib/Drupal/Core/KeyValueStore/KeyValueStoreExpirableInterface.php +++ b/core/lib/Drupal/Core/KeyValueStore/KeyValueStoreExpirableInterface.php @@ -22,7 +22,7 @@ * @param int $expire * The time to live for items, in seconds. */ - function setWithExpire($key, $value, $expire); + public function setWithExpire($key, $value, $expire); /** * Sets a value for a given key with a time to live if it does not yet exist. @@ -37,7 +37,7 @@ function setWithExpire($key, $value, $expire); * @return bool * TRUE if the data was set, or FALSE if it already existed. */ - function setWithExpireIfNotExists($key, $value, $expire); + public function setWithExpireIfNotExists($key, $value, $expire); /** * Saves an array of values with a time to live. @@ -47,6 +47,6 @@ function setWithExpireIfNotExists($key, $value, $expire); * @param int $expire * The time to live for items, in seconds. */ - function setMultipleWithExpire(array $data, $expire); + public function setMultipleWithExpire(array $data, $expire); } diff --git a/core/lib/Drupal/Core/StreamWrapper/StreamWrapperInterface.php b/core/lib/Drupal/Core/StreamWrapper/StreamWrapperInterface.php index 15ba2cf..9830a01 100644 --- a/core/lib/Drupal/Core/StreamWrapper/StreamWrapperInterface.php +++ b/core/lib/Drupal/Core/StreamWrapper/StreamWrapperInterface.php @@ -38,7 +38,7 @@ * @param string $uri * A string containing the URI that should be used for this instance. */ - function setUri($uri); + public function setUri($uri); /** * Returns the stream resource URI. @@ -122,4 +122,5 @@ public function realpath(); * @see drupal_dirname() */ public function dirname($uri = NULL); + } diff --git a/core/modules/ckeditor/lib/Drupal/ckeditor/CKEditorPluginConfigurableInterface.php b/core/modules/ckeditor/lib/Drupal/ckeditor/CKEditorPluginConfigurableInterface.php index ba3ce86..5b09f81 100644 --- a/core/modules/ckeditor/lib/Drupal/ckeditor/CKEditorPluginConfigurableInterface.php +++ b/core/modules/ckeditor/lib/Drupal/ckeditor/CKEditorPluginConfigurableInterface.php @@ -40,6 +40,6 @@ * @return array|FALSE * A render array for the settings form, or FALSE if there is none. */ - function settingsForm(array $form, array &$form_state, Editor $editor); + public function settingsForm(array $form, array &$form_state, Editor $editor); } diff --git a/core/modules/content_translation/lib/Drupal/content_translation/ContentTranslationControllerInterface.php b/core/modules/content_translation/lib/Drupal/content_translation/ContentTranslationControllerInterface.php index b28dd8d..109747e 100644 --- a/core/modules/content_translation/lib/Drupal/content_translation/ContentTranslationControllerInterface.php +++ b/core/modules/content_translation/lib/Drupal/content_translation/ContentTranslationControllerInterface.php @@ -171,4 +171,5 @@ public function retranslate(EntityInterface $entity, $langcode = NULL); * The entity being created or edited. */ public function entityFormAlter(array &$form, array &$form_state, EntityInterface $entity); + } diff --git a/core/modules/editor/lib/Drupal/editor/Plugin/EditorPluginInterface.php b/core/modules/editor/lib/Drupal/editor/Plugin/EditorPluginInterface.php index 87f8840..f9bc390 100644 --- a/core/modules/editor/lib/Drupal/editor/Plugin/EditorPluginInterface.php +++ b/core/modules/editor/lib/Drupal/editor/Plugin/EditorPluginInterface.php @@ -26,7 +26,7 @@ * An array of settings as they would be stored by a configured text editor * entity (\Drupal\editor\Entity\Editor). */ - function getDefaultSettings(); + public function getDefaultSettings(); /** * Returns a settings form to configure this text editor. @@ -46,7 +46,7 @@ function getDefaultSettings(); * @return array * A render array for the settings form. */ - function settingsForm(array $form, array &$form_state, Editor $editor); + public function settingsForm(array $form, array &$form_state, Editor $editor); /** * Validates the settings form for an editor. @@ -60,7 +60,7 @@ function settingsForm(array $form, array &$form_state, Editor $editor); * @param array $form_state * A reference to a keyed array containing the current state of the form. */ - function settingsFormValidate(array $form, array &$form_state); + public function settingsFormValidate(array $form, array &$form_state); /** * Modifies any values in the form state to prepare them for saving. @@ -73,7 +73,7 @@ function settingsFormValidate(array $form, array &$form_state); * @param array $form_state * A reference to a keyed array containing the current state of the form. */ - function settingsFormSubmit(array $form, array &$form_state); + public function settingsFormSubmit(array $form, array &$form_state); /** * Returns JavaScript settings to be attached. @@ -93,7 +93,7 @@ function settingsFormSubmit(array $form, array &$form_state); * @see drupal_process_attached() * @see EditorManager::getAttachments() */ - function getJSSettings(Editor $editor); + public function getJSSettings(Editor $editor); /** * Returns libraries to be attached. @@ -112,5 +112,6 @@ function getJSSettings(Editor $editor); * @see drupal_process_attached() * @see EditorManager::getAttachments() */ - function getLibraries(Editor $editor); + public function getLibraries(Editor $editor); + } -- 1.8.3.1