Review of the 7.x-1.x branch (commit 244a7fe): Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment. DrupalPractice has found some issues with your code, but could be false positives. FILE: ...upal-7-pareview/pareview_temp/examples/example/ynot/example-block.inc --------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------- 16 | WARNING | Variable $yfile is undefined. 17 | WARNING | Variable $yfile is undefined. --------------------------------------------------------------------------- FILE: ...rupal-7-pareview/pareview_temp/examples/example/ynot/example-page.inc --------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES --------------------------------------------------------------------------- 27 | WARNING | Variable $yfile is undefined. 28 | WARNING | Variable $yfile is undefined. 31 | WARNING | Variable $node is undefined. 32 | WARNING | Variable $node is undefined. --------------------------------------------------------------------------- FILE: /var/www/drupal-7-pareview/pareview_temp/ynot.api.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 61 | WARNING | Unused variable $type. 62 | WARNING | Unused variable $key. ---------------------------------------------------------------------- FILE: /var/www/drupal-7-pareview/pareview_temp/ynot.module ---------------------------------------------------------------------- FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES ---------------------------------------------------------------------- 238 | WARNING | Unused variable $namespace. 560 | WARNING | Unused variable $type. 561 | WARNING | Unused variable $key. 634 | WARNING | Unused variable $address. 708 | WARNING | Unused variable $module. 769 | WARNING | Unused variable $address. ---------------------------------------------------------------------- Time: 230ms; Memory: 15.25Mb No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development. This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me. FILE: /var/www/drupal-7-pareview/pareview_temp/README.md ------------------------------------------------------------------------- FOUND 1 ERROR AND 29 WARNINGS AFFECTING 30 LINES ------------------------------------------------------------------------- 6 | WARNING | [ ] Line exceeds 80 characters; contains 197 characters 10 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters 11 | WARNING | [ ] Line exceeds 80 characters; contains 158 characters 12 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters 13 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters 26 | WARNING | [ ] Line exceeds 80 characters; contains 108 characters 49 | ERROR | [x] Missing file doc comment 55 | WARNING | [ ] Line exceeds 80 characters; contains 300 characters 57 | WARNING | [ ] Line exceeds 80 characters; contains 276 characters 59 | WARNING | [ ] Line exceeds 80 characters; contains 466 characters 65 | WARNING | [ ] Line exceeds 80 characters; contains 130 characters 72 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters 75 | WARNING | [ ] Line exceeds 80 characters; contains 290 characters 78 | WARNING | [ ] Line exceeds 80 characters; contains 411 characters 81 | WARNING | [ ] Line exceeds 80 characters; contains 397 characters 84 | WARNING | [ ] Line exceeds 80 characters; contains 189 characters 86 | WARNING | [ ] Line exceeds 80 characters; contains 128 characters 88 | WARNING | [ ] Line exceeds 80 characters; contains 99 characters 93 | WARNING | [ ] Line exceeds 80 characters; contains 127 characters 96 | WARNING | [ ] Line exceeds 80 characters; contains 273 characters 99 | WARNING | [ ] Line exceeds 80 characters; contains 204 characters 102 | WARNING | [ ] Line exceeds 80 characters; contains 168 characters 105 | WARNING | [ ] Line exceeds 80 characters; contains 453 characters 106 | WARNING | [ ] Line exceeds 80 characters; contains 187 characters 109 | WARNING | [ ] Line exceeds 80 characters; contains 135 characters 118 | WARNING | [ ] Line exceeds 80 characters; contains 132 characters 121 | WARNING | [ ] Line exceeds 80 characters; contains 127 characters 133 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters 135 | WARNING | [ ] Line exceeds 80 characters; contains 122 characters 137 | WARNING | [ ] Line exceeds 80 characters; contains 139 characters ------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------- FILE: ...upal-7-pareview/pareview_temp/examples/example/ynot/example-block.inc --------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 3 LINES --------------------------------------------------------------------------- 14 | ERROR | [x] Missing file doc comment 16 | ERROR | [x] Expected 1 newline after opening brace; 0 found 18 | ERROR | [x] Closing brace must be on a line by itself 18 | ERROR | [x] A closing tag is not permitted at the end of a PHP file --------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------- FILE: ...rupal-7-pareview/pareview_temp/examples/example/ynot/example-page.inc --------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES --------------------------------------------------------------------------- 25 | ERROR | [x] Missing file doc comment 27 | ERROR | [x] Expected 1 newline after opening brace; 0 found 29 | ERROR | [x] Closing brace must be on a line by itself 31 | ERROR | [x] Expected 1 newline after opening brace; 0 found 33 | ERROR | [x] Closing brace must be on a line by itself --------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------