Index: uc_turkish_banks.module
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/uc_turkish_banks/uc_turkish_banks.module,v
retrieving revision 1.6
diff -u -r1.6 uc_turkish_banks.module
--- uc_turkish_banks.module	22 Jun 2008 20:39:58 -0000	1.6
+++ uc_turkish_banks.module	22 Jun 2008 21:01:46 -0000
@@ -3,13 +3,17 @@
 
 /**
  * @file
- * A module used for Bank payment gateway .
+ * A module used for Bank payment gateway.
  *
- * A module used to process payments using Banks in Turkey. Currently uses the EST e-secure payment service. This module currently supports instalments and as a paymant method uses 3D Secure OOS PAY.
+ * A module used to process payments using Banks in Turkey. Currently uses the
+ * EST e-secure payment service. This module currently supports instalments and
+ * as a paymant method uses 3D Secure OOS PAY.
  *
- * Türk Bankaları için ödeme eklentisidir. EST Güvenli e-ödeme servisi kullanmaktadır. Taksitli satışı desteklemektedir. Satış yöntemi olarak 3D Secure OOS PAY metodunu kullanmaktadır.
+ * Türk Bankaları için ödeme eklentisidir. EST Güvenli e-ödeme servisi
+ * kullanmaktadır. Taksitli satışı desteklemektedir. Satış yöntemi olarak
+ * 3D Secure OOS PAY metodunu kullanmaktadır.
  *
- * Support the following banks / Asagidaki bankalar desteklenmektedir.
+ * Supports the following banks / Asagidaki bankalar desteklenmektedir.
  *
  *  1. İş Bankası
  *  2. Akbank
@@ -116,12 +120,15 @@
   return $items;
 }
 
+/**
+ * Implementation of hook_perm().
+ */
 function uc_turkish_banks_perm() {
-  return array('1' => 'view banks', '1' => 'manage banks');
+  return array('view banks', 'manage banks');
 }
 
 function uc_turkish_banks_instalments_display() {
-  $cid=arg(5);
+  $cid = arg(5);
   $result = db_query("SELECT cid, instalment, instalment_ratio, valid_until FROM {uc_turkish_banks_instalments} where cid = %d ORDER BY instalment", $cid);
   $rows = array();
   while ($row = db_fetch_object($result)) {
@@ -132,16 +139,17 @@
       $value = '$'. $row->value;
     }
     $rows[] = array(
-    $row->cid,
-    $row->instalment,
-    $row->instalment_ratio,
-    format_date($row->valid_until, 'custom', 'd/m/Y'),
-    l(t('delete'), "admin/store/settings/banks/instalments/$row->cid/$row->instalment/delete"));
+      $row->cid,
+      $row->instalment,
+      $row->instalment_ratio,
+      format_date($row->valid_until, 'custom', 'd/m/Y'),
+      l(t('delete'), "admin/store/settings/banks/instalments/$row->cid/$row->instalment/delete")
+    );
   }
 
   $header = array(array('data' => 'Instalment', 'width' => '10'), 'Ratio', 'Valid Until', 'Ops');
   $output .= theme('table', $header, $rows, array('width' => '100%'));
-  if ($output == null) {
+  if ($output == NULL) {
     $output = "<p>There are currently no instalments in the system.</p>";
   }
   $output .=  l(t('Add a new instalment'), "admin/store/settings/banks/instalments/add/$cid");
@@ -215,9 +223,9 @@
  */
 function uc_turkish_banks_instalments_add_form_submit($form_id, $form) {
   $valid_until = mktime(23, 59, 59,
-  $form['valid_until']['month'], 
-  $form['valid_until']['day'],
-  $form['valid_until']['year']
+    $form['valid_until']['month'],
+    $form['valid_until']['day'],
+    $form['valid_until']['year']
   );
   $result = db_query("INSERT INTO {uc_turkish_banks_instalments} (cid, instalment, instalment_ratio, valid_until)
     VALUES (%d, %d, %f, %d)", $form['cid'], $form['instalment'], $form['instalment_ratio'], $valid_until);
@@ -238,11 +246,11 @@
   $form['cid'] = array('#type' => 'value', '#value' => $cid);
   $form['instalment'] = array('#type' => 'value', '#value' => $instalment);
   return confirm_form($form,
-  t('Confirm Deletion of instalment %instalment', array('%instalment' => $instalment)),
+    t('Confirm Deletion of instalment %instalment', array('%instalment' => $instalment)),
     'admin/store/settings/banks/instalments/'. $cid, 
-  t('Are you sure?'),
-  t('Delete'),
-  t('Cancel')
+    t('Are you sure?'),
+    t('Delete'),
+    t('Cancel')
   );
 }
 
@@ -364,7 +372,7 @@
     '#options' => array(
       'Auth' => t('Auth'),
       'PreAuth' => t('PreAuth'),
-  ),
+    ),
     '#weight' => 1,
     '#required' => true,
   );
@@ -412,17 +420,16 @@
  */
 function uc_turkish_banks_add_form_submit($form_id, $form) {
   $valid_until = mktime(23, 59, 59,
-  $form['valid_until']['month'],
-  $form['valid_until']['day'],
-  $form['valid_until']['year']
+    $form['valid_until']['month'],
+    $form['valid_until']['day'],
+    $form['valid_until']['year']
   );
 
   if (!isset($form['cid'])) {
-
-    if (db_query("INSERT INTO {uc_turkish_banks} (bankname,clientid,username,password,bankurl,storekey,processtype,cardname,valid_until)
-                  VALUES ('%s','%s','%s','%s','%s','%s','%s','%s', '%d')",
-    $form['bankname'], $form['clientid'], $form['username'], $form['password'], $form['bankurl'], $form['storekey'], $form['processtype'], $form['cardname'], $valid_until
-    )) {
+    if (db_query("INSERT INTO {uc_turkish_banks} (bankname, clientid, username, password, bankurl, storekey, processtype, cardname, valid_until)
+      VALUES ('%s','%s','%s','%s','%s','%s','%s','%s', '%d')",
+      $form['bankname'], $form['clientid'], $form['username'], $form['password'], $form['bankurl'], $form['storekey'], $form['processtype'], $form['cardname'], $valid_until))
+    {
       $message = "New bank {$form['name']} added succesfully";
     }
     else {
@@ -431,8 +438,9 @@
   }
   else {
     // Otherwise we try to update the coupon with matching coupon id
-    if (db_query("UPDATE {uc_turkish_banks} SET bankname = '%s', clientid = '%s',username = '%s',password = '%s',bankurl = '%s',storekey = '%s',processtype = '%s',cardname = '%s',valid_until = %d WHERE cid = %d",
-      $form['bankname'], $form['clientid'], $form['username'], $form['password'], $form['bankurl'], $form['storekey'], $form['processtype'], $form['cardname'], $valid_until, $form['cid'])) {
+    if (db_query("UPDATE {uc_turkish_banks} SET bankname = '%s', clientid = '%s', username = '%s', password = '%s', bankurl = '%s', storekey = '%s', processtype = '%s', cardname = '%s', valid_until = %d WHERE cid = %d",
+      $form['bankname'], $form['clientid'], $form['username'], $form['password'], $form['bankurl'], $form['storekey'], $form['processtype'], $form['cardname'], $valid_until, $form['cid']))
+    {
       $message = "Bank updated succssfully";
     }
     else {
@@ -461,11 +469,11 @@
 function uc_turkish_banks_delete_confirm($cid) {
   $form['cid'] = array('#type' => 'value', '#value' => $cid);
   return confirm_form($form,
-  t('Confirm Deletion of Bank %cid', array('%cid' => $cid)),
+    t('Confirm Deletion of Bank %cid', array('%cid' => $cid)),
     'admin/store/settings/banks', 
-  t('Are you sure ?'),
-  t('Delete'),
-  t('Cancel')
+    t('Are you sure ?'),
+    t('Delete'),
+    t('Cancel')
   );
 }
 
@@ -489,7 +497,7 @@
     case 'save':
       list($bank_temp, $amount_temp, $bank_cid, $taksit)=explode('|', $_SESSION['taksit']);
       //print "TEST:".$_SESSION['bank_cid'].' '. $bank.' '.$amount ;
-      db_query("UPDATE {uc_order_line_items} SET title = '%s', amount = %f, weight = 0 WHERE order_id = %d AND type ='instalment'", $bank_temp, $amount_temp, $arg1->order_id);
+      db_query("UPDATE {uc_order_line_items} SET title = '%s', amount = %f, weight = 0 WHERE order_id = %d AND type = 'instalment'", $bank_temp, $amount_temp, $arg1->order_id);
       if (db_affected_rows() == 0) {
         db_query("INSERT INTO {uc_order_line_items} (order_id, type, title, amount, weight) VALUES (%d, 'instalment', '%s', %f, 0)", $arg1->order_id, $bank_temp, $amount_temp);
       }
@@ -609,25 +617,25 @@
       $result = db_query("SELECT * FROM {uc_turkish_banks} where valid_until > CURDATE() ORDER BY bankname");
       if (db_affected_rows() > 0) {
         $options  = array();
-        $select2='<select NAME="taksit" ID="taksit" class="combobox" onChange="instalment(this)">'
+        $select2 = '<select NAME="taksit" ID="taksit" class="combobox" onChange="instalment(this)">'
         .'<option selected>Taksitler...</option>'
         .'</select>';
-        $select1='<select NAME="banka" ID="banka" onChange="subselect(this.options.selectedIndex)" ="combobox">';
-        $select1.='<option selected>Bankalar...</option>';
-        $outer=1;
+        $select1 = '<select NAME="banka" ID="banka" onChange="subselect(this.options.selectedIndex)" ="combobox">';
+        $select1 .= '<option selected>Bankalar...</option>';
+        $outer = 1;
         while ($row = db_fetch_array($result)) {
           $select1 .= '<option value="'. $outer .'">'. $row['bankname'] .'</option>';
           $select2Opt .= 'group[0]['. $outer .']=new Option("option'. $outer .'");';
-          $inner=0;
+          $inner = 0;
           $select3OptLst .= 'group['. $outer .']['. $inner++ .']=new Option("Taksitler");';
 
           $cid_ins = $row['cid'];
           $result_ins = db_query("SELECT * FROM {uc_turkish_banks_instalments} where cid = %d and valid_until > CURDATE() ORDER BY instalment", $cid_ins);
           while ($row_ins = db_fetch_array($result_ins)) {
-            $new= $row_ins['instalment_ratio'] * $subtotal;
+            $new = $row_ins['instalment_ratio'] * $subtotal;
             $select_text = $row_ins['instalment'] ." taksit +". uc_currency_format($new);
-            $select_value= $row['cardname'] .' ile '. $row_ins['instalment'] .' taksit'.'|'. $new .'|'. $row['cid'] .'|'. $i;
-            $select3OptLst .= 'group['. $outer. ']['. $inner++ .']=new Option("'. $select_text .'","'. $select_value .'");';
+            $select_value = $row['cardname'] .' ile '. $row_ins['instalment'] .' taksit'.'|'. $new .'|'. $row['cid'] .'|'. $i;
+            $select3OptLst .= 'group['. $outer .']['. $inner++ .']=new Option("'. $select_text .'","'. $select_value .'");';
           }
           /*
            for ($i=2;$i<=18;$i++)
@@ -643,7 +651,7 @@
            */
           $outer++;
         }
-        $select1.='</select>';
+        $select1 .= '</select>';
 
         $details = '<div class="form-item"><b>'. t('Select instalment:') .'</b>'
         . $select1
@@ -884,7 +892,7 @@
     '#options' => array(
       'Auth' => t('Satis'),
       'PreAuth' => t('On Otorizasyon'),
-  ),
+    ),
      '#default_value' => variable_get('banks_transaction_mode', 'Auth'),
   );
   $form['banks_settings']['banks_transaction_mode'] = array(
@@ -894,7 +902,7 @@
     '#options' => array(
       'uretim' => t('Uretim'),
       'test' => t('Test'),
-  ),
+    ),
     '#default_value' => variable_get('banks_transaction_mode', 'test'),
   );
   return $form;
@@ -907,7 +915,7 @@
   }
 
   // XML request sablonu
-  $request= "DATA=<?xml version=\"1.0\" encoding=\"ISO-8859-9\"?>".
+  $request = "DATA=<?xml version=\"1.0\" encoding=\"ISO-8859-9\"?>".
   "<CC5Request>".
   "<Name>{NAME}</Name>".
   "<Password>{PASSWORD}</Password>".
@@ -955,7 +963,7 @@
   "<Extra></Extra>".
   "</CC5Request>";
 
-  $taksit=0;
+  $taksit = 0;
 
   $request = str_replace("{NAME}", variable_get('banks_settings_name', ''), $request);
   $request = str_replace("{PASSWORD}", variable_get('banks_settings_password', ''), $request);
@@ -1005,31 +1013,31 @@
   $err_msg = "";
   $host_msg = "";
 
-  $response_tag="Response";
+  $response_tag = "Response";
   $posf = strpos($result, "<". $response_tag .">");
   $posl = strpos($result, "</". $response_tag .">");
   $posf = $posf+ strlen($response_tag) +2 ;
   $response = substr($result, $posf, $posl - $posf);
 
-  $response_tag="OrderId";
+  $response_tag = "OrderId";
   $posf = strpos($result, "<". $response_tag .">");
   $posl = strpos($result, "</". $response_tag .">");
   $posf = $posf+ strlen($response_tag) +2;
   $order_id = substr($result, $posf, $posl - $posf);
 
-  $response_tag="AuthCode";
+  $response_tag = "AuthCode";
   $posf = strpos($result, "<". $response_tag .">");
   $posl = strpos($result, "</". $response_tag .">");
   $posf = $posf+ strlen($response_tag) +2;
   $auth_code = substr($result, $posf, $posl - $posf);
 
-  $response_tag="ProcReturnCode";
+  $response_tag = "ProcReturnCode";
   $posf = strpos($result, "<". $response_tag .">");
   $posl = strpos($result, "</". $response_tag .">");
   $posf = $posf+ strlen($response_tag) +2;
   $proc_return_code = substr($result, $posf, $posl - $posf);
 
-  $response_tag="ErrMsg";
+  $response_tag = "ErrMsg";
   $posf = strpos($result, "<". $response_tag .">");
   $posl = strpos($result, "</". $response_tag .">");
   $posf = $posf+ strlen($response_tag) +2;