Index: modules/system/system.module =================================================================== RCS file: /cvs/drupal/drupal/modules/system/system.module,v retrieving revision 1.517 diff -u -p -r1.517 system.module --- modules/system/system.module 12 Aug 2007 15:55:36 -0000 1.517 +++ modules/system/system.module 16 Aug 2007 19:38:45 -0000 @@ -2458,19 +2458,37 @@ function system_theme_settings(&$form_st } if ($key) { - // Template-specific settings - $function = $themes[$key]->prefix .'_settings'; + // Include the theme's settings.php file + $filename = './'. str_replace("/$key.info", '', $themes[$key]->filename) .'/settings.php'; + if (!file_exists($filename) and !empty($themes[$key]->info['base theme'])) { + // If the theme doesn't have a settings.php file, use the base theme's. + $base = $themes[$key]->info['base theme']; + $filename = './'. str_replace("/$base.info", '', $themes[$base]->filename) .'/settings.php'; + } + if (file_exists($filename)) { + require_once $filename; + } + + // Call engine-specific settings. + $function = $themes[$key]->prefix .'_engine_settings'; + if (function_exists($function)) { + $group = $function($settings); + if (!empty($group)) { + $form['engine_specific'] = array('#type' => 'fieldset', '#title' => t('Theme-engine-specific settings'), '#description' => t('These settings only exist for all the templates and styles based on the %engine theme engine.', array('%engine' => $themes[$key]->prefix))); + $form['engine_specific'] = array_merge($form['engine_specific'], $group); + } + } + // Call theme-specific settings. + $function = $key .'_settings'; + if (!function_exists($function)) { + $function = $themes[$key]->prefix .'_settings'; + } if (function_exists($function)) { - if ($themes[$key]->template) { - // file is a template or a style of a template - $form['specific'] = array('#type' => 'fieldset', '#title' => t('Engine-specific settings'), '#description' => t('These settings only exist for all the templates and styles based on the %engine theme engine.', array('%engine' => $themes[$key]->prefix))); - } - else { - // file is a theme or a style of a theme - $form['specific'] = array('#type' => 'fieldset', '#title' => t('Theme-specific settings'), '#description' => t('These settings only exist for the %theme theme and all the styles based on it.', array('%theme' => $themes[$key]->prefix))); + $group = $function($settings); + if (!empty($group)) { + $form['theme_specific'] = array('#type' => 'fieldset', '#title' => t('Theme-specific settings'), '#description' => t('These settings only exist for the %theme theme and all the styles based on it.', array('%theme' => $themes[$key]->info['name']))); + $form['theme_specific'] = array_merge($form['theme_specific'], $group); } - $group = $function(); - $form['specific'] = array_merge($form['specific'], (is_array($group) ? $group : array())); } } $form['#attributes'] = array('enctype' => 'multipart/form-data');