diff --git a/src/DiffEntityComparison.php b/src/DiffEntityComparison.php index c0212fd..8d50878 100644 --- a/src/DiffEntityComparison.php +++ b/src/DiffEntityComparison.php @@ -244,21 +244,14 @@ class DiffEntityComparison { * The revision log message. */ public function getRevisionDescription(ContentEntityInterface $revision, ContentEntityInterface $previous_revision = NULL) { - $auto_generated = FALSE; $summary_elements = []; $revision_summary = ''; // Check if the revision has a revision log message. if ($revision instanceof RevisionLogInterface) { $revision_summary = Xss::filter($revision->getRevisionLogMessage()); - if ($revision_summary == '') { - $auto_generated = TRUE; - } - } - else { - $auto_generated = TRUE; } // Auto generate the revision log. - if ($auto_generated) { + if ($revision_summary == '') { // If there is a previous revision, load values of both revisions, loop // over the current revision fields. if ($previous_revision) { diff --git a/src/DiffLayoutBase.php b/src/DiffLayoutBase.php index ac81b79..85c423a 100644 --- a/src/DiffLayoutBase.php +++ b/src/DiffLayoutBase.php @@ -107,7 +107,7 @@ abstract class DiffLayoutBase extends PluginBase implements DiffLayoutInterface, */ protected function buildRevisionLink(ContentEntityInterface $revision) { $entity_type_id = $revision->getEntityTypeId(); - if ($revision instanceof RevisionLogInterface || $revision instanceof NodeInterface) { + if ($revision instanceof RevisionLogInterface) { $revision_date = $this->date->format($revision->getRevisionCreationTime(), 'short'); $route_name = $entity_type_id != 'node' ? "entity.$entity_type_id.revisions_diff" : 'entity.node.revision'; $revision_link = Link::fromTextAndUrl($revision_date, Url::fromRoute($route_name, [ @@ -171,15 +171,8 @@ abstract class DiffLayoutBase extends PluginBase implements DiffLayoutInterface, */ protected function buildRevisionData(ContentEntityInterface $revision) { $entity_type_id = $revision->getEntityTypeId(); - if ($revision instanceof RevisionLogInterface || $revision instanceof NodeInterface) { - $revision_log = ''; - - if ($revision instanceof RevisionLogInterface) { - $revision_log = Xss::filter($revision->getRevisionLogMessage()); - } - elseif ($revision instanceof NodeInterface) { - $revision_log = $revision->revision_log->value; - } + if ($revision instanceof RevisionLogInterface) { + $revision_log = Xss::filter($revision->getRevisionLogMessage()); $user_id = $revision->getRevisionUserId(); $route_name = $entity_type_id != 'node' ? "entity.$entity_type_id.revisions_diff" : 'entity.node.revision';