diff --git a/core/includes/form.inc b/core/includes/form.inc
index 48fa93f..c0a3868 100644
--- a/core/includes/form.inc
+++ b/core/includes/form.inc
@@ -573,7 +573,7 @@ function template_preprocess_form_element_label(&$variables) {
* Note: if the batch 'title', 'init_message', 'progress_message', or
* 'error_message' could contain any user input, it is the responsibility of
* the code calling batch_set() to sanitize them first with a function like
- * \Drupal\Component\Utility\SafeMarkup::checkPlain() or
+ * \Drupal\Component\Utility\Html::escape() or
* \Drupal\Component\Utility\Xss::filter(). Furthermore, if the batch operation
* returns any user input in the 'results' or 'message' keys of $context, it
* must also sanitize them first.
@@ -600,8 +600,8 @@ function template_preprocess_form_element_label(&$variables) {
*
* $nodes = entity_load_multiple_by_properties('node', array('uid' => $uid, 'type' => $type));
* $node = reset($nodes);
- * $context['results'][] = $node->id() . ' : ' . SafeMarkup::checkPlain($node->label());
- * $context['message'] = SafeMarkup::checkPlain($node->label());
+ * $context['results'][] = $node->id() . ' : ' . Html::escape($node->label());
+ * $context['message'] = Html::escape($node->label());
* }
*
* // A more advanced example is a multi-step operation that loads all rows,
@@ -620,10 +620,10 @@ function template_preprocess_form_element_label(&$variables) {
* ->range(0, $limit)
* ->execute();
* foreach ($result as $row) {
- * $context['results'][] = $row->id . ' : ' . SafeMarkup::checkPlain($row->title);
+ * $context['results'][] = $row->id . ' : ' . Html::escape($row->title);
* $context['sandbox']['progress']++;
* $context['sandbox']['current_id'] = $row->id;
- * $context['message'] = SafeMarkup::checkPlain($row->title);
+ * $context['message'] = Html::escape($row->title);
* }
* if ($context['sandbox']['progress'] != $context['sandbox']['max']) {
* $context['finished'] = $context['sandbox']['progress'] / $context['sandbox']['max'];
diff --git a/core/modules/comment/config/optional/views.view.comments_recent.yml b/core/modules/comment/config/optional/views.view.comments_recent.yml
index 5b83bfb..1e1b718 100644
--- a/core/modules/comment/config/optional/views.view.comments_recent.yml
+++ b/core/modules/comment/config/optional/views.view.comments_recent.yml
@@ -42,7 +42,6 @@ display:
row_class: ''
default_row_class: true
type: ul
- wrapper_class: item-list
class: ''
row:
type: fields
diff --git a/core/modules/simpletest/css/simpletest.module.css b/core/modules/simpletest/css/simpletest.module.css
index 71f7eea..88c4564 100644
--- a/core/modules/simpletest/css/simpletest.module.css
+++ b/core/modules/simpletest/css/simpletest.module.css
@@ -35,7 +35,7 @@ table#simpletest-form-table tr.simpletest-group label {
display: inline;
}
-div.message > div.item-list {
+div.message > ul {
font-weight: normal;
}
diff --git a/core/modules/system/src/Tests/Theme/FunctionsTest.php b/core/modules/system/src/Tests/Theme/FunctionsTest.php
index 44f4507..bbf0ae8 100644
--- a/core/modules/system/src/Tests/Theme/FunctionsTest.php
+++ b/core/modules/system/src/Tests/Theme/FunctionsTest.php
@@ -46,21 +46,21 @@ function testItemList() {
// Verify that empty items produce the empty string.
$variables = array();
$variables['empty'] = 'No items found.';
- $expected = '
No items found.
';
+ $expected = 'No items found.';
$this->assertThemeOutput('item_list', $variables, $expected, 'Empty %callback generates empty string.');
// Verify that empty items produce the empty string with title.
$variables = array();
$variables['title'] = 'Some title';
$variables['empty'] = 'No items found.';
- $expected = 'Some title
No items found.';
+ $expected = 'Some title
No items found.';
$this->assertThemeOutput('item_list', $variables, $expected, 'Empty %callback generates empty string with title.');
// Verify that title set to 0 is output.
$variables = array();
$variables['title'] = 0;
$variables['empty'] = 'No items found.';
- $expected = '0
No items found.';
+ $expected = '0
No items found.';
$this->assertThemeOutput('item_list', $variables, $expected, '%callback with title set to 0 generates a title.');
// Verify that title set to a render array is output.
@@ -69,7 +69,7 @@ function testItemList() {
'#markup' => 'Render array',
);
$variables['empty'] = 'No items found.';
- $expected = 'Render array
No items found.';
+ $expected = 'Render array
No items found.';
$this->assertThemeOutput('item_list', $variables, $expected, '%callback with title set to a render array generates a title.');
// Verify that empty text is not displayed when there are list items.
@@ -77,7 +77,7 @@ function testItemList() {
$variables['title'] = 'Some title';
$variables['empty'] = 'No items found.';
$variables['items'] = array('Un', 'Deux', 'Trois');
- $expected = '';
+ $expected = 'Some title
';
$this->assertThemeOutput('item_list', $variables, $expected, '%callback does not print empty text when there are list items.');
// Verify nested item lists.
@@ -138,24 +138,23 @@ function testItemList() {
'f',
);
- $inner_b = '';
+ $inner_b = '';
$inner_b .= '- ba
';
$inner_b .= '- bb
';
- $inner_b .= '
';
+ $inner_b .= '';
- $inner_cb = '';
+ $inner_cb = '';
$inner_cb .= '- cba
';
$inner_cb .= '- cbb
';
- $inner_cb .= '
';
+ $inner_cb .= '';
- $inner_c = '';
+ $inner_c = '';
$inner_c .= '- ca
';
$inner_c .= '- cb' . $inner_cb . '
';
$inner_c .= '- cc
';
- $inner_c .= '
';
+ $inner_c .= '';
- $expected = '';
- $expected .= '
Some title
';
+ $expected = '
Some title
';
$expected .= '
';
$expected .= '- a
';
$expected .= '- b' . $inner_b . '
';
@@ -163,7 +162,7 @@ function testItemList() {
$expected .= '- d
';
$expected .= '';
$expected .= '- f
';
- $expected .= '
';
+ $expected .= '';
$this->assertThemeOutput('item_list', $variables, $expected);
}
diff --git a/core/modules/toolbar/css/toolbar.module.css b/core/modules/toolbar/css/toolbar.module.css
index 69eb7c2..d40a670 100644
--- a/core/modules/toolbar/css/toolbar.module.css
+++ b/core/modules/toolbar/css/toolbar.module.css
@@ -26,8 +26,7 @@
* Very specific overrides for Drupal system CSS.
*/
.toolbar li,
-.toolbar .item-list,
-.toolbar .item-list li,
+.toolbar ul,
.toolbar .menu-item,
.toolbar .menu-item--expanded {
list-style-type: none;
diff --git a/core/modules/user/config/optional/views.view.who_s_online.yml b/core/modules/user/config/optional/views.view.who_s_online.yml
index c7604dd..705d10a 100644
--- a/core/modules/user/config/optional/views.view.who_s_online.yml
+++ b/core/modules/user/config/optional/views.view.who_s_online.yml
@@ -55,7 +55,6 @@ display:
row_class: ''
default_row_class: true
type: ul
- wrapper_class: item-list
class: ''
row:
type: fields
diff --git a/core/modules/user/src/Tests/UserAdminListingTest.php b/core/modules/user/src/Tests/UserAdminListingTest.php
index 76fc674..0c07a6c 100644
--- a/core/modules/user/src/Tests/UserAdminListingTest.php
+++ b/core/modules/user/src/Tests/UserAdminListingTest.php
@@ -70,8 +70,8 @@ public function testUserListing() {
foreach ($result as $account) {
$name = (string) $account->td[0]->span;
$roles = array();
- if (isset($account->td[2]->div->ul)) {
- foreach ($account->td[2]->div->ul->li as $element) {
+ if (isset($account->td[2]->ul)) {
+ foreach ($account->td[2]->ul->li as $element) {
$roles[] = (string) $element;
}
}
diff --git a/core/modules/views/src/Plugin/views/field/FieldPluginBase.php b/core/modules/views/src/Plugin/views/field/FieldPluginBase.php
index cc2a151..9710db1 100644
--- a/core/modules/views/src/Plugin/views/field/FieldPluginBase.php
+++ b/core/modules/views/src/Plugin/views/field/FieldPluginBase.php
@@ -1565,7 +1565,7 @@ public function getRenderTokens($item) {
// Use strip tags as there should never be HTML in the path.
// However, we need to preserve special characters like " that
- // were removed by SafeMarkup::checkPlain().
+ // were removed by Html::esacpe().
$tokens["{{ raw_arguments.$arg }}"] = isset($this->view->args[$count]) ? strip_tags(Html::decodeEntities($this->view->args[$count])) : '';
$count++;
}
diff --git a/core/modules/views/src/Plugin/views/style/HtmlList.php b/core/modules/views/src/Plugin/views/style/HtmlList.php
index 59d606d..1e500b5 100644
--- a/core/modules/views/src/Plugin/views/style/HtmlList.php
+++ b/core/modules/views/src/Plugin/views/style/HtmlList.php
@@ -46,7 +46,6 @@ protected function defineOptions() {
$options['type'] = array('default' => 'ul');
$options['class'] = array('default' => '');
- $options['wrapper_class'] = array('default' => 'item-list');
return $options;
}
@@ -62,13 +61,6 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
'#options' => array('ul' => $this->t('Unordered list'), 'ol' => $this->t('Ordered list')),
'#default_value' => $this->options['type'],
);
- $form['wrapper_class'] = array(
- '#title' => $this->t('Wrapper class'),
- '#description' => $this->t('The class to provide on the wrapper, outside the list.'),
- '#type' => 'textfield',
- '#size' => '30',
- '#default_value' => $this->options['wrapper_class'],
- );
$form['class'] = array(
'#title' => $this->t('List class'),
'#description' => $this->t('The class to provide on the list element itself.'),
diff --git a/core/modules/views/src/Tests/Plugin/StyleHtmlListTest.php b/core/modules/views/src/Tests/Plugin/StyleHtmlListTest.php
index 1ff45b1..e6a37ee 100644
--- a/core/modules/views/src/Tests/Plugin/StyleHtmlListTest.php
+++ b/core/modules/views/src/Tests/Plugin/StyleHtmlListTest.php
@@ -33,24 +33,16 @@ function testDefaultRowClasses() {
$output = $view->preview();
$output = \Drupal::service('renderer')->renderRoot($output);
- // Check that an empty class attribute is not added if the wrapper class is
- // not set.
- $this->assertTrue(strpos($output, '') !== FALSE, 'Empty class is not added to DIV when class is not set');
-
// Check that an empty class attribute is not added if the list class is
// not set.
$this->assertTrue(strpos($output, '