cvs diff: Diffing modules/project_issue
Index: modules/project_issue/project_issue.module
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/project_issue/project_issue.module,v
retrieving revision 1.4.2.3.2.12
diff -u -p -r1.4.2.3.2.12 project_issue.module
--- modules/project_issue/project_issue.module	20 Dec 2006 01:09:27 -0000	1.4.2.3.2.12
+++ modules/project_issue/project_issue.module	21 Dec 2006 19:26:08 -0000
@@ -281,9 +281,6 @@ function project_issue_project_edit_issu
   if (is_array($node->components)) {
     $node->components = implode("\n", $node->components);
   }
-  elseif (empty($node->components)) {
-    $node->components = "Code\nDocumentation\nMiscellaneous\nUser interface";
-  }
 
   /* Issue properties */
   $form['issue'] = array(
@@ -614,12 +611,14 @@ function project_issue_project_load(&$no
 }
 
 function project_issue_project_insert($node) {
-  project_issue_convert_components($node);
-  $node->components = serialize($node->components);
-  $node->mail_copy_filter = serialize($node->mail_copy_filter);
-  $node->mail_copy_filter_state = serialize($node->mail_copy_filter_state);
-
-  db_query("INSERT INTO {project_issue_projects} (nid, issues, components, mail_digest, mail_reminder, mail_copy, mail_copy_filter, mail_copy_filter_state, help) VALUES (%d, %d, '%s', '%s', %d, '%s', '%s', '%s', '%s')", $node->nid, $node->issues, $node->components, $node->mail_digest, $node->reminder, $node->mail_copy, $node->mail_copy_filter, $node->mail_copy_filter_state, $node->help);
+  // Setup reasonable defaults: enable issue tracker and standard
+  // components. If maintainers want to change these, (or any of the
+  // other issue-related project settings, like the email notifications)
+  // they'd use the "issues" subtab of the project edit tab (since none
+  // of these fields are present on the initial project add form).
+  $node->issues = 1;
+  $node->components = serialize(array('Code', 'Documentation', 'Miscellaneous', 'User interface'));
+  db_query("INSERT INTO {project_issue_projects} (nid, issues, components) VALUES (%d, %d, '%s')", $node->nid, $node->issues, $node->components);
 }
 
 function project_issue_project_delete($node) {
@@ -630,16 +629,3 @@ function project_issue_project_delete($n
   db_query('DELETE FROM {project_issues} WHERE pid = %d', $node->nid);
   db_query('DELETE FROM {project_subscriptions} WHERE nid = %d', $node->nid);
 }
-
-function project_issue_convert_components(&$node) {
-  // Transform components into array.
-  if (!is_array($node->components)) {
-    if ($node->components) {
-      $node->components = explode("\n", str_replace("\r", '', $node->components));
-    }
-    else {
-      $node->components = array();
-    }
-  }
-}
-