diff --git modules/openid/openid.module modules/openid/openid.module index d609946..7673de8 100644 --- modules/openid/openid.module +++ modules/openid/openid.module @@ -341,17 +341,14 @@ function openid_complete($response = array()) { $response['openid.claimed_id'] = $service['claimed_id']; } elseif ($service['version'] == 2) { - // Returned claimed id could have unique fragment hash to allow - // identifier recycling so we need to preserve it in response. - $response_claimed_id = openid_normalize($response['openid.claimed_id']); - + $response['openid.claimed_id'] = openid_normalize($response['openid.claimed_id']); // OpenID Authentication, section 11.2: // If the returned Claimed Identifier is different from the one sent // to the OpenID Provider, we need to do discovery on the returned // identififer to make sure that the provider is authorized to // respond on behalf of this. - if ($response_claimed_id != $claimed_id) { - $services = openid_discovery($response_claimed_id); + if ($response['openid.claimed_id'] != $claimed_id) { + $services = openid_discovery($response['openid.claimed_id']); $uris = array(); foreach ($services as $discovered_service) { if (in_array('http://specs.openid.net/auth/2.0/server', $discovered_service['types']) || in_array('http://specs.openid.net/auth/2.0/signon', $discovered_service['types'])) { diff --git modules/openid/openid.test modules/openid/openid.test index 410dd93..202a835 100644 --- modules/openid/openid.test +++ modules/openid/openid.test @@ -89,12 +89,12 @@ class OpenIDFunctionalTestCase extends OpenIDWebTestCase { // Identifier is the URL of an XRDS document containing an OP Identifier // Element. The Relying Party sends the special value // "http://specs.openid.net/auth/2.0/identifier_select" as Claimed - // Identifier. The OpenID Provider responds with the actual identifier - // including fragment. - $identity = url('openid-test/yadis/xrds/dummy-user', array('absolute' => TRUE, 'fragment' => $this->randomName())); - // Tell openid_test.module to respond with this identifier. We test if - // openid_complete() process it right. - variable_set('openid_test_response', array('openid.claimed_id' => $identity)); + // Identifier. The OpenID Provider responds with the actual identifier. + $identity = url('openid-test/yadis/xrds/dummy-user', array('absolute' => TRUE)); + // Tell openid_test.module to respond with this identifier. The URL scheme + // is stripped in order to test that the returned identifier is normalized in + // openid_complete(). + variable_set('openid_test_response', array('openid.claimed_id' => preg_replace('@^https?://@', '', $identity))); $this->addIdentity(url('openid-test/yadis/xrds/server', array('absolute' => TRUE)), 2, 'http://specs.openid.net/auth/2.0/identifier_select', $identity); variable_set('openid_test_response', array());