? modules/nodeload.patch
Index: modules/archive.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/archive.module,v
retrieving revision 1.80
diff -u -F^f -r1.80 archive.module
--- modules/archive.module	24 Apr 2005 16:34:32 -0000	1.80
+++ modules/archive.module	17 Jul 2005 18:17:07 -0000
@@ -246,7 +246,7 @@ function archive_page($year = 0, $month 
     $result = db_query_range($sql, $date, $date_end, 0, 20);
 
     while ($nid = db_fetch_object($result)) {
-      $output .= node_view(node_load(array('nid' => $nid->nid)), 1);
+      $output .= node_view(node_load($nid->nid), 1);
     }
   }
   return $output;
Index: modules/blog.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/blog.module,v
retrieving revision 1.218
diff -u -F^f -r1.218 blog.module
--- modules/blog.module	2 Jul 2005 11:58:16 -0000	1.218
+++ modules/blog.module	17 Jul 2005 18:17:07 -0000
@@ -143,7 +143,7 @@ function blog_page_user($uid) {
 
     $result = pager_query(db_rewrite_sql("SELECT n.nid, n.sticky, n.created FROM {node} n WHERE type = 'blog' AND n.uid = %d AND n.status = 1 ORDER BY n.sticky DESC, n.created DESC"), variable_get('default_nodes_main', 10), 0, NULL, $account->uid);
     while ($node = db_fetch_object($result)) {
-      $output .= node_view(node_load(array('nid' => $node->nid)), 1);
+      $output .= node_view(node_load($node->nid), 1);
     }
     $output .= theme('pager', NULL, variable_get('default_nodes_main', 10));
     $output .= theme('xml_icon', url("blog/$account->uid/feed"));
@@ -170,7 +170,7 @@ function blog_page_last() {
   $result = pager_query(db_rewrite_sql("SELECT n.nid, n.created FROM {node} n WHERE n.type = 'blog' AND n.status = 1 ORDER BY n.created DESC"), variable_get('default_nodes_main', 10));
 
   while ($node = db_fetch_object($result)) {
-    $output .= node_view(node_load(array('nid' => $node->nid)), 1);
+    $output .= node_view(node_load($node->nid), 1);
   }
   $output .= theme('pager', NULL, variable_get('default_nodes_main', 10));
   $output .= theme('xml_icon', url('blog/feed'));
@@ -195,7 +195,7 @@ function blog_form(&$node) {
     ** database and quote it in the blog:
     */
 
-    if ($nid && $blog = node_load(array('nid' => $nid))) {
+    if ($nid && $blog = node_load($nid)) {
       $node->body = '<em>'. $blog->body .'</em> ['. l($blog->name, "node/$nid") .']';
     }
 
Index: modules/blogapi.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/blogapi.module,v
retrieving revision 1.45
diff -u -F^f -r1.45 blogapi.module
--- modules/blogapi.module	13 Jul 2005 18:46:15 -0000	1.45
+++ modules/blogapi.module	17 Jul 2005 18:17:07 -0000
@@ -233,7 +233,7 @@ function blogapi_blogger_edit_post($appk
     return blogapi_error($user);
   }
 
-  $node = node_load(array('nid' => $postid));
+  $node = node_load('nid' => $postid);
   if (!$node) {
     return blogapi_error(message_na());
   }
@@ -330,7 +330,7 @@ function blogapi_metaweblog_get_post($po
     return blogapi_error($user);
   }
 
-  $node = node_load(array('nid' => $postid));
+  $node = node_load('nid' => $postid);
 
   return _blogapi_get_post($node, true);
 }
@@ -469,7 +469,7 @@ function blogap_mti_publish_post($postid
   if (!$user->uid) {
     return blogapi_error($user);
   }
-  $node = node_load(array('nid' => $postid));
+  $node = node_load('nid' => $postid);
   if (!$node) {
     return blogapi_error(t('Invalid post.'));
   }
Index: modules/comment.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/comment.module,v
retrieving revision 1.357
diff -u -F^f -r1.357 comment.module
--- modules/comment.module	5 Jul 2005 19:31:36 -0000	1.357
+++ modules/comment.module	17 Jul 2005 18:17:08 -0000
@@ -136,7 +136,7 @@ function comment_menu($may_cache) {
   }
   else {
     if (arg(0) == 'comment' && arg(1) == 'reply' && is_numeric(arg(2))) {
-      $node = node_load(array('nid' => arg(2)));
+      $node = node_load(arg(2));
       if ($node->nid) {
         $items[] = array('path' => 'comment/reply', 'title' => t('reply to comment'),
           'callback' => 'comment_reply', 'access' => node_access('view', $node), 'type' => MENU_CALLBACK);
@@ -274,6 +274,7 @@ function comment_nodeapi(&$node, $op, $a
     case 'delete':
       db_query('DELETE FROM {comments} WHERE nid = %d', $node->nid);
       db_query('DELETE FROM {node_comment_statistics} WHERE nid = %d', $node->nid);
+      cache_clear_all('comment:'. $node->nid);
       break;
 
     case 'update index':
@@ -376,7 +377,7 @@ function comment_edit($cid) {
 
 function comment_reply($nid, $pid = NULL) {
   // set the breadcrumb trail
-  $node = node_load(array('nid' => $nid));
+  $node = node_load($nid);
   menu_set_location(array(array('path' => "node/$nid", 'title' => $node->title), array('path' => "comment/reply/$nid")));
 
   $output = '';
@@ -514,7 +515,7 @@ function comment_preview($edit) {
     $output .= theme('comment_view', $comment);
   }
   else {
-    $output .= node_view(node_load(array('nid' => $edit['nid'])));
+    $output .= node_view(node_load($edit['nid']));
     $edit['pid'] = 0;
   }
 
@@ -544,6 +545,9 @@ function comment_post($edit) {
         // Allow modules to respond to the updating of a comment.
         module_invoke_all('comment', 'update', $edit);
 
+        // invalidate cache
+        cache_clear_all('comment:'. $edit['nid']);
+
         // Add an entry to the watchdog log.
         watchdog('content', t('Comment: updated %subject.', array('%subject' => theme('placeholder', $edit['subject']))), WATCHDOG_NOTICE, l(t('view'), 'node/'. $edit['nid'], NULL, NULL, 'comment-'. $edit['cid']));
       }
@@ -647,6 +651,9 @@ function comment_post($edit) {
         // Tell the other modules a new comment has been submitted.
         module_invoke_all('comment', 'insert', $edit);
 
+        // invalidate cache
+        cache_clear_all('comment:'. $edit['nid']);
+
         // Add an entry to the watchdog log.
         watchdog('content', t('Comment: added %subject.', array('%subject' => theme('placeholder', $edit['subject']))), WATCHDOG_NOTICE, l(t('view'), 'node/'. $edit['nid'], NULL, NULL, 'comment-'. $edit['cid']));
       }
@@ -831,6 +838,12 @@ function comment_render($node, $cid = 0)
       ** substring only.
       */
 
+      $cache_id = 'comment:'. $node->nid;
+      if (!$user->uid && ($cache = cache_get($cache_id))) {
+        return $cache;
+      }
+      $cacheable = TRUE;
+
       if ($order == 1) {
         if ($mode == 1 || $mode == 2) {
           $query .= ' ORDER BY c.timestamp DESC';
@@ -869,6 +882,7 @@ function comment_render($node, $cid = 0)
 
       while ($comment = db_fetch_object($result)) {
         $comment = drupal_unpack($comment);
+        $cacheable = $cacheable && filter_format_allowcache($comment->format);
         $comment->name = $comment->uid ? $comment->registered_name : $comment->name;
         $comment->depth = count(explode('.', $comment->thread)) - 1;
 
@@ -904,6 +918,9 @@ function comment_render($node, $cid = 0)
         $output .= form_hidden('nid', $nid);
         $output .= '</div></form>';
       }
+      if (!$user->uid && $cacheable) {
+        cache_set($cache_id, $output, CACHE_PERMANENT);
+      }
     }
 
     // If enabled, show new comment form.
@@ -1005,6 +1022,9 @@ function comment_save($id, $edit) {
 
   // Allow modules to respond to the updating of a comment.
   module_invoke_all('comment', 'update', $edit);
+
+  // invalidate cache
+  cache_clear_all('comment:'. $edit['nid']);
 }
 
 /**
@@ -1260,7 +1280,7 @@ function comment_moderate() {
       $votes[$mod->mid] = $mod->value;
     }
 
-    $node = node_load(array('nid' => db_result(db_query('SELECT nid FROM {comments} WHERE cid = %d', key($moderation)))));
+    $node = node_load(db_result(db_query('SELECT nid FROM {comments} WHERE cid = %d', key($moderation))));
 
     if (user_access('administer comments') || comment_user_can_moderate($node)) {
       foreach ($moderation as $cid => $vote) {
@@ -1283,6 +1303,9 @@ function comment_moderate() {
             db_query("UPDATE {comments} SET score = '$new_score', users = '%s' WHERE cid = %d", serialize($users), $cid);
 
             module_invoke_all('comment', 'moderate', $cid, $vote);
+
+            // invalidate cache
+            cache_clear_all('comment:'. $comment->nid);
           }
         }
       }
@@ -1616,6 +1639,7 @@ function _comment_delete_thread($comment
   watchdog('content', t('Comment: deleted %subject.', array('%subject' => theme('placeholder', $comment->subject))));
 
   module_invoke_all('comment', 'delete', $comment);
+  cache_clear_all('comment:'. $comment->nid);
 
   // Delete the comment's replies:
   $result = db_query('SELECT c.*, u.name AS registered_name, u.uid FROM {comments} c INNER JOIN {users} u ON u.uid = c.uid WHERE pid = %d', $comment->cid);
@@ -1668,7 +1692,7 @@ function _comment_update_node_statistics
 
   // comments exist
   if ($count > 0) {
-    $node = node_load(array('nid' => $nid));
+    $node = node_load($nid);
     $last_reply = db_fetch_object(db_query_range('SELECT cid, name, timestamp, uid FROM {comments} WHERE nid = %d AND status = %d ORDER BY cid DESC', $nid, COMMENT_PUBLISHED, 0, 1));
     db_query("UPDATE {node_comment_statistics} SET comment_count = %d, last_comment_timestamp = %d, last_comment_name = '%s', last_comment_uid = %d WHERE nid = %d", $count, $last_reply->timestamp, $last_reply->uid ? NULL : $last_reply->name, $last_reply->uid, $nid);
   }
Index: modules/node.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/node.module,v
retrieving revision 1.503
diff -u -F^f -r1.503 node.module
--- modules/node.module	7 Jul 2005 13:30:50 -0000	1.503
+++ modules/node.module	17 Jul 2005 18:17:09 -0000
@@ -329,9 +329,8 @@ function node_invoke_nodeapi(&$node, $op
 /**
  * Load a node object from the database.
  *
- * @param $conditions
- *   An array of conditions to match against in the database query. Most calls
- *   will simply use array('nid' => 52).
+ * @param $param
+ *   Either the nid of the node or an array of conditions to match against in the database query
  * @param $revision
  *   Which numbered revision to load. Defaults to the current version.
  * @param $reset
@@ -340,26 +339,30 @@ function node_invoke_nodeapi(&$node, $op
  * @return
  *   A fully-populated node object.
  */
-function node_load($conditions, $revision = NULL, $reset = NULL) {
+function node_load($param = array(), $revision = NULL, $reset = NULL) {
   static $nodes = array();
 
   if ($reset) {
     $nodes = array();
   }
 
-  $cachable = (count($conditions) == 1 && isset($conditions['nid']) && $revision == NULL);
-
-  if ($cachable && isset($nodes[$conditions['nid']])) {
-    return $nodes[$conditions['nid']];
+  if (is_numeric($param)) {
+    $cachable = $revision == NULL;
+    if ($cachable && $nodes[$param]) {
+      return $nodes[$param];
+    }
+    $cond = 'n.nid = '. $param;
   }
-
-  // Turn the conditions into a query.
-  foreach ($conditions as $key => $value) {
-    $cond[] = 'n.'. db_escape_string($key) ." = '". db_escape_string($value) ."'";
+  else {
+    // Turn the conditions into a query.
+    foreach ($conditions as $key => $value) {
+      $cond[] = 'n.'. db_escape_string($key) ." = '". db_escape_string($value) ."'";
+    }
+    $cond = implode(' AND ', $cond);
   }
 
   // Retrieve the node.
-  $node = db_fetch_object(db_query(db_rewrite_sql('SELECT n.*, u.uid, u.name, u.picture, u.data FROM {node} n INNER JOIN {users} u ON u.uid = n.uid WHERE '. implode(' AND ', $cond))));
+  $node = db_fetch_object(db_query(db_rewrite_sql('SELECT n.*, u.uid, u.name, u.picture, u.data FROM {node} n INNER JOIN {users} u ON u.uid = n.uid WHERE '. $cond)));
   $node = drupal_unpack($node);
 
   // Unserialize the revisions and user data fields.
@@ -387,7 +390,7 @@ function node_load($conditions, $revisio
   }
 
   if ($cachable) {
-    $nodes[$conditions['nid']] = $node;
+    $nodes[$param] = $node;
   }
 
   return $node;
@@ -566,7 +569,7 @@ function node_search($op = 'search', $ke
       $find = do_search($keys, 'node', 'INNER JOIN {node} n ON n.nid = i.sid '. $join .' INNER JOIN {users} u ON n.uid = u.uid', 'n.status = 1'. (empty($where) ? '' : ' AND '. $where));
       $results = array();
       foreach ($find as $item) {
-        $node = node_load(array('nid' => $item));
+        $node = node_load($item);
         $extra = node_invoke_nodeapi($node, 'search result');
         $results[] = array('link' => url('node/'. $item),
                            'type' => node_invoke($node, 'node_name'),
@@ -664,7 +667,7 @@ function node_menu($may_cache) {
   }
   else {
     if (arg(0) == 'node' && is_numeric(arg(1))) {
-      $node = node_load(array('nid' => arg(1)));
+      $node = node_load(arg(1));
       if ($node->nid) {
         $items[] = array('path' => 'node/'. arg(1), 'title' => t('view'),
           'callback' => 'node_page',
@@ -965,7 +968,7 @@ function node_types_configure($type = NU
  */
 function node_revision_overview($nid) {
   if (user_access('administer nodes')) {
-    $node = node_load(array('nid' => $nid));
+    $node = node_load($nid);
 
     drupal_set_title(check_plain($node->title));
 
@@ -999,7 +1002,7 @@ function node_revision_create($node) {
   // "Revision" is the name of the field used to indicate that we have to
   // create a new revision of a node.
   if ($node->nid && $node->revision) {
-    $prev = node_load(array('nid' => $node->nid));
+    $prev = node_load($node->nid);
     $node->revisions = $prev->revisions;
     unset($prev->revisions);
     $node->revisions[] = array('uid' => $user->uid, 'timestamp' => time(), 'node' => $prev, 'history' => $node->history);
@@ -1015,7 +1018,7 @@ function node_revision_rollback($nid, $r
   global $user;
 
   if (user_access('administer nodes')) {
-    $node = node_load(array('nid' => $nid));
+    $node = node_load($nid);
 
     // Extract the specified revision:
     $rev = $node->revisions[$revision]['node'];
@@ -1046,7 +1049,7 @@ function node_revision_rollback($nid, $r
  */
 function node_revision_delete($nid, $revision) {
   if (user_access('administer nodes')) {
-    $node = node_load(array('nid' => $nid));
+    $node = node_load($nid);
 
     unset($node->revisions[$revision]);
 
@@ -1126,7 +1129,7 @@ function node_feed($nodes = 0, $channel 
 
   while ($node = db_fetch_object($nodes)) {
     // Load the specified node:
-    $item = node_load(array('nid' => $node->nid));
+    $item = node_load($node->nid);
     $link = url("node/$node->nid", NULL, NULL, 1);
 
     // Filter and prepare node teaser
@@ -1427,7 +1430,7 @@ function node_add($type) {
 function node_edit($id) {
   global $user;
 
-  $node = node_load(array('nid' => $id));
+  $node = node_load($id);
 
   drupal_set_title(check_plain($node->title));
 
@@ -1559,7 +1562,7 @@ function node_submit(&$node) {
  * Ask for confirmation, and delete the node.
  */
 function node_delete($edit) {
-  $node = node_load(array('nid' => $edit['nid']));
+  $node = node_load($edit['nid']);
 
   if (node_access('delete', $node)) {
 
@@ -1610,7 +1613,7 @@ function node_page_default() {
 
     $output = '';
     while ($node = db_fetch_object($result)) {
-      $output .= node_view(node_load(array('nid' => $node->nid)), 1);
+      $output .= node_view(node_load($node->nid), 1);
     }
     $output .= theme('pager', NULL, variable_get('default_nodes_main', 10));
   }
@@ -1660,7 +1663,7 @@ function node_page() {
       break;
     case 'edit':
       if (is_numeric(arg(1))) {
-        $node = node_load(array('nid' => arg(1)));
+        $node = node_load(arg(1));
         if ($node->nid) {
           drupal_set_title($node->title);
           return node_edit(arg(1));
@@ -1672,7 +1675,7 @@ function node_page() {
       break;
     case 'view':
       if (is_numeric(arg(1))) {
-        $node = node_load(array('nid' => arg(1)), $_GET['revision']);
+        $node = node_load(arg(1), $_GET['revision']);
         if ($node->nid) {
           drupal_set_title(check_plain($node->title));
           return node_show($node, arg(2));
@@ -1733,7 +1736,7 @@ function node_update_index() {
 
   while ($node = db_fetch_object($result)) {
     $last_comment = $node->last_comment_timestamp;
-    $node = node_load(array('nid' => $node->nid));
+    $node = node_load($node->nid);
 
     // We update this variable per node in case cron times out, or if the node
     // cannot be indexed (PHP nodes which call drupal_goto, for example).
@@ -1981,4 +1984,4 @@ function node_db_rewrite_sql($query, $pr
  * @} End of "defgroup node_access".
  */
 
-?>
+?>
\ No newline at end of file
Index: modules/poll.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/poll.module,v
retrieving revision 1.165
diff -u -F^f -r1.165 poll.module
--- modules/poll.module	27 Jun 2005 18:33:32 -0000	1.165
+++ modules/poll.module	17 Jul 2005 18:17:10 -0000
@@ -203,7 +203,7 @@ function poll_menu($may_cache) {
   }
   else {
     if (arg(0) == 'node' && is_numeric(arg(1))) {
-      $node = node_load(array('nid' => arg(1)));
+      $node = node_load(arg(1));
 
       if ($node->type == 'poll' && $node->allowvotes) {
         $items[] = array('path' => 'node/'. arg(1) .'/results',
@@ -360,7 +360,7 @@ function poll_view_results(&$node, $teas
  * Callback for the 'results' tab for polls you can vote on
  */
 function poll_results() {
-  if ($node = node_load(array('nid' => arg(1)))) {
+  if ($node = node_load(arg(1))) {
     drupal_set_title(check_plain($node->title));
     return node_show($node, 0);
   }
@@ -374,7 +374,7 @@ function poll_results() {
  */
 function poll_vote(&$node) {
   $nid = arg(2);
-  if ($node = node_load(array('nid' => $nid))) {
+  if ($node = node_load($nid)) {
     $edit = $_POST['edit'];
     $choice = $edit['choice'];
     $vote = $_POST['vote'];
Index: modules/statistics.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/statistics.module,v
retrieving revision 1.197
diff -u -F^f -r1.197 statistics.module
--- modules/statistics.module	2 Jul 2005 11:58:15 -0000	1.197
+++ modules/statistics.module	17 Jul 2005 18:17:10 -0000
@@ -160,7 +160,7 @@ function statistics_access_log($aid) {
 }
 
 function statistics_node_tracker() {
-  if ($node = node_load(array('nid' => arg(1)))) {
+  if ($node = node_load(arg(1))) {
 
     $header = array(
         array('data' => t('Time'), 'field' => 'a.timestamp', 'sort' => 'desc'),
Index: modules/taxonomy.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/taxonomy.module,v
retrieving revision 1.209
diff -u -F^f -r1.209 taxonomy.module
--- modules/taxonomy.module	27 Jun 2005 18:33:33 -0000	1.209
+++ modules/taxonomy.module	17 Jul 2005 18:17:11 -0000
@@ -1005,7 +1005,7 @@ function taxonomy_select_nodes($tids = a
 function taxonomy_render_nodes($result) {
   if (db_num_rows($result) > 0) {
     while ($node = db_fetch_object($result)) {
-      $output .= node_view(node_load(array('nid' => $node->nid)), 1);
+      $output .= node_view(node_load($node->nid), 1);
     }
     $output .= theme('pager', NULL, variable_get('default_nodes_main', 10), 0);
   }