+++++++++++++++++++++++++++++ phpbb2drupal/phpbb2drupal.pages.inc Summary minor: 4, normal: 2, critical: 0, ignored: 0 Details +-1: [normal] @file block missing +2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file. +109: [minor] There should be no trailing spaces +233: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existence of any rows, rather than actually counting the number of rows. +233: [normal] missing space after comma +233: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existance of any rows, rather than the actualy numer of rows. +++++++++++++++++++++++++++++ phpbb2drupal/phpbb_redirect.module Summary minor: 6, normal: 2, critical: 1, ignored: 0 Details +-1: [normal] @file block missing +2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file. +6: [minor] put a space between the asterisk and the comment text +10: [minor] Comment should be read "Implements hook_foo()." +10: [critical] Module .info files must now specify all loadable code files explicitly. +12: [minor] put a space between the asterisk and the comment text +30: [minor] Comment should be read "Implements hook_foo()." +32: [minor] put a space between the asterisk and the comment text +62: [normal] Use "elseif" in place of "else if" +++++++++++++++++++++++++++++ phpbb2drupal/phpbb2privatemsg.module Summary minor: 5, normal: 1, critical: 1, ignored: 0 Details +-1: [normal] @file block missing +2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file. +5: [minor] Comment should be read "Implements hook_foo()." +12: [critical] Module .info files must now specify all loadable code files explicitly. +124: [minor] in most cases, replace the string function with the drupal_ equivalent string functions +130: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existence of any rows, rather than actually counting the number of rows. +130: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existance of any rows, rather than the actualy numer of rows. +++++++++++++++++++++++++++++ phpbb2drupal/phpbb2drupal.install Summary minor: 1, normal: 0, critical: 0, ignored: 0 Details +2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file. +++++++++++++++++++++++++++++ phpbb2drupal/phpbb2privatemsg.install Summary minor: 1, normal: 0, critical: 1, ignored: 0 Details +2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file. +11: [critical] Schema descriptions are no longer translated in hook_schema +++++++++++++++++++++++++++++ phpbb2drupal/phpbb2drupal.module Summary minor: 46, normal: 8, critical: 2, ignored: 0 Details +-1: [normal] @file block missing +2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file. +18: [critical] Module .info files must now specify all loadable code files explicitly. +156: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existence of any rows, rather than actually counting the number of rows. +156: [critical] table names should be enclosed in {curly_brackets} +156: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existance of any rows, rather than the actualy numer of rows. +210: [normal] Use an indent of 2 spaces, with no tabs +216: [minor] Note that it is important that modules try not to use $_SESSION for anonymous users. +236: [minor] Note that it is important that modules try not to use $_SESSION for anonymous users. +239: [minor] Note that it is important that modules try not to use $_SESSION for anonymous users. +246: [minor] Note that it is important that modules try not to use $_SESSION for anonymous users. +249: [minor] Note that it is important that modules try not to use $_SESSION for anonymous users. +256: [minor] Note that it is important that modules try not to use $_SESSION for anonymous users. +259: [minor] Note that it is important that modules try not to use $_SESSION for anonymous users. +266: [minor] Note that it is important that modules try not to use $_SESSION for anonymous users. +269: [minor] Note that it is important that modules try not to use $_SESSION for anonymous users. +276: [minor] Note that it is important that modules try not to use $_SESSION for anonymous users. +279: [normal] The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable. +280: [normal] The $text argument to l() should be enclosed within t() so that it is translatable. +280: [normal] The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable. +281: [minor] Note that it is important that modules try not to use $_SESSION for anonymous users. +285: [minor] Note that it is important that modules try not to use $_SESSION for anonymous users. +358: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existence of any rows, rather than actually counting the number of rows. +358: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existance of any rows, rather than the actualy numer of rows. +379: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existence of any rows, rather than actually counting the number of rows. +379: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existance of any rows, rather than the actualy numer of rows. +408: [minor] in most cases, replace the string function with the drupal_ equivalent string functions +431: [minor] in most cases, replace the string function with the drupal_ equivalent string functions +433: [minor] in most cases, replace the string function with the drupal_ equivalent string functions +443: [minor] in most cases, replace the string function with the drupal_ equivalent string functions +482: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existence of any rows, rather than actually counting the number of rows. +482: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existance of any rows, rather than the actualy numer of rows. +548: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existence of any rows, rather than actually counting the number of rows. +548: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existance of any rows, rather than the actualy numer of rows. +571: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existence of any rows, rather than actually counting the number of rows. +571: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existance of any rows, rather than the actualy numer of rows. +581: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existence of any rows, rather than actually counting the number of rows. +581: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existance of any rows, rather than the actualy numer of rows. +617: [normal] Use "elseif" in place of "else if" +625: [normal] Use "elseif" in place of "else if" +711: [minor] in most cases, replace the string function with the drupal_ equivalent string functions +712: [minor] in most cases, replace the string function with the drupal_ equivalent string functions +713: [minor] in most cases, replace the string function with the drupal_ equivalent string functions +727: [minor] in most cases, replace the string function with the drupal_ equivalent string functions +765: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existence of any rows, rather than actually counting the number of rows. +765: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existance of any rows, rather than the actualy numer of rows. +817: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existence of any rows, rather than actually counting the number of rows. +817: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existance of any rows, rather than the actualy numer of rows. +831: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existence of any rows, rather than actually counting the number of rows. +831: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existance of any rows, rather than the actualy numer of rows. +852: [normal] Use "elseif" in place of "else if" +907: [minor] in most cases, replace the string function with the drupal_ equivalent string functions +908: [minor] in most cases, replace the string function with the drupal_ equivalent string functions +909: [minor] in most cases, replace the string function with the drupal_ equivalent string functions +923: [minor] in most cases, replace the string function with the drupal_ equivalent string functions +1092: [minor] in most cases, replace the string function with the drupal_ equivalent string functions