=== modified file 'includes/form.inc' --- includes/form.inc 2006-11-16 09:06:59 +0000 +++ includes/form.inc 2006-11-25 06:33:54 +0000 @@ -17,25 +17,8 @@ * $output = drupal_get_form('user_register'); * * Forms can also be built and submitted programmatically without any user input - * using the drupal_execute() function. Pass in the id of the form, the values to - * submit to the form, and any parameters needed by the form's builder function. - * For example: + * using the drupal_execute() function. * - * // register a new user - * $values['name'] = 'robo-user'; - * $values['mail'] = 'robouser@example.com'; - * $values['pass'] = 'password'; - * drupal_execute('user_register', $values); - * - * // Create a new node - * $node = array('type' => 'story'); - * $values['title'] = 'My node'; - * $values['body'] = 'This is the body text!'; - * $values['name'] = 'robo-user'; - * drupal_execute('story_node_form', $values, $node); - * - * Calling form_get_errors() after execution will return an array of any - * validation errors encountered. * * For information on the format of the structured arrays used to define forms, * and more detailed explanations of the Form API workflow, see the reference at @@ -133,6 +116,21 @@ function drupal_get_form($form_id) { * Any additional arguments needed by the form building function. * @return * Any form validation errors encountered. + * + * For example: + * + * // register a new user + * $values['name'] = 'robo-user'; + * $values['mail'] = 'robouser@example.com'; + * $values['pass'] = 'password'; + * drupal_execute('user_register', $values); + * + * // Create a new node + * $node = array('type' => 'story'); + * $values['title'] = 'My node'; + * $values['body'] = 'This is the body text!'; + * $values['name'] = 'robo-user'; + * drupal_execute('story_node_form', $values, $node); */ function drupal_execute($form_id, $form_values) { $args = func_get_args(); === modified file 'modules/comment/comment.module' --- modules/comment/comment.module 2006-11-24 10:18:22 +0000 +++ modules/comment/comment.module 2006-11-25 06:32:02 +0000 @@ -606,8 +606,8 @@ function comment_save($edit) { $users = serialize(array(0 => $score)); - // Here we are building the thread field. See the comment - // in comment_render(). + // Here we are building the thread field. See the doxygen + // for comment_render(). if ($edit['pid'] == 0) { // This is a comment with no parent comment (depth 0): we start // by retrieving the maximum thread level. @@ -739,6 +739,68 @@ function comment_links($comment, $return return $links; } +/** + * Renders comment(s). + * + * @param $node + * The node which comment(s) needs rendering. + * @param $cid + * Optional, if given, only one comment is rendered. + * + * To display threaded comments in the correct order we keep a 'thread' field + * and order by that value. This field keeps this data in + * a way which is easy to update and convenient to use. + * + * A "thread" value starts at "1". If we add a child (A) to this comment, + * we assign it a "thread" = "1.1". A child of (A) will have "1.1.1". Next + * brother of (A) will get "1.2". Next brother of the parent of (A) will get + * "2" and so on. + * + * First of all note that the thread field stores the depth of the comment: + * depth 0 will be "X", depth 1 "X.X", depth 2 "X.X.X", etc. + * + * Now to get the ordering right, consider this example: + * + * 1 + * 1.1 + * 1.1.1 + * 1.2 + * 2 + * + * If we "ORDER BY thread ASC" we get the above result, and this is the + * natural order sorted by time. However, if we "ORDER BY thread DESC" + * we get: + * + * 2 + * 1.2 + * 1.1.1 + * 1.1 + * 1 + * + * Clearly, this is not a natural way to see a thread, and users will get + * confused. The natural order to show a thread by time desc would be: + * + * 2 + * 1 + * 1.2 + * 1.1 + * 1.1.1 + * + * which is what we already did before the standard pager patch. To achieve + * this we simply add a "/" at the end of each "thread" value. This way out + * thread fields will look like depicted below: + * + * 1/ + * 1.1/ + * 1.1.1/ + * 1.2/ + * 2/ + * + * we add "/" since this char is, in ASCII, higher than every number, so if + * now we "ORDER BY thread DESC" we get the correct order. However this would + * spoil the reverse ordering, "ORDER BY thread ASC" -- here, we do not need + * to consider the trailing "/" so we use a substring only. + */ function comment_render($node, $cid = 0) { global $user; @@ -792,69 +854,6 @@ function comment_render($node, $cid = 0) $query .= ' GROUP BY c.cid, c.pid, c.nid, c.subject, c.comment, c.format, c.timestamp, c.name, c.mail, u.picture, c.homepage, u.uid, u.name, u.picture, u.data, c.score, c.users, c.thread, c.status'; - /* - ** We want to use the standard pager, but threads would need every - ** comment to build the thread structure, so we need to store some - ** extra info. - ** - ** We use a "thread" field to store this extra info. The basic idea - ** is to store a value and to order by that value. The "thread" field - ** keeps this data in a way which is easy to update and convenient - ** to use. - ** - ** A "thread" value starts at "1". If we add a child (A) to this - ** comment, we assign it a "thread" = "1.1". A child of (A) will have - ** "1.1.1". Next brother of (A) will get "1.2". Next brother of the - ** parent of (A) will get "2" and so on. - ** - ** First of all note that the thread field stores the depth of the - ** comment: depth 0 will be "X", depth 1 "X.X", depth 2 "X.X.X", etc. - ** - ** Now to get the ordering right, consider this example: - ** - ** 1 - ** 1.1 - ** 1.1.1 - ** 1.2 - ** 2 - ** - ** If we "ORDER BY thread ASC" we get the above result, and this is - ** the natural order sorted by time. However, if we "ORDER BY thread - ** DESC" we get: - ** - ** 2 - ** 1.2 - ** 1.1.1 - ** 1.1 - ** 1 - ** - ** Clearly, this is not a natural way to see a thread, and users - ** will get confused. The natural order to show a thread by time - ** desc would be: - ** - ** 2 - ** 1 - ** 1.2 - ** 1.1 - ** 1.1.1 - ** - ** which is what we already did before the standard pager patch. To - ** achieve this we simply add a "/" at the end of each "thread" value. - ** This way out thread fields will look like depicted below: - ** - ** 1/ - ** 1.1/ - ** 1.1.1/ - ** 1.2/ - ** 2/ - ** - ** we add "/" since this char is, in ASCII, higher than every number, - ** so if now we "ORDER BY thread DESC" we get the correct order. Try - ** it, it works ;). However this would spoil the "ORDER BY thread ASC" - ** Here, we do not need to consider the trailing "/" so we use a - ** substring only. - */ - if ($order == COMMENT_ORDER_NEWEST_FIRST) { if ($mode == COMMENT_MODE_FLAT_COLLAPSED || $mode == COMMENT_MODE_FLAT_EXPANDED) { $query .= ' ORDER BY c.timestamp DESC';