--- members.module	2005-04-25 03:13:22.000000000 -0500
+++ members_47.module	2006-02-03 17:42:00.000000000 -0600
@@ -10,10 +10,25 @@ function members_help($section) {
 }
 
 function members_settings() {
-  $output = form_select(t("Roles to show"), "members_roles", variable_get("members_roles", array()), user_roles(1), t("Select roles to show in the members listing."), 0, 1);
-  $output .= form_select(t("Columns to show"), "members_fields", variable_get("members_fields", _member_fields()), _member_fields(), t("Select the fields which should be displayed on your members overview page. Note that some fields require certain modules to be active."), 0, 1);
-
-  return $output;
+  $form["members_roles"] = array(
+    '#type' => 'select',
+    '#title' => t("Roles to show"),
+    '#default_value' => variable_get("members_roles", array()),
+    '#options' => user_roles(1),
+    '#description' => t("Select roles to show in the members listing."),
+    '#extra' => 0,
+    '#multiple' => 1,
+  );
+  $form["members_fields"] = array(
+    '#type' => 'select',
+    '#title' => t("Columns to show"),
+    '#default_value' => variable_get("members_fields", _member_fields()),
+    '#options' => _member_fields(),
+    '#description' => t("Select the fields which should be displayed on your members overview page. Note that some fields require certain modules to be active."),
+    '#extra' => 0,
+    '#multiple' => 1,
+  );
+  return $form;
 }
 
 function members_menu($may_cache) {
@@ -57,7 +72,7 @@ function members_page($rids = null) {
         }
       }
       foreach ($fields as $field => $data) {
-        if (substr($field, 0, 8) == 'profile.') {
+        if (drupal_substr($field, 0, 8) == 'profile.') {
           $field = 'p.value';
         } else if ($field == 'rid') {
           $field = '';
@@ -73,7 +88,7 @@ function members_page($rids = null) {
       $query = "SELECT DISTINCT(u.uid) FROM {users} u INNER JOIN {users_roles} r ON u.uid=r.uid";
       $sort = tablesort_get_order($header);
       if ($sort['sql'] == 'p.value') {
-        $fieldid = db_result(db_query("SELECT fid FROM {profile_fields} WHERE name='%s'",substr(array_search($sort['name'], $fields), 8)));
+        $fieldid = db_result(db_query("SELECT fid FROM {profile_fields} WHERE name='%s'",drupal_substr(array_search($sort['name'], $fields), 8)));
         $query.= " LEFT JOIN {profile_values} p ON u.uid=p.uid WHERE (p.fid = '". db_escape_string($fieldid). "' OR p.fid IS NULL) AND";
       }
       else {
@@ -89,8 +104,8 @@ function members_page($rids = null) {
         $row = array();
         foreach ($fields as $field => $title) {
           $data = NULL;
-          if (substr($field, 0, 8) == 'profile.') {
-            $field = substr($field, 8);
+          if (drupal_substr($field, 0, 8) == 'profile.') {
+            $field = drupal_substr($field, 8);
             if (!$profile_fields[$field]) {
               $profile_fields[$field] = db_fetch_object(db_query("SELECT * FROM {profile_fields} WHERE name='%s'", $field));
             }
@@ -128,6 +143,7 @@ function members_page($rids = null) {
       }
 
       $output.= '<div id="members-main">'. theme("table", $header, $rows) .'</div>';
+      //$output.= '<div id="members-main">'. theme("table", $header, $rows) .'</div>';
       return  $output;
     }
     else {