$ cd /usr/local/coder/ $ git checkout issue-1518116 Already on 'issue-1518116' $ cd /var/www/community/d8.dev $ git pull Already up-to-date. $ git reset --hard b4f282a55b7da8c883216392cb74bf795cad3ff7 HEAD is now at b4f282a Issue #2144263 by fago, yched, alexpott, Berdir, plach, andypost, effulgentsia, michaelfavia: Decouple entity field storage from configurable fields. $ git checkout -b issue-1533250 Switched to a new branch 'issue-1533250' $ curl https://www.drupal.org/files/issues/drupal-make_locale_module_pass_coder_review-1533250-76.patch | git apply % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 121k 100 121k 0 0 120k 0 0:00:01 0:00:01 --:--:-- 120k $ drush dcs core/modules/locale FILE: /var/www/community/d8.dev/core/modules/locale/locale.api.php -------------------------------------------------------------------------------- FOUND 0 ERROR(S) AND 4 WARNING(S) AFFECTING 4 LINE(S) -------------------------------------------------------------------------------- 31 | WARNING | Line exceeds 80 characters; contains 102 characters 39 | WARNING | Line exceeds 80 characters; contains 87 characters 42 | WARNING | Line exceeds 80 characters; contains 94 characters 55 | WARNING | Line exceeds 80 characters; contains 125 characters -------------------------------------------------------------------------------- FILE: /var/www/community/d8.dev/core/modules/locale/locale.batch.inc -------------------------------------------------------------------------------- FOUND 1 ERROR(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 36 | ERROR | Arguments with default values must be at the end of the argument | | list -------------------------------------------------------------------------------- FILE: /var/www/community/d8.dev/core/modules/locale/locale.compare.inc -------------------------------------------------------------------------------- FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 43 | WARNING | Line exceeds 80 characters; contains 168 characters -------------------------------------------------------------------------------- FILE: /var/www/community/d8.dev/core/modules/locale/locale.fetch.inc -------------------------------------------------------------------------------- FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 5 | WARNING | Line exceeds 80 characters; contains 81 characters -------------------------------------------------------------------------------- FILE: /var/www/community/d8.dev/core/modules/locale/locale.install -------------------------------------------------------------------------------- FOUND 8 ERROR(S) AFFECTING 8 LINE(S) -------------------------------------------------------------------------------- 114 | ERROR | Comments may not appear after statements. 312 | ERROR | Do not use t() or st() in installation phase hooks, use $t = | | get_t() to retrieve the appropriate localization function name 314 | ERROR | Do not use t() or st() in installation phase hooks, use $t = | | get_t() to retrieve the appropriate localization function name 320 | ERROR | Do not use t() or st() in installation phase hooks, use $t = | | get_t() to retrieve the appropriate localization function name 322 | ERROR | Do not use t() or st() in installation phase hooks, use $t = | | get_t() to retrieve the appropriate localization function name 329 | ERROR | Do not use t() or st() in installation phase hooks, use $t = | | get_t() to retrieve the appropriate localization function name 337 | ERROR | Do not use t() or st() in installation phase hooks, use $t = | | get_t() to retrieve the appropriate localization function name 339 | ERROR | Do not use t() or st() in installation phase hooks, use $t = | | get_t() to retrieve the appropriate localization function name -------------------------------------------------------------------------------- FILE: /var/www/community/d8.dev/core/modules/locale/locale.module -------------------------------------------------------------------------------- FOUND 0 ERROR(S) AND 12 WARNING(S) AFFECTING 12 LINE(S) -------------------------------------------------------------------------------- 5 | WARNING | Line exceeds 80 characters; contains 81 characters 101 | WARNING | Line exceeds 80 characters; contains 81 characters 223 | WARNING | Format should be "* Implements hook_foo().", "* Implements | | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements | | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "* | | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.". 234 | WARNING | Format should be "* Implements hook_foo().", "* Implements | | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements | | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "* | | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.". 245 | WARNING | Format should be "* Implements hook_foo().", "* Implements | | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements | | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "* | | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.". 484 | WARNING | Line exceeds 80 characters; contains 82 characters 517 | WARNING | Line exceeds 80 characters; contains 81 characters 697 | WARNING | Format should be "* Implements hook_foo().", "* Implements | | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements | | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "* | | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.". 803 | WARNING | Format should be "* Implements hook_foo().", "* Implements | | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements | | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "* | | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.". 1114 | WARNING | Line exceeds 80 characters; contains 83 characters 1204 | WARNING | Line exceeds 80 characters; contains 82 characters 1300 | WARNING | Line exceeds 80 characters; contains 90 characters -------------------------------------------------------------------------------- FILE: /var/www/community/d8.dev/core/modules/locale/src/StringInterface.php -------------------------------------------------------------------------------- FOUND 9 ERROR(S) AFFECTING 9 LINE(S) -------------------------------------------------------------------------------- 29 | ERROR | Missing comment for @return statement 47 | ERROR | Missing comment for @return statement 65 | ERROR | Missing comment for @return statement 85 | ERROR | Missing comment for @return statement 103 | ERROR | Missing comment for @return statement 139 | ERROR | Missing comment for @return statement 184 | ERROR | Missing comment for @return statement 204 | ERROR | Missing comment for @return statement 214 | ERROR | Missing comment for @return statement -------------------------------------------------------------------------------- FILE: ...www/community/d8.dev/core/modules/locale/src/Tests/LocaleStringTest.php -------------------------------------------------------------------------------- FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 159 | WARNING | Line exceeds 80 characters; contains 142 characters -------------------------------------------------------------------------------- FILE: ...munity/d8.dev/core/modules/locale/src/Tests/LocaleTranslationUiTest.php -------------------------------------------------------------------------------- FOUND 0 ERROR(S) AND 7 WARNING(S) AFFECTING 7 LINE(S) -------------------------------------------------------------------------------- 75 | WARNING | Only string literals should be passed to t() where possible 79 | WARNING | Only string literals should be passed to t() where possible 150 | WARNING | Only string literals should be passed to t() where possible 156 | WARNING | Only string literals should be passed to t() where possible 157 | WARNING | Only string literals should be passed to t() where possible 300 | WARNING | Only string literals should be passed to t() where possible 359 | WARNING | Only string literals should be passed to t() where possible -------------------------------------------------------------------------------- FILE: ...var/www/community/d8.dev/core/modules/locale/src/TranslationsStream.php -------------------------------------------------------------------------------- FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 27 | WARNING | Line exceeds 80 characters; contains 83 characters -------------------------------------------------------------------------------- FILE: ...www/community/d8.dev/core/modules/locale/tests/src/LocaleLookupTest.php -------------------------------------------------------------------------------- FOUND 12 ERROR(S) AFFECTING 12 LINE(S) -------------------------------------------------------------------------------- 167 | ERROR | Line indented incorrectly; expected 4 spaces, found 6 168 | ERROR | Line indented incorrectly; expected 37 spaces, found 8 169 | ERROR | Line indented incorrectly; expected 39 spaces, found 10 171 | ERROR | Line indented incorrectly; expected 6 spaces, found 8 176 | ERROR | Line indented incorrectly; expected 4 spaces, found 6 177 | ERROR | Line indented incorrectly; expected 37 spaces, found 8 178 | ERROR | Line indented incorrectly; expected 39 spaces, found 10 179 | ERROR | Line indented incorrectly; expected 39 spaces, found 19 181 | ERROR | Line indented incorrectly; expected 39 spaces, found 10 182 | ERROR | Line indented incorrectly; expected 39 spaces, found 19 184 | ERROR | Line indented incorrectly; expected 39 spaces, found 10 185 | ERROR | Line indented incorrectly; expected 39 spaces, found 19 -------------------------------------------------------------------------------- Time: 6.33 seconds, Memory: 16.75Mb PHP_CodeSniffer found at least one issue. [error] $ git add -u $ git commit -m "Comment #75." [issue-1533250 e03b15e] Comment #75. 48 files changed, 444 insertions(+), 351 deletions(-) $ # Made code changes. $ drush dcs core/modules/locale FILE: /var/www/community/d8.dev/core/modules/locale/locale.api.php -------------------------------------------------------------------------------- FOUND 0 ERROR(S) AND 4 WARNING(S) AFFECTING 4 LINE(S) -------------------------------------------------------------------------------- 31 | WARNING | Line exceeds 80 characters; contains 102 characters 39 | WARNING | Line exceeds 80 characters; contains 87 characters 42 | WARNING | Line exceeds 80 characters; contains 94 characters 55 | WARNING | Line exceeds 80 characters; contains 125 characters -------------------------------------------------------------------------------- FILE: /var/www/community/d8.dev/core/modules/locale/locale.batch.inc -------------------------------------------------------------------------------- FOUND 1 ERROR(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 36 | ERROR | Arguments with default values must be at the end of the argument | | list -------------------------------------------------------------------------------- FILE: /var/www/community/d8.dev/core/modules/locale/locale.compare.inc -------------------------------------------------------------------------------- FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 43 | WARNING | Line exceeds 80 characters; contains 168 characters -------------------------------------------------------------------------------- FILE: /var/www/community/d8.dev/core/modules/locale/locale.fetch.inc -------------------------------------------------------------------------------- FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 5 | WARNING | Line exceeds 80 characters; contains 81 characters -------------------------------------------------------------------------------- FILE: /var/www/community/d8.dev/core/modules/locale/locale.module -------------------------------------------------------------------------------- FOUND 0 ERROR(S) AND 3 WARNING(S) AFFECTING 3 LINE(S) -------------------------------------------------------------------------------- 223 | WARNING | Format should be "* Implements hook_foo().", "* Implements | | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements | | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "* | | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.". 234 | WARNING | Format should be "* Implements hook_foo().", "* Implements | | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements | | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "* | | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.". 245 | WARNING | Format should be "* Implements hook_foo().", "* Implements | | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements | | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "* | | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.". -------------------------------------------------------------------------------- FILE: /var/www/community/d8.dev/core/modules/locale/src/StringInterface.php -------------------------------------------------------------------------------- FOUND 9 ERROR(S) AFFECTING 9 LINE(S) -------------------------------------------------------------------------------- 29 | ERROR | Missing comment for @return statement 47 | ERROR | Missing comment for @return statement 65 | ERROR | Missing comment for @return statement 85 | ERROR | Missing comment for @return statement 103 | ERROR | Missing comment for @return statement 139 | ERROR | Missing comment for @return statement 184 | ERROR | Missing comment for @return statement 204 | ERROR | Missing comment for @return statement 214 | ERROR | Missing comment for @return statement -------------------------------------------------------------------------------- FILE: ...munity/d8.dev/core/modules/locale/src/Tests/LocaleTranslationUiTest.php -------------------------------------------------------------------------------- FOUND 0 ERROR(S) AND 7 WARNING(S) AFFECTING 7 LINE(S) -------------------------------------------------------------------------------- 75 | WARNING | Only string literals should be passed to t() where possible 79 | WARNING | Only string literals should be passed to t() where possible 150 | WARNING | Only string literals should be passed to t() where possible 156 | WARNING | Only string literals should be passed to t() where possible 157 | WARNING | Only string literals should be passed to t() where possible 300 | WARNING | Only string literals should be passed to t() where possible 359 | WARNING | Only string literals should be passed to t() where possible -------------------------------------------------------------------------------- FILE: ...www/community/d8.dev/core/modules/locale/tests/src/LocaleLookupTest.php -------------------------------------------------------------------------------- FOUND 12 ERROR(S) AFFECTING 12 LINE(S) -------------------------------------------------------------------------------- 167 | ERROR | Line indented incorrectly; expected 4 spaces, found 6 168 | ERROR | Line indented incorrectly; expected 37 spaces, found 8 169 | ERROR | Line indented incorrectly; expected 39 spaces, found 10 171 | ERROR | Line indented incorrectly; expected 6 spaces, found 8 176 | ERROR | Line indented incorrectly; expected 4 spaces, found 6 177 | ERROR | Line indented incorrectly; expected 37 spaces, found 8 178 | ERROR | Line indented incorrectly; expected 39 spaces, found 10 179 | ERROR | Line indented incorrectly; expected 39 spaces, found 19 181 | ERROR | Line indented incorrectly; expected 39 spaces, found 10 182 | ERROR | Line indented incorrectly; expected 39 spaces, found 19 184 | ERROR | Line indented incorrectly; expected 39 spaces, found 10 185 | ERROR | Line indented incorrectly; expected 39 spaces, found 19 -------------------------------------------------------------------------------- Time: 6.83 seconds, Memory: 16.75Mb PHP_CodeSniffer found at least one issue. [error] $ # ^^These are pretty much all false positives. $ git df > ~/Desktop/interdiff.txt $ git df 8.x > ~/Desktop/drupal-make_locale_module_pass_coder_review-1533250-77.patch