diff -u b/core/modules/contact/src/Access/ContactPageAccess.php b/core/modules/contact/src/Access/ContactPageAccess.php --- b/core/modules/contact/src/Access/ContactPageAccess.php +++ b/core/modules/contact/src/Access/ContactPageAccess.php @@ -73,7 +73,7 @@ // User administrators should always have access to personal contact forms. $access = AccessResult::neutral()->cachePerRole(); $permission_access = AccessResult::allowedIfHasPermission($account, 'administer users'); - if ($permission_access->allowed()) { + if ($permission_access->isAllowed()) { return $access->orIf($permission_access); } diff -u b/core/modules/content_translation/src/Access/ContentTranslationOverviewAccess.php b/core/modules/content_translation/src/Access/ContentTranslationOverviewAccess.php --- b/core/modules/content_translation/src/Access/ContentTranslationOverviewAccess.php +++ b/core/modules/content_translation/src/Access/ContentTranslationOverviewAccess.php @@ -66,7 +66,7 @@ // Check "translate any entity" permission. if ($account->hasPermission('translate any entity')) { - return $access->allow()->cachePerRole(); + return $access->orIf(AccessResult::allowed()->cachePerRole()); } // Check per entity permission. @@ -74,7 +74,7 @@ if ($definition->getPermissionGranularity() == 'bundle') { $permission = "translate {$bundle} {$entity_type_id}"; } - return $access->allowIfHasPermission($account, $permission); + return $access->orIf(AccessResult::allowedIfHasPermission($account, $permission)); } // No opinion. diff -u b/core/modules/menu_link_content/src/MenuLinkContentAccessControlHandler.php b/core/modules/menu_link_content/src/MenuLinkContentAccessControlHandler.php --- b/core/modules/menu_link_content/src/MenuLinkContentAccessControlHandler.php +++ b/core/modules/menu_link_content/src/MenuLinkContentAccessControlHandler.php @@ -62,16 +62,14 @@ return AccessResult::neutral()->cachePerRole(); } else { - $access = AccessResult::neutral()->cachePerRole()->cacheUntilEntityChanges($entity); // If there is a URL, this is an external link so always accessible. - if ($entity->getUrl()) { - return $access->allow(); - } - else { + $access = AccessResult::allowed()->cachePerRole()->cacheUntilEntityChanges($entity); + if (!$entity->getUrl()) { // We allow access, but only if the link is accessible as well. $link_access = $this->accessManager->checkNamedRoute($entity->getRouteName(), $entity->getRouteParameters(), $account, TRUE); - return $access->allow()->andIf($link_access); + return $access->andIf($link_access); } + return $access; } case 'delete':