diff -u b/core/lib/Drupal/Core/Routing/Access/AccessInterface.php b/core/lib/Drupal/Core/Routing/Access/AccessInterface.php --- b/core/lib/Drupal/Core/Routing/Access/AccessInterface.php +++ b/core/lib/Drupal/Core/Routing/Access/AccessInterface.php @@ -16,4 +16,5 @@ // @todo Remove this interface since it no longer defines any methods? + // @see https://drupal.org/node/2266817. } diff -u b/core/modules/field_ui/lib/Drupal/field_ui/Access/FormModeAccessCheck.php b/core/modules/field_ui/lib/Drupal/field_ui/Access/FormModeAccessCheck.php --- b/core/modules/field_ui/lib/Drupal/field_ui/Access/FormModeAccessCheck.php +++ b/core/modules/field_ui/lib/Drupal/field_ui/Access/FormModeAccessCheck.php @@ -45,9 +45,15 @@ * @param \Drupal\Core\Session\AccountInterface $account * The currently logged in account. * @param string $form_mode_name - * The form mode. + * (optional) The form mode. Defaults to 'default'. * @param string $bundle - * The bundle. + * (optional) The bundle. Different entity types can have different names + * for their bundle key, so if not specified on the route via a {bundle} + * parameter, the access checker determines the appropriate key name, and + * gets the value from the corresponding request attribute. For example, + * for nodes, the bundle key is "node_type", so the value would be + * available via the {node_type} parameter rather than a {bundle} + * parameter. * * @return string * A \Drupal\Core\Access\AccessInterface constant value. diff -u b/core/modules/field_ui/lib/Drupal/field_ui/Access/ViewModeAccessCheck.php b/core/modules/field_ui/lib/Drupal/field_ui/Access/ViewModeAccessCheck.php --- b/core/modules/field_ui/lib/Drupal/field_ui/Access/ViewModeAccessCheck.php +++ b/core/modules/field_ui/lib/Drupal/field_ui/Access/ViewModeAccessCheck.php @@ -45,9 +45,15 @@ * @param \Drupal\Core\Session\AccountInterface $account * The currently logged in account. * @param string $view_mode_name - * The view mode. + * (optional) The view mode. Defaults to 'default'. * @param string $bundle - * The bundle. + * (optional) The bundle. Different entity types can have different names + * for their bundle key, so if not specified on the route via a {bundle} + * parameter, the access checker determines the appropriate key name, and + * gets the value from the corresponding request attribute. For example, + * for nodes, the bundle key is "node_type", so the value would be + * available via the {node_type} parameter rather than a {bundle} + * parameter. * * @return string * A \Drupal\Core\Access\AccessInterface constant value. diff -u b/core/modules/node/lib/Drupal/node/Access/NodeAddAccessCheck.php b/core/modules/node/lib/Drupal/node/Access/NodeAddAccessCheck.php --- b/core/modules/node/lib/Drupal/node/Access/NodeAddAccessCheck.php +++ b/core/modules/node/lib/Drupal/node/Access/NodeAddAccessCheck.php @@ -40,7 +40,8 @@ * @param \Drupal\Core\Session\AccountInterface $account * The currently logged in account. * @param \Drupal\node\NodeTypeInterface $node_type - * The node type. + * (optional) The node type. If not specified, access is allowed if there + * exists at least one node type for which the user may create a node. * * @return string * A \Drupal\Core\Access\AccessInterface constant value. diff -u b/core/modules/node/lib/Drupal/node/Access/NodeRevisionAccessCheck.php b/core/modules/node/lib/Drupal/node/Access/NodeRevisionAccessCheck.php --- b/core/modules/node/lib/Drupal/node/Access/NodeRevisionAccessCheck.php +++ b/core/modules/node/lib/Drupal/node/Access/NodeRevisionAccessCheck.php @@ -68,15 +68,19 @@ * The route to check against. * @param \Drupal\Core\Session\AccountInterface $account * The currently logged in account. + * @param int $node_revision + * (optional) The node revision ID. If not specified, but $node is, access + * is checked for that object's revision. * @param \Drupal\node\NodeInterface $node - * The node. - * @param string $node_revision - * The node revision. + * (optional) A node object. Used for checking access to a node's default + * revision when $node_revision is unspecified. Ignored when $node_revision + * is specified. If neither $node_revision nor $node are specified, then + * access is denied. * * @return string * A \Drupal\Core\Access\AccessInterface constant value. */ - public function access(Route $route, AccountInterface $account, NodeInterface $node = NULL, $node_revision = NULL) { + public function access(Route $route, AccountInterface $account, $node_revision = NULL, NodeInterface $node = NULL) { if ($node_revision) { $node = $this->nodeStorage->loadRevision($node_revision); } diff -u b/core/modules/quickedit/lib/Drupal/quickedit/Access/EditEntityFieldAccessCheck.php b/core/modules/quickedit/lib/Drupal/quickedit/Access/EditEntityFieldAccessCheck.php --- b/core/modules/quickedit/lib/Drupal/quickedit/Access/EditEntityFieldAccessCheck.php +++ b/core/modules/quickedit/lib/Drupal/quickedit/Access/EditEntityFieldAccessCheck.php @@ -51,7 +51,7 @@ * @todo Replace $request parameter with $entity once * https://drupal.org/node/1837388 is fixed. * - * @todo Use the $account argument. + * @todo Use the $account argument: https://drupal.org/node/2266809. */ public function access(Request $request, $field_name, AccountInterface $account) { if (!$this->validateAndUpcastRequestAttributes($request)) {