diff --git a/core/lib/Drupal/Core/Datetime/Element/DateElementBase.php b/core/lib/Drupal/Core/Datetime/Element/DateElementBase.php index 63b9abb871..433cdf8b18 100644 --- a/core/lib/Drupal/Core/Datetime/Element/DateElementBase.php +++ b/core/lib/Drupal/Core/Datetime/Element/DateElementBase.php @@ -2,6 +2,7 @@ namespace Drupal\Core\Datetime\Element; +use Drupal\Component\Utility\NestedArray; use Drupal\Core\Datetime\DrupalDateTime; use Drupal\Core\Render\Element\FormElement; @@ -69,4 +70,36 @@ protected static function datetimeRangeYears($string, $date = NULL) { return [$min_year, $max_year]; } + /** + * Returns the most relevant title of a datetime element. + * + * Since datetime form elements often consist of combined date and time fields + * the element title might not be located on the element itself but on the + * parent container element. + * + * @param array $element + * The element being processed. + * @param array $complete_form + * The complete form structure. + * + * @return string + * The title. + */ + protected static function getElementTitle($element, $complete_form) { + $title = ''; + if (!empty($element['#title'])) { + $title = $element['#title']; + } + else { + $parents = $element['#array_parents']; + array_pop($parents); + $parent_element = NestedArray::getValue($complete_form, $parents); + if (!empty($parent_element['#title'])) { + $title = $parent_element['#title']; + } + } + + return $title; + } + } diff --git a/core/lib/Drupal/Core/Datetime/Element/Datelist.php b/core/lib/Drupal/Core/Datetime/Element/Datelist.php index 5ca67ed51e..6f110d395f 100644 --- a/core/lib/Drupal/Core/Datetime/Element/Datelist.php +++ b/core/lib/Drupal/Core/Datetime/Element/Datelist.php @@ -302,19 +302,8 @@ public static function processDatelist(&$element, FormStateInterface $form_state public static function validateDatelist(&$element, FormStateInterface $form_state, &$complete_form) { $input_exists = FALSE; $input = NestedArray::getValue($form_state->getValues(), $element['#parents'], $input_exists); + $title = static::getElementTitle($element, $complete_form); - $title = ''; - if (!empty($element['#title'])) { - $title = $element['#title']; - } - else { - $parents = $element['#array_parents']; - array_pop($parents); - $parent_element = NestedArray::getValue($complete_form, $parents); - if (!empty($parent_element['#title'])) { - $title = $parent_element['#title']; - } - } if ($input_exists) { $all_empty = static::checkEmptyInputs($input, $element['#date_part_order']); diff --git a/core/modules/datetime_range/tests/src/Functional/DateRangeFieldTest.php b/core/modules/datetime_range/tests/src/Functional/DateRangeFieldTest.php index 23ba8fab03..685da99387 100644 --- a/core/modules/datetime_range/tests/src/Functional/DateRangeFieldTest.php +++ b/core/modules/datetime_range/tests/src/Functional/DateRangeFieldTest.php @@ -46,6 +46,7 @@ protected function getTestFieldType() { */ public function testDateRangeField() { $field_name = $this->fieldStorage->getName(); + $field_label = $this->field->label(); // Loop through defined timezones to test that date-only fields work at the // extremes. @@ -64,7 +65,7 @@ public function testDateRangeField() { $this->assertFieldByXPath('//*[@id="edit-' . $field_name . '-wrapper"]//label[contains(@class, "js-form-required")]', TRUE, 'Required markup found'); $this->assertNoFieldByName("{$field_name}[0][value][time]", '', 'Start time element not found.'); $this->assertNoFieldByName("{$field_name}[0][end_value][time]", '', 'End time element not found.'); - $this->assertFieldByXPath('//fieldset[@id="edit-' . $field_name . '-0"]/legend', $field_name, 'Fieldset and label found'); + $this->assertFieldByXPath('//fieldset[@id="edit-' . $field_name . '-0"]/legend', $field_label, 'Fieldset and label found'); $this->assertFieldByXPath('//fieldset[@aria-describedby="edit-' . $field_name . '-0--description"]', NULL, 'ARIA described-by found'); $this->assertFieldByXPath('//div[@id="edit-' . $field_name . '-0--description"]', NULL, 'ARIA description found'); @@ -256,6 +257,7 @@ public function testDateRangeField() { */ public function testDatetimeRangeField() { $field_name = $this->fieldStorage->getName(); + $field_label = $this->field->label(); // Ensure the field to a datetime field. $this->fieldStorage->setSetting('datetime_type', DateRangeItem::DATETIME_TYPE_DATETIME); @@ -267,7 +269,7 @@ public function testDatetimeRangeField() { $this->assertFieldByName("{$field_name}[0][value][time]", '', 'Start time element found.'); $this->assertFieldByName("{$field_name}[0][end_value][date]", '', 'End date element found.'); $this->assertFieldByName("{$field_name}[0][end_value][time]", '', 'End time element found.'); - $this->assertFieldByXPath('//fieldset[@id="edit-' . $field_name . '-0"]/legend', $field_name, 'Fieldset and label found'); + $this->assertFieldByXPath('//fieldset[@id="edit-' . $field_name . '-0"]/legend', $field_label, 'Fieldset and label found'); $this->assertFieldByXPath('//fieldset[@aria-describedby="edit-' . $field_name . '-0--description"]', NULL, 'ARIA described-by found'); $this->assertFieldByXPath('//div[@id="edit-' . $field_name . '-0--description"]', NULL, 'ARIA description found'); @@ -428,6 +430,7 @@ public function testDatetimeRangeField() { */ public function testAlldayRangeField() { $field_name = $this->fieldStorage->getName(); + $field_label = $this->field->label(); // Ensure field is set to a all-day field. $this->fieldStorage->setSetting('datetime_type', DateRangeItem::DATETIME_TYPE_ALLDAY); @@ -440,7 +443,7 @@ public function testAlldayRangeField() { $this->assertFieldByXPath('//*[@id="edit-' . $field_name . '-wrapper"]//label[contains(@class, "js-form-required")]', TRUE, 'Required markup found'); $this->assertNoFieldByName("{$field_name}[0][value][time]", '', 'Start time element not found.'); $this->assertNoFieldByName("{$field_name}[0][end_value][time]", '', 'End time element not found.'); - $this->assertFieldByXPath('//fieldset[@id="edit-' . $field_name . '-0"]/legend', $field_name, 'Fieldset and label found'); + $this->assertFieldByXPath('//fieldset[@id="edit-' . $field_name . '-0"]/legend', $field_label, 'Fieldset and label found'); $this->assertFieldByXPath('//fieldset[@aria-describedby="edit-' . $field_name . '-0--description"]', NULL, 'ARIA described-by found'); $this->assertFieldByXPath('//div[@id="edit-' . $field_name . '-0--description"]', NULL, 'ARIA description found'); @@ -598,6 +601,7 @@ public function testAlldayRangeField() { */ public function testDatelistWidget() { $field_name = $this->fieldStorage->getName(); + $field_label = $this->field->label(); // Ensure field is set to a date only field. $this->fieldStorage->setSetting('datetime_type', DateRangeItem::DATETIME_TYPE_DATE); @@ -616,7 +620,7 @@ public function testDatelistWidget() { // Display creation form. $this->drupalGet('entity_test/add'); - $this->assertFieldByXPath('//fieldset[@id="edit-' . $field_name . '-0"]/legend', $field_name, 'Fieldset and label found'); + $this->assertFieldByXPath('//fieldset[@id="edit-' . $field_name . '-0"]/legend', $field_label, 'Fieldset and label found'); $this->assertFieldByXPath('//fieldset[@aria-describedby="edit-' . $field_name . '-0--description"]', NULL, 'ARIA described-by found'); $this->assertFieldByXPath('//div[@id="edit-' . $field_name . '-0--description"]', NULL, 'ARIA description found');