.../QuickEditIntegrationTest.php | 313 ++++++++++----------- 1 file changed, 156 insertions(+), 157 deletions(-) diff --git a/core/modules/quickedit/tests/src/FunctionalJavaScript/QuickEditIntegrationTest.php b/core/modules/quickedit/tests/src/FunctionalJavaScript/QuickEditIntegrationTest.php index 857bf79..a59a657 100644 --- a/core/modules/quickedit/tests/src/FunctionalJavaScript/QuickEditIntegrationTest.php +++ b/core/modules/quickedit/tests/src/FunctionalJavaScript/QuickEditIntegrationTest.php @@ -109,163 +109,6 @@ protected function setUp() { $this->drupalLogin($this->contentAuthorUser); } - protected function startQuickEditViaToolbar($entity_type_id, $entity_id) { - $page = $this->getSession()->getPage(); - - $toolbar_edit_button_selector = '#toolbar-bar .contextual-toolbar-tab button'; - $entity_selector = '[data-quickedit-entity-id="' . $entity_type_id . '/' . $entity_id . '"]'; - $contextual_links_trigger_selector = '[data-contextual-id] > .trigger'; - - // Assert the original page state does not have the toolbar's "Edit" button - // pressed/activated, and hence none of the contextual link triggers should - // be visible. - $toolbar_edit_button = $page->find('css', $toolbar_edit_button_selector); - $this->assertSame('false', $toolbar_edit_button->getAttribute('aria-pressed'), 'The "Edit" button in the toolbar is not yet pressed.'); - $this->assertFalse($toolbar_edit_button->hasClass('is-active'), 'The "Edit" button in the toolbar is not yet marked as active.'); - foreach ($page->findAll('css', $contextual_links_trigger_selector) as $dom_node) { - /** @var \Behat\Mink\Element\NodeElement $dom_node */ - $this->assertTrue($dom_node->hasClass('visually-hidden'), 'The contextual links trigger "' . $dom_node->getParent()->getAttribute('data-contextual-id') .'" is hidden.'); - } - $this->assertTrue(TRUE, 'All contextual links triggers are hidden.'); - - // Click the "Edit" button in the toolbar. - $this->click($toolbar_edit_button_selector); - - // Assert the toolbar's "Edit" button is now pressed/activated, and hence - // allof the contextual link triggers should be visible. - $this->assertSame('true', $toolbar_edit_button->getAttribute('aria-pressed'), 'The "Edit" button in the toolbar is pressed.'); - $this->assertTrue($toolbar_edit_button->hasClass('is-active'), 'The "Edit" button in the toolbar is marked as active.'); - foreach ($page->findAll('css', $contextual_links_trigger_selector) as $dom_node) { - /** @var \Behat\Mink\Element\NodeElement $dom_node */ - $this->assertFalse($dom_node->hasClass('visually-hidden'), 'The contextual links trigger "' . $dom_node->getParent()->getAttribute('data-contextual-id') .'" is visible.'); - } - $this->assertTrue(TRUE, 'All contextual links triggers are visible.'); - - // @todo Press tab key to verify that tabbing is now contrained to only - // contextual links triggers. - - // Assert that the contextual links associated with the entity's contextual - // links trigger are not visible. - /** @var \Behat\Mink\Element\NodeElement $entity_contextual_links_container */ - $entity_contextual_links_container = $page->find('css', $entity_selector) - ->find('css', $contextual_links_trigger_selector) - ->getParent(); - $this->assertFalse($entity_contextual_links_container->hasClass('open')); - $this->assertTrue($entity_contextual_links_container->find('css', 'ul.contextual-links')->hasAttribute('hidden')); - - // Click the contextual link trigger for the entity we want to Quick Edit. - $this->click($entity_selector . ' ' . $contextual_links_trigger_selector); - - $this->assertTrue($entity_contextual_links_container->hasClass('open')); - $this->assertFalse($entity_contextual_links_container->find('css', 'ul.contextual-links')->hasAttribute('hidden')); - - // Click the "Quick edit" contextual link. - $this->click($entity_selector . ' [data-contextual-id] ul.contextual-links li.quickedit a'); - - // Assert the Quick Edit internal state is correct. - $js_condition = <<assertJsCondition($js_condition); - } - - // @todo startViaMouseOver - - protected function awaitQuickEditForEntity($entity_type_id, $entity_id) { - $entity_selector = '[data-quickedit-entity-id="' . $entity_type_id . '/' . $entity_id . '"]'; - $condition = "document.querySelectorAll('" . $entity_selector . " .quickedit').length > 0"; - $this->assertJsCondition($condition, 10000); - } - - /** - * @param string $expected_entity_label - * The expected label in the Quick Edit Entity Toolbar. - */ - protected function assertQuickEditEntityToolbar($expected_entity_label, $expected_field_label) { - $quickedit_entity_toolbar = $this->getSession()->getPage()->findById('quickedit-entity-toolbar'); - // We cannot use ->getText() because it also returns the text of all child - // nodes. So we use XPath to select only the text node. - $this->assertSame($expected_entity_label, $quickedit_entity_toolbar->find('css', '.quickedit-toolbar-label')->find('xpath', 'text()')->getText()); - if ($expected_field_label !== NULL) { - $this->assertSame($expected_field_label, $quickedit_entity_toolbar->find('css', '.quickedit-toolbar-label > .field')->getText()); - } - else { - $this->assertFalse($quickedit_entity_toolbar->find('css', '.quickedit-toolbar-label > .field')); - } - } - - /** - * Asserts all EntityModels for the page. - * - * @see Drupal.quickedit.EntityModel - * - * @param array $expected_entity_states - * Must describe the expected state of all in-place editable entities on the - * page. - */ - protected function assertEntityStates(array $expected_entity_states) { - $js_get_all_field_states_for_entity = <<assertSame($expected_entity_states, $this->getSession()->evaluateScript($js_get_all_field_states_for_entity)); - } - - protected function assertEntityFieldStates($entity_type_id, $entity_id, $entity_instance_id, array $expected_field_states) { - // Get all FieldModel states for the entity instance being asserted. This - // ensures that $expected_field_states must describe the state of all fields - // of the entity instance. - $entity_page_id = $entity_type_id . '/' . $entity_id . '[' . $entity_instance_id . ']'; - $js_get_all_field_states_for_entity = <<assertSame($expected_field_states, $this->getSession()->evaluateScript($js_get_all_field_states_for_entity)); - - // Assert that those fields also have the appropriate DOM decorations. - $expected_field_attributes = []; - foreach ($expected_field_states as $quickedit_field_id => $expected_field_state) { - $expected_field_attributes[$quickedit_field_id] = static::$expectedFieldStateAttributes[$expected_field_state]; - } - $this->assertEntityFieldMarkup($entity_type_id, $entity_id, $entity_instance_id, $expected_field_attributes); - } - - protected function assertEntityFieldMarkup($entity_type_id, $entity_id, $entity_instance_id, array $expected_field_attributes) { - $entity_page_id = $entity_type_id . '/' . $entity_id . '[' . $entity_instance_id . ']'; - $expected_field_attributes_json = json_encode($expected_field_attributes); - $js_match_field_element_attributes = <<getSession()->evaluateScript($js_match_field_element_attributes); - foreach ($expected_field_attributes as $quickedit_field_id => $expectation) { - $this->assertSame(TRUE, $result[$quickedit_field_id], 'Field ' . $quickedit_field_id . ' did not match its expectation selector (' . $expectation . '), actual HTML: ' . $result[$quickedit_field_id]); - } - } - /** * Tests if an article node can be in-place edited with Quick Edit. */ @@ -450,4 +293,160 @@ function () { // @todo test custom block + protected function startQuickEditViaToolbar($entity_type_id, $entity_id) { + $page = $this->getSession()->getPage(); + + $toolbar_edit_button_selector = '#toolbar-bar .contextual-toolbar-tab button'; + $entity_selector = '[data-quickedit-entity-id="' . $entity_type_id . '/' . $entity_id . '"]'; + $contextual_links_trigger_selector = '[data-contextual-id] > .trigger'; + + // Assert the original page state does not have the toolbar's "Edit" button + // pressed/activated, and hence none of the contextual link triggers should + // be visible. + $toolbar_edit_button = $page->find('css', $toolbar_edit_button_selector); + $this->assertSame('false', $toolbar_edit_button->getAttribute('aria-pressed'), 'The "Edit" button in the toolbar is not yet pressed.'); + $this->assertFalse($toolbar_edit_button->hasClass('is-active'), 'The "Edit" button in the toolbar is not yet marked as active.'); + foreach ($page->findAll('css', $contextual_links_trigger_selector) as $dom_node) { + /** @var \Behat\Mink\Element\NodeElement $dom_node */ + $this->assertTrue($dom_node->hasClass('visually-hidden'), 'The contextual links trigger "' . $dom_node->getParent()->getAttribute('data-contextual-id') .'" is hidden.'); + } + $this->assertTrue(TRUE, 'All contextual links triggers are hidden.'); + + // Click the "Edit" button in the toolbar. + $this->click($toolbar_edit_button_selector); + + // Assert the toolbar's "Edit" button is now pressed/activated, and hence + // allof the contextual link triggers should be visible. + $this->assertSame('true', $toolbar_edit_button->getAttribute('aria-pressed'), 'The "Edit" button in the toolbar is pressed.'); + $this->assertTrue($toolbar_edit_button->hasClass('is-active'), 'The "Edit" button in the toolbar is marked as active.'); + foreach ($page->findAll('css', $contextual_links_trigger_selector) as $dom_node) { + /** @var \Behat\Mink\Element\NodeElement $dom_node */ + $this->assertFalse($dom_node->hasClass('visually-hidden'), 'The contextual links trigger "' . $dom_node->getParent()->getAttribute('data-contextual-id') .'" is visible.'); + } + $this->assertTrue(TRUE, 'All contextual links triggers are visible.'); + + // @todo Press tab key to verify that tabbing is now contrained to only + // contextual links triggers. + + // Assert that the contextual links associated with the entity's contextual + // links trigger are not visible. + /** @var \Behat\Mink\Element\NodeElement $entity_contextual_links_container */ + $entity_contextual_links_container = $page->find('css', $entity_selector) + ->find('css', $contextual_links_trigger_selector) + ->getParent(); + $this->assertFalse($entity_contextual_links_container->hasClass('open')); + $this->assertTrue($entity_contextual_links_container->find('css', 'ul.contextual-links')->hasAttribute('hidden')); + + // Click the contextual link trigger for the entity we want to Quick Edit. + $this->click($entity_selector . ' ' . $contextual_links_trigger_selector); + + $this->assertTrue($entity_contextual_links_container->hasClass('open')); + $this->assertFalse($entity_contextual_links_container->find('css', 'ul.contextual-links')->hasAttribute('hidden')); + + // Click the "Quick edit" contextual link. + $this->click($entity_selector . ' [data-contextual-id] ul.contextual-links li.quickedit a'); + + // Assert the Quick Edit internal state is correct. + $js_condition = <<assertJsCondition($js_condition); + } + + // @todo startViaMouseOver + + protected function awaitQuickEditForEntity($entity_type_id, $entity_id) { + $entity_selector = '[data-quickedit-entity-id="' . $entity_type_id . '/' . $entity_id . '"]'; + $condition = "document.querySelectorAll('" . $entity_selector . " .quickedit').length > 0"; + $this->assertJsCondition($condition, 10000); + } + + /** + * @param string $expected_entity_label + * The expected label in the Quick Edit Entity Toolbar. + */ + protected function assertQuickEditEntityToolbar($expected_entity_label, $expected_field_label) { + $quickedit_entity_toolbar = $this->getSession()->getPage()->findById('quickedit-entity-toolbar'); + // We cannot use ->getText() because it also returns the text of all child + // nodes. So we use XPath to select only the text node. + $this->assertSame($expected_entity_label, $quickedit_entity_toolbar->find('css', '.quickedit-toolbar-label')->find('xpath', 'text()')->getText()); + if ($expected_field_label !== NULL) { + $this->assertSame($expected_field_label, $quickedit_entity_toolbar->find('css', '.quickedit-toolbar-label > .field')->getText()); + } + else { + $this->assertFalse($quickedit_entity_toolbar->find('css', '.quickedit-toolbar-label > .field')); + } + } + + /** + * Asserts all EntityModels for the page. + * + * @see Drupal.quickedit.EntityModel + * + * @param array $expected_entity_states + * Must describe the expected state of all in-place editable entities on the + * page. + */ + protected function assertEntityStates(array $expected_entity_states) { + $js_get_all_field_states_for_entity = <<assertSame($expected_entity_states, $this->getSession()->evaluateScript($js_get_all_field_states_for_entity)); + } + + protected function assertEntityFieldStates($entity_type_id, $entity_id, $entity_instance_id, array $expected_field_states) { + // Get all FieldModel states for the entity instance being asserted. This + // ensures that $expected_field_states must describe the state of all fields + // of the entity instance. + $entity_page_id = $entity_type_id . '/' . $entity_id . '[' . $entity_instance_id . ']'; + $js_get_all_field_states_for_entity = <<assertSame($expected_field_states, $this->getSession()->evaluateScript($js_get_all_field_states_for_entity)); + + // Assert that those fields also have the appropriate DOM decorations. + $expected_field_attributes = []; + foreach ($expected_field_states as $quickedit_field_id => $expected_field_state) { + $expected_field_attributes[$quickedit_field_id] = static::$expectedFieldStateAttributes[$expected_field_state]; + } + $this->assertEntityFieldMarkup($entity_type_id, $entity_id, $entity_instance_id, $expected_field_attributes); + } + + protected function assertEntityFieldMarkup($entity_type_id, $entity_id, $entity_instance_id, array $expected_field_attributes) { + $entity_page_id = $entity_type_id . '/' . $entity_id . '[' . $entity_instance_id . ']'; + $expected_field_attributes_json = json_encode($expected_field_attributes); + $js_match_field_element_attributes = <<getSession()->evaluateScript($js_match_field_element_attributes); + foreach ($expected_field_attributes as $quickedit_field_id => $expectation) { + $this->assertSame(TRUE, $result[$quickedit_field_id], 'Field ' . $quickedit_field_id . ' did not match its expectation selector (' . $expectation . '), actual HTML: ' . $result[$quickedit_field_id]); + } + } + }