diff -u b/core/modules/migrate/tests/modules/migrate_high_water_test/config/install/node.type.sql_import_node.yml b/core/modules/migrate/tests/modules/migrate_high_water_test/config/install/node.type.sql_import_node.yml --- b/core/modules/migrate/tests/modules/migrate_high_water_test/config/install/node.type.sql_import_node.yml +++ b/core/modules/migrate/tests/modules/migrate_high_water_test/config/install/node.type.sql_import_node.yml @@ -1,4 +1,4 @@ -langcode: en +qlangcode: en status: true name: High Water import node type: high_water_import_node diff -u b/core/modules/migrate/tests/src/Kernel/HighWaterTest.php b/core/modules/migrate/tests/src/Kernel/HighWaterTest.php --- b/core/modules/migrate/tests/src/Kernel/HighWaterTest.php +++ b/core/modules/migrate/tests/src/Kernel/HighWaterTest.php @@ -61,22 +61,18 @@ 'title', 'changed', ]) - ->values( - [ - 'title' => 'Item 1', - 'changed' => 1, - ]) - ->values( - [ - 'title' => 'Item 2', - 'changed' => 2, - ]) - ->values( - [ - 'title' => 'Item 3', - 'changed' => 3, - ] - ) + ->values([ + 'title' => 'Item 1', + 'changed' => 1, + ]) + ->values([ + 'title' => 'Item 2', + 'changed' => 2, + ]) + ->values([ + 'title' => 'Item 3', + 'changed' => 3, + ]) ->execute(); $this->installEntitySchema('node'); @@ -90,7 +86,6 @@ * Tests high water property of SqlBase. */ public function testHighWater() { - // Assert all of the nodes have been imported. $this->assertNodeExists('Item 1'); $this->assertNodeExists('Item 2'); @@ -99,36 +94,33 @@ // Highwater mark is now equal to 3. $this->assertSame('3', $this->migration->getHighWater()); - // Update Item 1 setting it's high_water_property to value that is below + // Update Item 1 setting its high_water_property to value that is below // current high water mark. $this->sourceDatabase->update('high_water_node') - ->fields( - [ - 'title' => 'Item 1 updated', - 'changed' => 2, - ]) + ->fields([ + 'title' => 'Item 1 updated', + 'changed' => 2, + ]) ->condition('title', 'Item 1') ->execute(); - // Update Item 2 setting it's high_water_property to value equal to + // Update Item 2 setting its high_water_property to value equal to // current high water mark. $this->sourceDatabase->update('high_water_node') - ->fields( - [ - 'title' => 'Item 2 updated', - 'changed' => 3, - ]) + ->fields([ + 'title' => 'Item 2 updated', + 'changed' => 3, + ]) ->condition('title', 'Item 2') ->execute(); - // Update Item 3 setting it's high_water_property to value that is above + // Update Item 3 setting its high_water_property to value that is above // current high water mark. $this->sourceDatabase->update('high_water_node') - ->fields( - [ - 'title' => 'Item 3 updated', - 'changed' => 4, - ]) + ->fields([ + 'title' => 'Item 3 updated', + 'changed' => 4, + ]) ->condition('title', 'Item 3') ->execute(); @@ -143,7 +135,7 @@ $this->assertNodeExists('Item 2'); $this->assertNodeDoesNotExist('Item 2 updated'); - // Item with greater highwater. Should be updated. + // Item with greater highwater should be updated. $this->assertNodeExists('Item 3 updated'); $this->assertNodeDoesNotExist('Item 3'); } diff -u b/core/modules/migrate/tests/src/Unit/MigrateSqlSourceTestCase.php b/core/modules/migrate/tests/src/Unit/MigrateSqlSourceTestCase.php --- b/core/modules/migrate/tests/src/Unit/MigrateSqlSourceTestCase.php +++ b/core/modules/migrate/tests/src/Unit/MigrateSqlSourceTestCase.php @@ -87,7 +87,7 @@ if (static::ORIGINAL_HIGH_WATER !== NULL) { $migration->expects($this->atLeastOnce()) ->method('getHighWater') - ->will($this->returnValue(static::ORIGINAL_HIGH_WATER)); + ->willReturn(static::ORIGINAL_HIGH_WATER); } // Setup the plugin.