diff --git a/link.install b/link.install index 14e745d..e1820f7 100644 --- a/link.install +++ b/link.install @@ -115,3 +115,17 @@ function link_update_7001() { } } } + +/** + * Removes unused link_extra_domains variable. + */ +function link_update_7002() { + variable_del('link_extra_domains'); +} + +/** + * Implements hook_uninstall(). + */ +function link_uninstall() { + variable_del('link_allowed_domains'); +} diff --git a/link.module b/link.module index a519432..aece66d 100644 --- a/link.module +++ b/link.module @@ -464,13 +464,13 @@ function _link_validate(&$item, $delta, $field, $entity, $instance, $langcode, & /** * Clean up user-entered values for a link field according to field settings. * - * @param array $item + * @param array $item * A single link item, usually containing url, title, and attributes. - * @param int $delta + * @param int $delta * The delta value if this field is one of multiple fields. - * @param array $field + * @param array $field * The CCK field definition. - * @param object $entity + * @param object $entity * The entity containing this link. */ function _link_sanitize(&$item, $delta, &$field, $instance, &$entity) { @@ -1382,8 +1382,8 @@ function link_url_type($text) { } /** - * Returns the list of allowed domains, including domains added by admins via - * variable_set/$config. + * Returns the list of allowed domains. + * * If the variable link_allowed_domains is set, restrict allowed domains to the * strings in that array. If the variable link_allowed_domains is not set, allow * all domains between 2 and 63 characters in length. diff --git a/tests/link.attribute.test b/tests/link.attribute.test index 36e6be5..4765814 100644 --- a/tests/link.attribute.test +++ b/tests/link.attribute.test @@ -31,8 +31,10 @@ class LinkAttributeCrudTest extends DrupalWebTestCase { parent::setup('field_ui', 'link'); $this->zebra = 0; // Create and login user. - $this->web_user = $this->drupalCreateUser(array('administer content types')); - $this->drupalLogin($this->web_user); + $perms = user_role_permissions(array(array_search('administrator', user_roles()) => 'administrator')); + $perms = array_keys($perms[array_search('administrator', user_roles())]); + $admin = $this->drupalCreateUser($perms); + $this->drupalLogin($admin); } protected function createLink($url, $title, $attributes = array()) { diff --git a/tests/link.crud.test b/tests/link.crud.test index e9b7db4..5f12840 100644 --- a/tests/link.crud.test +++ b/tests/link.crud.test @@ -29,8 +29,10 @@ class LinkContentCrudTest extends DrupalWebTestCase { $title = $this->randomName(20); // Create and login user. - $this->web_user = $this->drupalCreateUser(array('administer content types')); - $this->drupalLogin($this->web_user); + $perms = user_role_permissions(array(array_search('administrator', user_roles()) => 'administrator')); + $perms = array_keys($perms[array_search('administrator', user_roles())]); + $admin = $this->drupalCreateUser($perms); + $this->drupalLogin($admin); $this->drupalGet('admin/structure/types'); diff --git a/tests/link.crud_browser.test b/tests/link.crud_browser.test index be04260..803169b 100644 --- a/tests/link.crud_browser.test +++ b/tests/link.crud_browser.test @@ -42,15 +42,11 @@ class LinkUITest extends DrupalWebTestcase { */ function testLinkCreate() { //libxml_use_internal_errors(true); - $this->web_user = $this->drupalCreateUser(array( - 'administer content types', - 'administer nodes', - 'administer filters', - 'access content', - 'create page content', - 'access administration pages' - )); - $this->drupalLogin($this->web_user); + $perms = user_role_permissions(array(array_search('administrator', user_roles()) => 'administrator')); + $perms = array_keys($perms[array_search('administrator', user_roles())]); + $admin = $this->drupalCreateUser($perms); + $this->drupalLogin($admin); + // create field $name = strtolower($this->randomName()); @@ -133,7 +129,7 @@ class LinkUITest extends DrupalWebTestcase { $input_test_cases[] = $test_case; foreach ($input_test_cases as $input) { - $this->drupalLogin($this->web_user); + $this->drupalLogin($admin); $this->drupalGet('node/add/page'); $edit = array( @@ -179,8 +175,10 @@ class LinkUITest extends DrupalWebTestcase { * title actually displays . */ function testStaticLinkCreate() { - $this->web_user = $this->drupalCreateUser(array('administer content types', 'access content', 'create page content')); - $this->drupalLogin($this->web_user); + $perms = user_role_permissions(array(array_search('administrator', user_roles()) => 'administrator')); + $perms = array_keys($perms[array_search('administrator', user_roles())]); + $admin = $this->drupalCreateUser($perms); + $this->drupalLogin($admin); // create field $name = strtolower($this->randomName()); @@ -227,8 +225,10 @@ class LinkUITest extends DrupalWebTestcase { * Testing that if you have the title but no url, the title is not sanitized twice. */ function testCRUDTitleOnlyTitleNoLink() { - $this->web_user = $this->drupalCreateUser(array('administer content types', 'access content', 'create page content')); - $this->drupalLogin($this->web_user); + $perms = user_role_permissions(array(array_search('administrator', user_roles()) => 'administrator')); + $perms = array_keys($perms[array_search('administrator', user_roles())]); + $admin = $this->drupalCreateUser($perms); + $this->drupalLogin($admin); // create field $name = strtolower($this->randomName()); @@ -278,8 +278,10 @@ class LinkUITest extends DrupalWebTestcase { * sure they are set to the expected results. */ function testCRUDCreateFieldDefaults() { - $this->web_user = $this->drupalCreateUser(array('administer content types', 'access content', 'create page content')); - $this->drupalLogin($this->web_user); + $perms = user_role_permissions(array(array_search('administrator', user_roles()) => 'administrator')); + $perms = array_keys($perms[array_search('administrator', user_roles())]); + $admin = $this->drupalCreateUser($perms); + $this->drupalLogin($admin); // create field $name = strtolower($this->randomName()); @@ -318,8 +320,10 @@ class LinkUITest extends DrupalWebTestcase { * sure they are set to the expected results. */ function testCRUDCreateFieldWithClass() { - $this->web_user = $this->drupalCreateUser(array('administer content types', 'access content', 'create page content')); - $this->drupalLogin($this->web_user); + $perms = user_role_permissions(array(array_search('administrator', user_roles()) => 'administrator')); + $perms = array_keys($perms[array_search('administrator', user_roles())]); + $admin = $this->drupalCreateUser($perms); + $this->drupalLogin($admin); // create field $name = strtolower($this->randomName()); @@ -390,8 +394,10 @@ class LinkUITest extends DrupalWebTestcase { * sure they are set to the expected results. */ function testCRUDCreateFieldWithTwoClasses() { - $this->web_user = $this->drupalCreateUser(array('administer content types', 'access content', 'create page content')); - $this->drupalLogin($this->web_user); + $perms = user_role_permissions(array(array_search('administrator', user_roles()) => 'administrator')); + $perms = array_keys($perms[array_search('administrator', user_roles())]); + $admin = $this->drupalCreateUser($perms); + $this->drupalLogin($admin); // create field $name = strtolower($this->randomName()); diff --git a/tests/link.test b/tests/link.test index 962197f..b030153 100644 --- a/tests/link.test +++ b/tests/link.test @@ -23,9 +23,11 @@ class LinkBaseTestClass extends DrupalWebTestCase { $modules[] = 'field_ui'; $modules[] = 'link'; parent::setUp($modules); - - $this->web_user = $this->drupalCreateUser($this->permissions); - $this->drupalLogin($this->web_user); + + $perms = user_role_permissions(array(array_search('administrator', user_roles()) => 'administrator')); + $perms = array_keys($perms[array_search('administrator', user_roles())]); + $admin = $this->drupalCreateUser($perms); + $this->drupalLogin($admin); } protected function createLinkField($node_type = 'page', $settings = array()) { diff --git a/tests/link.validate.test b/tests/link.validate.test index 4cb66a4..f03a64c 100644 --- a/tests/link.validate.test +++ b/tests/link.validate.test @@ -61,13 +61,10 @@ class LinkValidateTest extends LinkValidateTestCase { * Test if we're stopped from posting a bad url on default validation. */ function test_link_validate_bad_url_validate_default() { - $this->web_user = $this->drupalCreateUser(array('administer content types', - 'administer nodes', - 'administer filters', - 'access content', - 'create page content', - 'access administration pages')); - $this->drupalLogin($this->web_user); + $perms = user_role_permissions(array(array_search('administrator', user_roles()) => 'administrator')); + $perms = array_keys($perms[array_search('administrator', user_roles())]); + $admin = $this->drupalCreateUser($perms); + $this->drupalLogin($admin); // create field $name = strtolower($this->randomName()); @@ -106,13 +103,10 @@ class LinkValidateTest extends LinkValidateTestCase { * Test if we're stopped from posting a bad url with validation on. */ function test_link_validate_bad_url_validate_on() { - $this->web_user = $this->drupalCreateUser(array('administer content types', - 'administer nodes', - 'administer filters', - 'access content', - 'create page content', - 'access administration pages')); - $this->drupalLogin($this->web_user); + $perms = user_role_permissions(array(array_search('administrator', user_roles()) => 'administrator')); + $perms = array_keys($perms[array_search('administrator', user_roles())]); + $admin = $this->drupalCreateUser($perms); + $this->drupalLogin($admin); // create field $name = strtolower($this->randomName()); @@ -152,13 +146,10 @@ class LinkValidateTest extends LinkValidateTestCase { * Test if we can post a bad url if the validation is expressly turned off. */ function test_link_validate_bad_url_validate_off() { - $this->web_user = $this->drupalCreateUser(array('administer content types', - 'administer nodes', - 'administer filters', - 'access content', - 'create page content', - 'access administration pages')); - $this->drupalLogin($this->web_user); + $perms = user_role_permissions(array(array_search('administrator', user_roles()) => 'administrator')); + $perms = array_keys($perms[array_search('administrator', user_roles())]); + $admin = $this->drupalCreateUser($perms); + $this->drupalLogin($admin); // create field $name = strtolower($this->randomName()); @@ -202,13 +193,10 @@ class LinkValidateTest extends LinkValidateTestCase { */ function x_test_link_validate_switching_between_validation_status() { $this->acquireContentTypes(1); - $this->web_user = $this->drupalCreateUser(array('administer content types', - 'administer nodes', - 'access administration pages', - 'access content', - 'create ' . $this->content_types[0]->type . ' content', - 'edit any ' . $this->content_types[0]->type . ' content')); - $this->drupalLogin($this->web_user); + $perms = user_role_permissions(array(array_search('administrator', user_roles()) => 'administrator')); + $perms = array_keys($perms[array_search('administrator', user_roles())]); + $admin = $this->drupalCreateUser($perms); + $this->drupalLogin($admin); variable_set('node_options_' . $this->content_types[0]->name, array('status', 'promote')); $field_settings = array( 'type' => 'link',