diff --git a/core/lib/Drupal/Core/Command/DbDumpCommand.php b/core/lib/Drupal/Core/Command/DbDumpCommand.php index ace6c4b..60cd4b6 100644 --- a/core/lib/Drupal/Core/Command/DbDumpCommand.php +++ b/core/lib/Drupal/Core/Command/DbDumpCommand.php @@ -23,7 +23,9 @@ * * @todo This command is currently only compatible with MySQL. Making it * backend-agnostic will require \Drupal\Core\Database\Schema support the - * ability to retrieve table schema information. + * ability to retrieve table schema information. Note that using a raw + * SQL dump file here (eg, generated from mysqldump or pg_dump) is not an + * option since these tend to still be database-backend specific. * @see https://www.drupal.org/node/301038 * * @see \Drupal\Core\Command\DbDumpApplication diff --git a/core/modules/system/src/Tests/Update/DbDumpTest.php b/core/modules/system/src/Tests/Update/DbDumpTest.php index aeb012a..bc6c243 100644 --- a/core/modules/system/src/Tests/Update/DbDumpTest.php +++ b/core/modules/system/src/Tests/Update/DbDumpTest.php @@ -26,7 +26,7 @@ class DbDumpTest extends KernelTestBase { /** * {@inheritdoc} */ - public static $modules = ['system', 'config']; + public static $modules = ['system', 'config', 'dblog']; /** * Test data to write into config. @@ -88,6 +88,7 @@ public function setUp() { // Create some schemas so our export contains tables. $this->installSchema('system', ['sessions', 'url_alias', 'key_value_expire']); + $this->installSchema('dblog', ['watchdog']); // Place some sample config to test for in the export. $this->data = ['foo' => $this->randomMachineName(), 'bar' => $this->randomMachineName()]; @@ -98,7 +99,7 @@ public function setUp() { \Drupal::cache('discovery')->set('test', $this->data); // These are all the tables that should now be in place. - $this->tables = ['sessions', 'url_alias', 'config', 'cache_discovery', 'cache_bootstrap', 'cache_default', 'key_value_expire']; + $this->tables = ['sessions', 'url_alias', 'config', 'cache_discovery', 'cache_bootstrap', 'cache_default', 'key_value_expire', 'watchdog']; } /**