diff --git a/core/tests/Drupal/Tests/Core/Entity/Sql/SqlContentEntityStorageSchemaTest.php b/core/tests/Drupal/Tests/Core/Entity/Sql/SqlContentEntityStorageSchemaTest.php index a3a44b0..9a786d5 100644 --- a/core/tests/Drupal/Tests/Core/Entity/Sql/SqlContentEntityStorageSchemaTest.php +++ b/core/tests/Drupal/Tests/Core/Entity/Sql/SqlContentEntityStorageSchemaTest.php @@ -1138,25 +1138,25 @@ public function providerTestRequiresEntityStorageSchemaChanges() { ->method('getKey') ->willReturn('id'); - // Case 1: Storage class changes should not impact this at all. + // Storage class changes should not impact this at all, and should not be + // checked. $updated = clone $updated_entity_type_definition; $original = clone $original_entity_type_definition; $updated->expects($this->never()) ->method('getStorageClass'); $original->expects($this->never()) ->method('getStorageClass'); - $cases[] = [$updated, $original, FALSE]; + + // Case 1: No shared table changes should not require change. + $cases[] = [$updated, $original, FALSE, FALSE, FALSE]; // Case 2: A change in the entity schema should result in required changes. - $cases[] = [$updated, $original, TRUE, TRUE]; + $cases[] = [$updated, $original, TRUE, TRUE, FALSE]; // Case 3: Has shared table changes should result in required changes. $cases[] = [$updated, $original, TRUE, FALSE, TRUE]; - // Case 4: No shared table changes should not require change. - $cases[] = [$updated, $original, FALSE, FALSE, FALSE]; - - // Case 5: Changing translation should result in required changes. + // Case 4: Changing translation should result in required changes. $updated = clone $updated_entity_type_definition; $updated->expects($this->once()) ->method('isTranslatable') @@ -1167,7 +1167,7 @@ public function providerTestRequiresEntityStorageSchemaChanges() { ->willReturn(TRUE); $cases[] = [$updated, $original, TRUE, FALSE, FALSE]; - // Case 6: Changing revisionable should result in required changes. + // Case 5: Changing revisionable should result in required changes. $updated = clone $updated_entity_type_definition; $updated->expects($this->once()) ->method('isRevisionable') @@ -1186,7 +1186,7 @@ public function providerTestRequiresEntityStorageSchemaChanges() { * * @dataProvider providerTestRequiresEntityStorageSchemaChanges */ - public function testRequiresEntityStorageSchemaChanges(ContentEntityTypeInterface $updated, ContentEntityTypeInterface $original, $requires_change, $change_schema = FALSE, $change_shared_table = FALSE) { + public function testRequiresEntityStorageSchemaChanges(ContentEntityTypeInterface $updated, ContentEntityTypeInterface $original, $requires_change, $change_schema, $change_shared_table) { $this->entityType = new ContentEntityType(array( 'id' => 'entity_test',