diff --git a/core/modules/outside_in/src/Block/BlockEntityOffCanvasForm.php b/core/modules/outside_in/src/Block/BlockEntityOffCanvasForm.php index ee1a03626f..d2ff362bf8 100644 --- a/core/modules/outside_in/src/Block/BlockEntityOffCanvasForm.php +++ b/core/modules/outside_in/src/Block/BlockEntityOffCanvasForm.php @@ -170,7 +170,7 @@ public function submitFormDialog(array &$form, FormStateInterface $form_state) { } else { // Settings Tray always provides a destination. - throw new \Exception("No destination provide for Settings Tray form"); + throw new \Exception("No destination provided by Settings Tray form"); } } return $response->addCommand($command); diff --git a/core/modules/outside_in/tests/modules/outside_in_test/src/Plugin/Block/ValidationErrorBlock.php b/core/modules/outside_in/tests/modules/outside_in_test/src/Plugin/Block/ValidationErrorBlock.php index 095e2799e9..a78d75f399 100644 --- a/core/modules/outside_in/tests/modules/outside_in_test/src/Plugin/Block/ValidationErrorBlock.php +++ b/core/modules/outside_in/tests/modules/outside_in_test/src/Plugin/Block/ValidationErrorBlock.php @@ -19,7 +19,7 @@ class ValidationErrorBlock extends BlockBase { * {@inheritdoc} */ public function build() { - return ['#markup' => "\u{2600} \u{27A1} \u{1F415} \u{1F6B6} \u{1F570}"]; + return ['#markup' => 'If I had more time this would be very witty :(.']; } /** @@ -27,7 +27,7 @@ public function build() { */ public function validateConfigurationForm(array &$form, FormStateInterface $form_state) { parent::validateConfigurationForm($form, $form_state); - $form_state->setError($form['label'], "\u{1F525} Sorry system error. Please save again. \u{1F61C}"); + $form_state->setError($form['label'], 'Sorry system error. Please save again.'); } } diff --git a/core/modules/outside_in/tests/src/FunctionalJavascript/OutsideInBlockFormTest.php b/core/modules/outside_in/tests/src/FunctionalJavascript/OutsideInBlockFormTest.php index 5c7a791533..4e519f6f8b 100644 --- a/core/modules/outside_in/tests/src/FunctionalJavascript/OutsideInBlockFormTest.php +++ b/core/modules/outside_in/tests/src/FunctionalJavascript/OutsideInBlockFormTest.php @@ -515,11 +515,10 @@ public function testValidationMessages() { $this->drupalGet('user'); $this->enableEditMode(); $this->openBlockForm($this->getBlockSelector($block)); - // Use label that will trigger validation error. - // @see _outside_in_test_validate_title - $page->fillField('settings[label]', 'Block label'); $page->pressButton('Save Block with validation error'); $web_assert->assertWaitOnAjaxRequest(); + // The outside_in_test_validation test plugin form always has a validation + // error. $web_assert->elementContains('css', '#drupal-off-canvas', 'Sorry system error. Please save again'); $this->disableEditMode(); $block->delete();