tests/src/Functional/ResourceTestBase.php | 35 +++++++++---------------------- 1 file changed, 10 insertions(+), 25 deletions(-) diff --git a/tests/src/Functional/ResourceTestBase.php b/tests/src/Functional/ResourceTestBase.php index ac9ec61..1843fe5 100644 --- a/tests/src/Functional/ResourceTestBase.php +++ b/tests/src/Functional/ResourceTestBase.php @@ -647,7 +647,7 @@ abstract class ResourceTestBase extends BrowserTestBase { 'target_entity' => static::$entityTypeId, 'resource_type' => $this->container->get('jsonapi.resource_type.repository')->getByTypeName(static::$resourceTypeName), ]); - // @todo ………………………………………… (deserialization works, but the UUID is set to a random one rather than the received one) + // @todo Uncomment this in https://www.drupal.org/project/jsonapi/issues/2942561#comment-12472704. // $this->assertSame($unserialized->uuid(), $this->entity->uuid()); $get_headers = $response->getHeaders(); @@ -747,7 +747,7 @@ abstract class ResourceTestBase extends BrowserTestBase { $url = Url::fromRoute(sprintf('jsonapi.%s.collection', static::$resourceTypeName), [static::$entityTypeId => $this->entity->uuid()]); $request_options = $this->getAuthenticationRequestOptions('POST'); - // @todo JSON API doesn't handle any of these edge cases correctly. + // @todo Uncomment in https://www.drupal.org/project/jsonapi/issues/2943170. /* // DX: 415 when no Content-Type request header. HTML response because // missing ?_format query string. @@ -767,25 +767,17 @@ abstract class ResourceTestBase extends BrowserTestBase { // DX: 400 when no request body. $response = $this->request('POST', $url, $request_options); $this->assertResourceErrorResponse(400, 'No entity content received.', $response); +*/ $request_options[RequestOptions::BODY] = $unparseable_request_body; // DX: 400 when unparseable request body. $response = $this->request('POST', $url, $request_options); - $this->assertResourceErrorResponse(400, 'df', 'Syntax error', $response); -*/ + // @todo Uncomment in https://www.drupal.org/project/jsonapi/issues/2943165. + // $this->assertResourceErrorResponse(400, 'Bad Request', 'Syntax error', $response); $request_options[RequestOptions::BODY] = $parseable_invalid_request_body; -// if (static::$auth) { -// // DX: forgetting authentication: authentication provider-specific error -// // response. -// $response = $this->request('POST', $url, $request_options); -// $this->assertResponseWhenMissingAuthentication('POST', $response); -// } -// -// $request_options = NestedArray::mergeDeep($request_options, $this->getAuthenticationRequestOptions('POST')); - // DX: 403 when unauthorized. $response = $this->request('POST', $url, $request_options); $reason = $this->getExpectedUnauthorizedAccessMessage('POST'); @@ -951,7 +943,7 @@ abstract class ResourceTestBase extends BrowserTestBase { //$url = $this->entity->toUrl('jsonapi'); $request_options = $this->getAuthenticationRequestOptions('PATCH');; - // @todo JSON API doesn't handle any of these edge cases correctly. + // @todo Uncomment in https://www.drupal.org/project/jsonapi/issues/2943170. /* // DX: 415 when no Content-Type request header. $response = $this->request('PATCH', $url, $request_options); @@ -970,23 +962,16 @@ abstract class ResourceTestBase extends BrowserTestBase { // DX: 400 when no request body. $response = $this->request('PATCH', $url, $request_options); $this->assertResourceErrorResponse(400, 'No entity content received.', $response); +*/ $request_options[RequestOptions::BODY] = $unparseable_request_body; // DX: 400 when unparseable request body. $response = $this->request('PATCH', $url, $request_options); - $this->assertResourceErrorResponse(400, 'Syntax error', $response); -*/ - $request_options[RequestOptions::BODY] = $parseable_invalid_request_body; + // @todo Uncomment in https://www.drupal.org/project/jsonapi/issues/2943165. + // $this->assertResourceErrorResponse(400, 'Bad request', 'Syntax error', $response); -// if (static::$auth) { -// // DX: forgetting authentication: authentication provider-specific error -// // response. -// $response = $this->request('PATCH', $url, $request_options); -// $this->assertResponseWhenMissingAuthentication('PATCH', $response); -// } -// -// $request_options = NestedArray::mergeDeep($request_options, $this->getAuthenticationRequestOptions('PATCH')); + $request_options[RequestOptions::BODY] = $parseable_invalid_request_body; // DX: 403 when unauthorized. $response = $this->request('PATCH', $url, $request_options);