diff -u b/core/misc/collapse.es6.js b/core/misc/collapse.es6.js --- b/core/misc/collapse.es6.js +++ b/core/misc/collapse.es6.js @@ -138,7 +138,7 @@ }; /** - * Show parent details elements of a targeted page fragment. + * Open parent details elements of a targeted page fragment. * * Opens all (nested) details element on a hash change or fragment link click * when the target is a child element, in order to make sure the targeted @@ -150,14 +150,14 @@ * @param {jQuery} $target * The targeted node as a jQuery object. */ - const handleFragmentInteraction = function openDetailsOnFragmentInteracion(e, $target) { + const handleFragmentLinkClickOrHashChange = function openDetailsOnFragmentLinkClickOrHashChange(e, $target) { $target.parents('details').not('[open]').find('> summary').trigger('click'); }; /** * Binds a listener to handle fragment link clicks and URL hash changes. */ - $('body').on('formFragmentClickOrChange.details', handleFragmentInteraction); + $('body').on('formFragmentLinkClickOrHashChange.details', handleFragmentLinkClickOrHashChange); // Expose constructor in the public space. Drupal.CollapsibleDetails = CollapsibleDetails; diff -u b/core/misc/collapse.js b/core/misc/collapse.js --- b/core/misc/collapse.js +++ b/core/misc/collapse.js @@ -77,11 +77,11 @@ } }; - var handleFragmentInteraction = function openDetailsOnFragmentInteracion(e, $target) { + var handleFragmentLinkClickOrHashChange = function openDetailsOnFragmentLinkClickOrHashChange(e, $target) { $target.parents('details').not('[open]').find('> summary').trigger('click'); }; - $('body').on('formFragmentClickOrChange.details', handleFragmentInteraction); + $('body').on('formFragmentLinkClickOrHashChange.details', handleFragmentLinkClickOrHashChange); Drupal.CollapsibleDetails = CollapsibleDetails; })(jQuery, Modernizr, Drupal); \ No newline at end of file diff -u b/core/misc/form.es6.js b/core/misc/form.es6.js --- b/core/misc/form.es6.js +++ b/core/misc/form.es6.js @@ -19,7 +19,7 @@ * when a link containing a fragment identifier is clicked. In case the hash * changes due to a click this event will only be triggered once. * - * @event formFragmentClickOrChange + * @event formFragmentLinkClickOrHashChange */ (function ($, Drupal, debounce) { @@ -262,12 +262,12 @@ * @param {jQuery.Event} e * The event triggered. * - * @fires event:formFragmentClickOrChange + * @fires event:formFragmentLinkClickOrHashChange */ - const handleFragmentInteraction = function triggerFragmentInteraction(e) { + const handleFragmentLinkClickOrHashChange = function triggerFragmentLinkClickOrChange(e) { const $target = e.type === 'click' ? (e.currentTarget.location ? $(e.currentTarget.location.hash) : $(e.currentTarget.hash)) : $(`#${location.hash.substr(1)}`); - $('body').trigger('formFragmentClickOrChange', [$target]); + $('body').trigger('formFragmentLinkClickOrHashChange', [$target]); /** * Interaction with the page fragment should set focus, but event timing @@ -279,7 +279,7 @@ }; // Binds a listener to handle URL fragment changes. - $(window).on('hashchange.form-fragment', debounce(handleFragmentInteraction, 20)); + $(window).on('hashchange.form-fragment', debounce(handleFragmentLinkClickOrHashChange, 20)); /** * Binds a listener to handle clicks on fragment links and absolute URL links diff -u b/core/misc/form.js b/core/misc/form.js --- b/core/misc/form.js +++ b/core/misc/form.js @@ -125,17 +125,17 @@ } }; - var handleFragmentInteraction = function triggerFragmentInteraction(e) { + var handleFragmentLinkClickOrHashChange = function triggerFragmentLinkClickOrChange(e) { var $target = e.type === 'click' ? e.currentTarget.location ? $(e.currentTarget.location.hash) : $(e.currentTarget.hash) : $('#' + location.hash.substr(1)); - $('body').trigger('formFragmentClickOrChange', [$target]); + $('body').trigger('formFragmentLinkClickOrHashChange', [$target]); setTimeout(function () { $target.focus(); }, 300, $target); }; - $(window).on('hashchange.form-fragment', debounce(handleFragmentInteraction, 20)); + $(window).on('hashchange.form-fragment', debounce(handleFragmentLinkClickOrHashChange, 20)); $(document).on('click.form-fragment', 'a[href*="#"]', debounce(handleFragmentInteraction, 20)); })(jQuery, Drupal, Drupal.debounce); \ No newline at end of file diff -u b/core/misc/vertical-tabs.es6.js b/core/misc/vertical-tabs.es6.js --- b/core/misc/vertical-tabs.es6.js +++ b/core/misc/vertical-tabs.es6.js @@ -16,15 +16,15 @@ /** * Show the parent vertical tab pane of a targeted page fragment. * - * In order to make sure a targeted element inside a vertical tab pane is - * visible on a hash change or fragment link click, show all parent panes. + * In order to make sure a targeted element inside a vertical tab pane is + * visible on a hash change or fragment link click, show all parent panes. * * @param {jQuery.Event} e * The event triggered. * @param {jQuery} $target * The targeted node as a jQuery object. */ - const handleFragmentInteraction = function showVerticalTabsPanesOnFragmentInteracion(e, $target) { + const handleFragmentLinkClickOrHashChange = function showVerticalTabsPanesOnFragmentLinkClickOrHashChange(e, $target) { $target.parents('.vertical-tabs__pane').each((index, pane) => { $(pane).data('verticalTab').focus(); }); @@ -56,7 +56,7 @@ /** * Binds a listener to handle fragment link clicks and URL hash changes. */ - $('body').once('vertical-tabs-fragments').on('formFragmentClickOrChange.verticalTabs', handleFragmentInteraction); + $('body').once('vertical-tabs-fragments').on('formFragmentLinkClickOrHashChange.verticalTabs', handleFragmentLinkClickOrHashChange); $(context).find('[data-vertical-tabs-panes]').once('vertical-tabs').each(function () { const $this = $(this).addClass('vertical-tabs__panes'); diff -u b/core/misc/vertical-tabs.js b/core/misc/vertical-tabs.js --- b/core/misc/vertical-tabs.js +++ b/core/misc/vertical-tabs.js @@ -6,7 +6,7 @@ **/ (function ($, Drupal, drupalSettings) { - var handleFragmentInteraction = function showVerticalTabsPanesOnFragmentInteracion(e, $target) { + var handleFragmentLinkClickOrHashChange = function showVerticalTabsPanesOnFragmentLinkClickOrHashChange(e, $target) { $target.parents('.vertical-tabs__pane').each(function (index, pane) { $(pane).data('verticalTab').focus(); }); @@ -21,7 +21,7 @@ return; } - $('body').once('vertical-tabs-fragments').on('formFragmentClickOrChange.verticalTabs', handleFragmentInteraction); + $('body').once('vertical-tabs-fragments').on('formFragmentLinkClickOrHashChange.verticalTabs', handleFragmentLinkClickOrHashChange); $(context).find('[data-vertical-tabs-panes]').once('vertical-tabs').each(function () { var $this = $(this).addClass('vertical-tabs__panes');