diff --git a/core/modules/system/src/Tests/Entity/EntityCacheTagsTestBase.php b/core/modules/system/src/Tests/Entity/EntityCacheTagsTestBase.php index 2326794..ebb7304 100644 --- a/core/modules/system/src/Tests/Entity/EntityCacheTagsTestBase.php +++ b/core/modules/system/src/Tests/Entity/EntityCacheTagsTestBase.php @@ -68,7 +68,6 @@ public function setUp() { if ($this->entity->getEntityType()->isFieldable()) { // Add field, so we can modify the Field and FieldInstance entities to // verify that changes to those indeed clear cache tags. - $field_name = drupal_strtolower($this->randomName()); entity_create('field_config', array( 'name' => 'configurable_field', 'entity_type' => $this->entity->getEntityTypeId(), diff --git a/core/modules/system/src/Tests/Form/ElementsTableSelectTest.php b/core/modules/system/src/Tests/Form/ElementsTableSelectTest.php index 9ce3fb2..5bc8314 100644 --- a/core/modules/system/src/Tests/Form/ElementsTableSelectTest.php +++ b/core/modules/system/src/Tests/Form/ElementsTableSelectTest.php @@ -166,11 +166,11 @@ function testMultipleTrueOptionchecker() { ); // Test with a valid value. - list($processed_form, $form_state, $errors) = $this->formSubmitHelper($form, array('tableselect' => array('row1' => 'row1'))); + list(, , $errors) = $this->formSubmitHelper($form, array('tableselect' => array('row1' => 'row1'))); $this->assertFalse(isset($errors['tableselect']), 'Option checker allows valid values for checkboxes.'); // Test with an invalid value. - list($processed_form, $form_state, $errors) = $this->formSubmitHelper($form, array('tableselect' => array('non_existing_value' => 'non_existing_value'))); + list(, , $errors) = $this->formSubmitHelper($form, array('tableselect' => array('non_existing_value' => 'non_existing_value'))); $this->assertTrue(isset($errors['tableselect']), 'Option checker disallows invalid values for checkboxes.'); } @@ -191,11 +191,11 @@ function testMultipleFalseOptionchecker() { ); // Test with a valid value. - list($processed_form, $form_state, $errors) = $this->formSubmitHelper($form, array('tableselect' => 'row1')); + list(, , $errors) = $this->formSubmitHelper($form, array('tableselect' => 'row1')); $this->assertFalse(isset($errors['tableselect']), 'Option checker allows valid values for radio buttons.'); // Test with an invalid value. - list($processed_form, $form_state, $errors) = $this->formSubmitHelper($form, array('tableselect' => 'non_existing_value')); + list(, , $errors) = $this->formSubmitHelper($form, array('tableselect' => 'non_existing_value')); $this->assertTrue(isset($errors['tableselect']), 'Option checker disallows invalid values for radio buttons.'); } diff --git a/core/modules/system/tests/src/Controller/SystemControllerTest.php b/core/modules/system/tests/src/Controller/SystemControllerTest.php index a1cdfaf..199a44f 100644 --- a/core/modules/system/tests/src/Controller/SystemControllerTest.php +++ b/core/modules/system/tests/src/Controller/SystemControllerTest.php @@ -125,8 +125,6 @@ public function providerTestSetLinkActiveClass() { 'language' => 'nl', 'query' => array(), ); - // Nothing to do. - $markup = 'bar'; $situations[] = array('context' => $context, 'is active' => FALSE, 'attributes' => array()); // Matching path, plus all matching variations. $attributes = array( @@ -162,8 +160,6 @@ public function providerTestSetLinkActiveClass() { 'language' => 'nl', 'query' => array('foo' => 'bar'), ); - // Nothing to do. - $markup = 'bar'; $situations[] = array('context' => $context, 'is active' => FALSE, 'attributes' => array()); // Matching path, plus all matching variations. $attributes = array( @@ -195,8 +191,6 @@ public function providerTestSetLinkActiveClass() { 'language' => 'nl', 'query' => array('foo' => 'bar'), ); - // Nothing to do. - $markup = 'bar'; $situations[] = array('context' => $context, 'is active' => FALSE, 'attributes' => array()); // Matching path, plus all matching variations. $attributes = array( @@ -232,8 +226,6 @@ public function providerTestSetLinkActiveClass() { 'language' => 'en', 'query' => array('foo' => 'bar'), ); - // Nothing to do. - $markup = 'bar'; $situations[] = array('context' => $context, 'is active' => FALSE, 'attributes' => array()); // Matching path, plus all matching variations. $attributes = array(