### Eclipse Workspace Patch 1.0 #P drupal_test_7 Index: modules/field/field.test =================================================================== RCS file: /cvs/drupal/drupal/modules/field/field.test,v retrieving revision 1.2 diff -u -r1.2 field.test --- modules/field/field.test 5 Feb 2009 03:42:57 -0000 1.2 +++ modules/field/field.test 8 Feb 2009 21:52:11 -0000 @@ -150,7 +150,7 @@ // We make sure each value is stored correctly, then unset it. // When an entire revision's values are unset (remembering that we // put one extra value in $values per revision), unset the entire - // revision. Then, if $rev_values is empty at the end, all + // revision. Then, if $rev_values is empty at the end, all // revision data was found. $results = db_select($this->revision_table, 't')->fields('t')->execute(); foreach ($results as $row) { @@ -180,7 +180,7 @@ $this->assertEqual(count($rows), 0, t("Update with an empty field_name entry empties the field.")); } - // Test insert and update with missing or invalid fields. For the + // Test insert and update with missing or invalid fields. For the // most part, these tests pass by not crashing or causing exceptions. function testFieldAttachSaveMissingData() { $entity_type = 'test_entity'; @@ -203,13 +203,13 @@ $count = db_result(db_query("SELECT COUNT(*) FROM {{$this->table}}")); $this->assertEqual($count, 1, 'Field data saved'); - // Update: Field is missing. Data should survive. + // Update: Field is missing. Data should survive. unset($entity->{$this->field_name}); field_attach_update($entity_type, $entity); $count = db_result(db_query("SELECT COUNT(*) FROM {{$this->table}}")); $this->assertEqual($count, 1, 'Missing field leaves data in table'); - // Update: Field is NULL Data should be wiped. + // Update: Field is NULL. Data should be wiped. $entity->{$this->field_name} = NULL; field_attach_update($entity_type, $entity); $count = db_result(db_query("SELECT COUNT(*) FROM {{$this->table}}")); @@ -516,8 +516,8 @@ } // Verify that field_attach_validate() invokes the correct - // hook_field_validate. NOTE: This tests the FAPI-connected - // behavior of hook_field_validate. As discussed at + // hook_field_validate. NOTE: This tests the FAPI-connected + // behavior of hook_field_validate. As discussed at // http://groups.drupal.org/node/18019, field validation will // eventually be disconnected from FAPI, at which point this // function will have to be rewritten. @@ -550,7 +550,7 @@ $this->assertEqual(count($errors), 0, 'No extraneous form errors set'); } - // Validate that FAPI elements are generated. This could be much + // Validate that FAPI elements are generated. This could be much // more thorough, but it does verify that the correct widgets show up. function testFieldAttachForm() { $entity_type = 'test_entity'; Index: modules/field/field.install =================================================================== RCS file: /cvs/drupal/drupal/modules/field/field.install,v retrieving revision 1.1 diff -u -r1.1 field.install --- modules/field/field.install 3 Feb 2009 17:30:11 -0000 1.1 +++ modules/field/field.install 8 Feb 2009 21:52:10 -0000 @@ -1,5 +1,6 @@ $field_name. * - type (string) - * The type of the field, such as 'text' or 'image'. Field types + * The type of the field, such as 'text' or 'image'. Field types * are defined by modules that implement hook_field_into(). * - cardinality (integer) - * The number of values the field can hold. Legal values are any + * The number of values the field can hold. Legal values are any * positive integer or FIELD_CARDINALITY_UNLIMITED. * - locked (integer) * TODO: undefined. @@ -47,23 +53,23 @@ * TRUE if the module that implements the field type is currently * enabled, FALSE otherwise. * - deleted (integer, read-only) - * TRUE if this field has been deleted, FALSE otherwise. Deleted + * TRUE if this field has been deleted, FALSE otherwise. Deleted * fields are ignored by the Field Attach API. This property exists * because fields can be marked for deletion but only actually * destroyed by a separate garbage-collection process. * - columns (array, read-only). * An array of the Field API columns used to store each value of - * this field. The column list may depend on field settings; it is - * not constant per field type. Field API column specifications are + * this field. The column list may depend on field settings; it is + * not constant per field type. Field API column specifications are * exactly like Schema API column specifications but, depending on * the field storage module in use, the name of the column may not * represent an actual column in an SQL database. * - settings (array) - * A sub-array of key/value pairs of field-type-specific settings. Each + * A sub-array of key/value pairs of field-type-specific settings. Each * field type module defines and documents its own field settings. * * Field Instance objects are (currently) represented as an array of - * key/value pairs. The object properties are: + * key/value pairs. The object properties are: * * @param array $instance: * - field_name (string) @@ -72,15 +78,15 @@ * The name of the bundle that the field is attached to. * - label (string) * A human-readable label for the field when used with this - * bundle. For example, the label will be the title of Form API + * bundle. For example, the label will be the title of Form API * elements for this instance. * - description (string) * A human-readable description for the field when used with this - * bundle. For example, the description will be the help text of + * bundle. For example, the description will be the help text of * Form API elements for this instance. * - weight (float) * The order in which the field should be sorted relative - * to other fields when used with this bundle. The weight affects + * to other fields when used with this bundle. The weight affects * ordering in both forms (see field_attach_form()) and rendered output * (see field_attach_view()). * TODO - this should probably become a context setting so that @@ -88,7 +94,7 @@ * contexts. * - required (integer) * TRUE if a value for this field is required when used with this - * bundle, FALSE otherwise. Currently, required-ness is only enforced + * bundle, FALSE otherwise. Currently, required-ness is only enforced * during Form API operations, not by field_attach_load(), * field_attach_insert(), or field_attach_update(). * - default_value_function (string) @@ -100,13 +106,13 @@ * only actually destroyed by a separate garbage-collection process. * - settings (array) * A sub-array of key/value pairs of field-type-specific instance - * settings. Each field type module defines and documents its own + * settings. Each field type module defines and documents its own * instance settings. * - widget (array) * A sub-array of key/value pairs identifying the Form API input widget * for the field when used by this bundle. * - type (string) - * The type of the widget, such as text_textfield. Widget types + * The type of the widget, such as text_textfield. Widget types * are defined by modules that implement hook_field_widget_info(). * - module (string, read-only) * The name of the module that implements the widget type. @@ -144,18 +150,18 @@ * Create, update, and delete Field API fields, bundles, and instances. * * Modules use this API, often in hook_install(), to create custom - * data structures. UI modules will use it to create a user interface. + * data structures. UI modules will use it to create a user interface. * * The Field CRUD API uses * @link field_structs Field API data structures @endlink. */ /** - * Create a field. This function does not bind the field to any + * Create a field. This function does not bind the field to any * bundle; use field_create_instance for that. * * @param $field - * A field structure. The field_name and type properties are required. + * A field structure. The field_name and type properties are required. * @throw * FieldException */ @@ -208,7 +214,7 @@ } /** - * Read a single field record directly from the database. Generally, + * Read a single field record directly from the database. Generally, * you should use the field_info_field() instead. * * @param $field_name @@ -300,7 +306,7 @@ * Creates an instance of a field, binding it to a bundle. * * @param $instance - * A field instance structure. The field_name and bundle properties + * A field instance structure. The field_name and bundle properties * are required. * @throw * FieldException @@ -342,8 +348,8 @@ * @param $instance * An associative array represeting an instance structure. The required * keys and values are: - * field_name: The name of an existing field. - * bundle: The bundle this field belongs to. + * field_name: The name of an existing field. + * bundle: The bundle this field belongs to. * Any other properties specified in $instance overwrite the * existing values for the instance. * @throw @@ -452,7 +458,7 @@ } /** - * Read a single instance record directly from the database. Generally, + * Read a single instance record directly from the database. Generally, * you should use the field_info_instance() instead. * * @param $field_name @@ -479,7 +485,7 @@ * @param $param * An array of properties to use in selecting a field * instance. Valid keys include any column of the - * field_config_instance table. If NULL, all instances will be returned. + * field_config_instance table. If NULL, all instances will be returned. * @param $include_additional * The default behavior of this function is to not return field * instances that are inactive or have been marked deleted. Setting Index: modules/field/field.autoload.inc =================================================================== RCS file: /cvs/drupal/drupal/modules/field/field.autoload.inc,v retrieving revision 1.1 diff -u -r1.1 field.autoload.inc --- modules/field/field.autoload.inc 3 Feb 2009 17:30:11 -0000 1.1 +++ modules/field/field.autoload.inc 8 Feb 2009 21:52:09 -0000 @@ -1,7 +1,9 @@ content['field_foo']['wrapper'] = array( - * '#type' => 'field', + * '#theme' => 'field', * '#title' => 'label' * '#field_name' => 'field_name', * '#object' => $object, @@ -171,7 +168,7 @@ $format_info = $info + array( '#formatter' => $display['type'], '#settings' => $display['settings'], - '#theme_wrapper' => $theme, + '#theme' => $theme, ); if ($single) { @@ -187,7 +184,7 @@ // The wrapper lets us get the themed output for the whole field // to populate the $FIELD_NAME_rendered variable for templates, // and hide it from the $content variable if needed. - // See 'preprocess' op and theme_content_field_wrapper()? + // See 'preprocess' op and theme_content_field_wrapper(). $wrapper = $info + array( 'field' => $element, '#weight' => $instance['weight'], @@ -220,8 +217,8 @@ * This is a theme function, so it can be overridden in different * themes to produce different results. * - * The html for individual fields and groups are available in the - * $FIELD_NAME_rendered and $GROUP_NAME_rendered variables. + * The html for individual fields are available in the $FIELD_NAME_rendered + * variables. * * @return * Whether or not the field's content is to be added in this context. Index: modules/field/field.api.php =================================================================== RCS file: /cvs/drupal/drupal/modules/field/field.api.php,v retrieving revision 1.1 diff -u -r1.1 field.api.php --- modules/field/field.api.php 7 Feb 2009 19:43:00 -0000 1.1 +++ modules/field/field.api.php 8 Feb 2009 21:52:09 -0000 @@ -17,11 +17,11 @@ * * name: The human-readable name of the type. * id key: The object property that contains the primary id for the - * object. Every object passed to the Field API must + * object. Every object passed to the Field API must * have this property and its value must be numeric. * revision key: The object property that contains the revision id * for the object, or NULL if the object type is not - * versioned. The Field API assumes that all revision ids are + * versioned. The Field API assumes that all revision ids are * unique across all instances of a type; this means, for example, * that every object's revision ids cannot be 0, 1, 2, ... * bundle key: The object property that contains the bundle name for @@ -31,7 +31,7 @@ * loaded fields for each object, reducing the cost of * field_attach_load(). * bundles: An array of all existing bundle names for this object - * type. TODO: Define format. TODO: I'm unclear why we need + * type. TODO: Define format. TODO: I'm unclear why we need * this. */ function hook_fieldable_info() { @@ -60,7 +60,7 @@ * @{ * Define field types, widget types, and display formatter types. * - * The bulk of the Field Types API are related to field types. A + * The bulk of the Field Types API are related to field types. A * field type represents a particular data storage type (integer, * string, date, etc.) that can be attached to a fieldable object. * hook_field_info() defines the basic properties of a field type, and @@ -68,10 +68,10 @@ * to perform field-type-specific actions. * * The Field Types API also defines widget types via - * hook_field_widget_info(). Widgets are Form API elements with - * additional processing capabilities. A field module can define + * hook_field_widget_info(). Widgets are Form API elements with + * additional processing capabilities. A field module can define * widgets that work with its own field types or with any other - * module's field types. Widget hooks are typically called by the + * module's field types. Widget hooks are typically called by the * Field Attach API when creating the field form elements during * field_attach_form(). * @@ -119,8 +119,8 @@ * A field structure. * @return * A Field API schema is an array of Schema API column - * specifications, keyed by field-independent column name. For - * example, a field may declare a column named 'value'. The SQL + * specifications, keyed by field-independent column name. For + * example, a field may declare a column named 'value'. The SQL * storage engine may create a table with a column named * _value_0, but the Field API schema column name is * still 'value'. @@ -214,7 +214,7 @@ * @param $items * $object->{$field['field_name']}, or an empty array if unset. * @param $form - * The form structure being validated. NOTE: This parameter will + * The form structure being validated. NOTE: This parameter will * become obsolete (see field_attach_validate()). */ function hook_field_validate($obj_type, $object, $field, $instance, $items, $form) { @@ -274,7 +274,7 @@ } /** - * Define custom delete behavior for this module's field types. This + * Define custom delete behavior for this module's field types. This * hook is invoked just before the data is deleted from field storage. * * @param $obj_type @@ -293,7 +293,7 @@ /** * Define custom delete_revision behavior for this module's field - * types. This hook is invoked just before the data is deleted from + * types. This hook is invoked just before the data is deleted from * field storage, and will only be called for fieldable types that are * versioned. * @@ -355,7 +355,7 @@ * provide it with valid $field information. * * Field API will set the weight, field name and delta values for each - * form element. If there are multiple values for this field, the + * form element. If there are multiple values for this field, the * Field API will call this function as many times as needed. * * @param $form @@ -393,7 +393,7 @@ */ /** - * Act on field_attach_form. This hook is invoked after the field module + * Act on field_attach_form. This hook is invoked after the field module * has performed the operation. * * See field_attach_form() for details and arguments. @@ -402,17 +402,17 @@ } /** - * Act on field_attach_load. This hook is invoked after the field module + * Act on field_attach_load. This hook is invoked after the field module * has performed the operation. * - * See field_attach_load() for details and arguments. TODO: + * See field_attach_load() for details and arguments. TODO: * Currently, this hook only accepts a single object a time. */ function hook_field_attach_load($obj_type, $object) { } /** - * Act on field_attach_validate. This hook is invoked after the field module + * Act on field_attach_validate. This hook is invoked after the field module * has performed the operation. * * See field_attach_validate() for details and arguments. @@ -421,7 +421,7 @@ } /** - * Act on field_attach_submit. This hook is invoked after the field module + * Act on field_attach_submit. This hook is invoked after the field module * has performed the operation. * * See field_attach_submit() for details and arguments. @@ -430,7 +430,7 @@ } /** - * Act on field_attach_presave. This hook is invoked after the field module + * Act on field_attach_presave. This hook is invoked after the field module * has performed the operation. * * See field_attach_presave() for details and arguments. @@ -439,7 +439,7 @@ } /** - * Act on field_attach_insert. This hook is invoked after the field module + * Act on field_attach_insert. This hook is invoked after the field module * has performed the operation. * * See field_attach_insert() for details and arguments. @@ -448,7 +448,7 @@ } /** - * Act on field_attach_update. This hook is invoked after the field module + * Act on field_attach_update. This hook is invoked after the field module * has performed the operation. * * See field_attach_update() for details and arguments. @@ -457,7 +457,7 @@ } /** - * Act on field_attach_delete. This hook is invoked after the field module + * Act on field_attach_delete. This hook is invoked after the field module * has performed the operation. * * See field_attach_delete() for details and arguments. @@ -466,7 +466,7 @@ } /** - * Act on field_attach_delete_revision. This hook is invoked after + * Act on field_attach_delete_revision. This hook is invoked after * the field module has performed the operation. * * See field_attach_delete_revision() for details and arguments. @@ -475,7 +475,7 @@ } /** - * Act on field_attach_view. This hook is invoked after the field module + * Act on field_attach_view. This hook is invoked after the field module * has performed the operation. * * @param $output @@ -491,7 +491,7 @@ } /** - * Act on field_attach_create_bundle. This hook is invoked after the + * Act on field_attach_create_bundle. This hook is invoked after the * field module has performed the operation. * * See field_attach_create_bundle() for details and arguments. @@ -500,7 +500,7 @@ } /** - * Act on field_attach_rename_bundle. This hook is invoked after the + * Act on field_attach_rename_bundle. This hook is invoked after the * field module has performed the operation. * * See field_attach_rename_bundle() for details and arguments. @@ -509,7 +509,7 @@ } /** - * Act on field_attach_delete_bundle. This hook is invoked after the field module + * Act on field_attach_delete_bundle. This hook is invoked after the field module * has performed the operation. * * See field_attach_delete_bundle() for details and arguments. @@ -580,7 +580,7 @@ * @param $obj_type * The entity type of object, such as 'node' or 'user'. * @param $object - * The object on which to operate. The revision to delete is + * The object on which to operate. The revision to delete is * indicated by the object's revision id property, as identified by * hook_fieldable_info() for $obj_type. */ @@ -650,7 +650,7 @@ */ /** - * Act on a field being created. This hook is invoked after the field + * Act on a field being created. This hook is invoked after the field * is created and so it cannot modify the field itself. * * TODO: Not implemented. @@ -662,7 +662,7 @@ } /** - * Act on a field instance being created. This hook is invoked after + * Act on a field instance being created. This hook is invoked after * the instance record is saved and so it cannot modify the instance * itself. * @@ -673,7 +673,7 @@ } /** - * Act on a field being deleted. This hook is invoked just before the + * Act on a field being deleted. This hook is invoked just before the * field is deleted. * * TODO: Not implemented. @@ -686,7 +686,7 @@ /** - * Act on a field instance being updated. This hook is invoked after + * Act on a field instance being updated. This hook is invoked after * the instance record is saved and so it cannot modify the instance * itself. * @@ -699,7 +699,7 @@ } /** - * Act on a field instance being deleted. This hook is invoked just + * Act on a field instance being deleted. This hook is invoked just * before the instance is deleted. * * TODO: Not implemented. Index: modules/field/field.module =================================================================== RCS file: /cvs/drupal/drupal/modules/field/field.module,v retrieving revision 1.2 diff -u -r1.2 field.module --- modules/field/field.module 5 Feb 2009 01:21:16 -0000 1.2 +++ modules/field/field.module 8 Feb 2009 21:52:11 -0000 @@ -1,5 +1,6 @@ array(), - ); -} - -/** * Implementation of hook_theme(). */ function field_theme() { Index: modules/field/field.form.inc =================================================================== RCS file: /cvs/drupal/drupal/modules/field/field.form.inc,v retrieving revision 1.2 diff -u -r1.2 field.form.inc --- modules/field/field.form.inc 5 Feb 2009 03:42:57 -0000 1.2 +++ modules/field/field.form.inc 8 Feb 2009 21:52:10 -0000 @@ -1,6 +1,11 @@ 1 || $field['cardinality'] == FIELD_CARDINALITY_UNLIMITED; - + $value = array(); foreach ($element['#value'][$field_key] as $key) { // Multiple (checkboxes) need the default value in the form of an array. @@ -151,7 +152,7 @@ '#options' => $options, '#default_value' => $value, ); - + // Set #element_validate in a way that it will not wipe out other // validation functions already set by other modules. if (empty($element['#element_validate'])) { @@ -194,7 +195,7 @@ '#options' => $options, '#default_value' => isset($element['#value'][$field_key]) ? $element['#value'][$field_key] : NULL, ); - + // Set #element_validate in a way that it will not wipe out other // validation functions already set by other modules. if (empty($element['#element_validate'])) { @@ -407,7 +408,7 @@ * make custom changes to the output. * * $element['#field_name'] contains the field name - * $element['#delta] is the position of this element in the group + * $element['#delta] is the position of this element in the group */ function theme_options_select($element) { return $element['#children']; Index: modules/field/modules/number/number.module =================================================================== RCS file: /cvs/drupal/drupal/modules/field/modules/number/number.module,v retrieving revision 1.2 diff -u -r1.2 number.module --- modules/field/modules/number/number.module 5 Feb 2009 03:42:57 -0000 1.2 +++ modules/field/modules/number/number.module 8 Feb 2009 21:52:12 -0000 @@ -243,7 +243,7 @@ * $field information. * * Field module will set the weight, field name and delta values - * for each form element. + * for each form element. * * If there are multiple values for this field, the Field module will * call this function as many times as needed. @@ -418,7 +418,7 @@ * Override this theme to make custom changes to the output. * * $element['#field_name'] contains the field name - * $element['#delta] is the position of this element in the group + * $element['#delta] is the position of this element in the group */ function theme_number($element) { return $element['#children']; Index: modules/field/modules/text/text.module =================================================================== RCS file: /cvs/drupal/drupal/modules/field/modules/text/text.module,v retrieving revision 1.2 diff -u -r1.2 text.module --- modules/field/modules/text/text.module 5 Feb 2009 03:42:57 -0000 1.2 +++ modules/field/modules/text/text.module 8 Feb 2009 21:52:12 -0000 @@ -251,7 +251,7 @@ * $field information. * * Field module will set the weight, field name and delta values - * for each form element. + * for each form element. * * If there are multiple values for this field, the field module will * call this function as many times as needed. @@ -389,7 +389,7 @@ * make custom changes to the output. * * $element['#field_name'] contains the field name - * $element['#delta] is the position of this element in the group + * $element['#delta] is the position of this element in the group */ function theme_text_textfield($element) { return $element['#children']; Index: modules/simpletest/tests/field_test.info =================================================================== RCS file: /cvs/drupal/drupal/modules/simpletest/tests/field_test.info,v retrieving revision 1.1 diff -u -r1.1 field_test.info --- modules/simpletest/tests/field_test.info 3 Feb 2009 17:30:13 -0000 1.1 +++ modules/simpletest/tests/field_test.info 8 Feb 2009 21:52:12 -0000 @@ -2,7 +2,7 @@ name = "Field API Test" description = "Support module for the Field API tests." core = 7.x -package = testing +package = Testing files[] = field_test.module files[] = field_test.install version = VERSION