';
foreach ($blocks as $block) {
Index: modules/field/field.api.php
===================================================================
RCS file: /cvs/drupal/drupal/modules/field/field.api.php,v
retrieving revision 1.61
diff -u -p -r1.61 field.api.php
--- modules/field/field.api.php 13 Jan 2010 04:37:03 -0000 1.61
+++ modules/field/field.api.php 15 Jan 2010 04:33:28 -0000
@@ -32,6 +32,7 @@
function hook_field_extra_fields() {
$extra = array();
+ // TODO: undefined variable $bundle
if ($type = node_type_get_type($bundle)) {
if ($type->has_title) {
$extra['title'] = array(
Index: modules/field/field.crud.inc
===================================================================
RCS file: /cvs/drupal/drupal/modules/field/field.crud.inc,v
retrieving revision 1.46
diff -u -p -r1.46 field.crud.inc
--- modules/field/field.crud.inc 13 Jan 2010 14:06:46 -0000 1.46
+++ modules/field/field.crud.inc 15 Jan 2010 04:33:28 -0000
@@ -1021,6 +1021,7 @@ function field_purge_data($obj_type, $ob
// Each field type's hook_field_delete() only expects to operate on a single
// field at a time, so we can use it as-is for purging.
$options = array('field_id' => $instance['field_id'], 'deleted' => TRUE);
+ $dummy = NULL;
_field_invoke('delete', $obj_type, $object, $dummy, $dummy, $options);
// Tell the field storage system to purge the data.
Index: modules/field/field.info.inc
===================================================================
RCS file: /cvs/drupal/drupal/modules/field/field.info.inc,v
retrieving revision 1.37
diff -u -p -r1.37 field.info.inc
--- modules/field/field.info.inc 13 Jan 2010 04:37:03 -0000 1.37
+++ modules/field/field.info.inc 15 Jan 2010 04:33:28 -0000
@@ -245,6 +245,7 @@ function _field_info_prepare_field($fiel
// Add storage details.
$details = (array) module_invoke($field['storage']['module'], 'field_storage_details', $field);
+ // TODO: undefined variable $instance
drupal_alter('field_storage_details', $details, $field, $instance);
$field['storage']['details'] = $details;
Index: modules/field/field.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/field/field.module,v
retrieving revision 1.61
diff -u -p -r1.61 field.module
--- modules/field/field.module 13 Jan 2010 05:40:03 -0000 1.61
+++ modules/field/field.module 15 Jan 2010 04:33:28 -0000
@@ -521,6 +521,7 @@ function field_format($obj_type, $object
$display['settings'] += field_info_formatter_settings($display['type']);
if ($display['type'] !== 'hidden') {
+ // TODO: undefined variable $formatter
$theme = $formatter['module'] . '_formatter_' . $display['type'];
$element = array(
Index: modules/field/modules/list/list.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/field/modules/list/list.module,v
retrieving revision 1.25
diff -u -p -r1.25 list.module
--- modules/field/modules/list/list.module 29 Dec 2009 19:43:31 -0000 1.25
+++ modules/field/modules/list/list.module 15 Jan 2010 04:33:28 -0000
@@ -344,6 +344,7 @@ function list_field_formatter_view($obje
}
else {
// If no match was found in allowed values, fall back to the key.
+ // TODO: undefined variable $value
$output = field_filter_xss($value);
}
$element[$delta] = array('#markup' => $output);
Index: modules/field/tests/field_test.storage.inc
===================================================================
RCS file: /cvs/drupal/drupal/modules/field/tests/field_test.storage.inc,v
retrieving revision 1.2
diff -u -p -r1.2 field_test.storage.inc
--- modules/field/tests/field_test.storage.inc 13 Jan 2010 04:37:03 -0000 1.2
+++ modules/field/tests/field_test.storage.inc 15 Jan 2010 04:33:28 -0000
@@ -463,6 +463,7 @@ function field_test_field_attach_delete_
$field_data = &$data[$field['id']];
foreach (array('current', 'revisions') as $sub_table) {
foreach ($field_data[$sub_table] as &$row) {
+ // TODO: undefined variable $bundle_old
if ($row->bundle == $bundle_old) {
$row->deleted = TRUE;
}
Index: modules/locale/locale.test
===================================================================
RCS file: /cvs/drupal/drupal/modules/locale/locale.test,v
retrieving revision 1.60
diff -u -p -r1.60 locale.test
--- modules/locale/locale.test 10 Jan 2010 22:56:51 -0000 1.60
+++ modules/locale/locale.test 15 Jan 2010 04:33:28 -0000
@@ -1534,7 +1534,7 @@ class UILanguageNegotiationTest extends
$language_domain = 'example.cn';
// Setup the site languages by installing two languages.
- require_once('includes/locale.inc');
+ require_once DRUPAL_ROOT . '/includes/locale.inc';
locale_add_language($language_browser_fallback);
locale_add_language($language);
Index: modules/node/node.api.php
===================================================================
RCS file: /cvs/drupal/drupal/modules/node/node.api.php,v
retrieving revision 1.57
diff -u -p -r1.57 node.api.php
--- modules/node/node.api.php 13 Jan 2010 23:30:43 -0000 1.57
+++ modules/node/node.api.php 15 Jan 2010 04:33:28 -0000
@@ -565,6 +565,7 @@ function hook_node_validate($node, $form
*/
function hook_node_view($node, $view_mode) {
$node->content['my_additional_field'] = array(
+ // TODO: undefined variable $additional_field
'#value' => $additional_field,
'#weight' => 10,
'#theme' => 'mymodule_my_additional_field',
@@ -792,6 +793,7 @@ function hook_delete($node) {
* The node that is about to be shown on the add/edit form.
*/
function hook_prepare($node) {
+ // TODO: undefined variable $field_name
if ($file = file_check_upload($field_name)) {
$file = file_save_upload($field_name, _image_filename($file->filename, NULL, TRUE));
if ($file) {
Index: modules/openid/openid.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/openid/openid.module,v
retrieving revision 1.70
diff -u -p -r1.70 openid.module
--- modules/openid/openid.module 11 Jan 2010 16:25:16 -0000 1.70
+++ modules/openid/openid.module 15 Jan 2010 04:33:28 -0000
@@ -421,10 +421,11 @@ function openid_authentication($response
$identity = $response['openid.claimed_id'];
$account = user_external_load($identity);
+ $form_state = array();
if (isset($account->uid)) {
if (!variable_get('user_email_verification', TRUE) || $account->login) {
// Check if user is blocked.
- user_login_name_validate(array(), $state, (array)$account);
+ user_login_name_validate(array(), $form_state, (array)$account);
if (!form_get_errors()) {
// Load global $user and perform final login tasks.
$form_state['uid'] = $account->uid;
Index: modules/overlay/overlay.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/overlay/overlay.module,v
retrieving revision 1.7
diff -u -p -r1.7 overlay.module
--- modules/overlay/overlay.module 14 Jan 2010 03:25:43 -0000 1.7
+++ modules/overlay/overlay.module 15 Jan 2010 04:33:28 -0000
@@ -536,6 +536,7 @@ function overlay_close_dialog($redirect
'overlayChild' => array(
'closeOverlay' => TRUE,
'statusMessages' => theme('status_messages'),
+ // TODO: undefined variable $args
'args' => $args,
'redirect' => url($redirect),
),
Index: modules/poll/poll.tokens.inc
===================================================================
RCS file: /cvs/drupal/drupal/modules/poll/poll.tokens.inc,v
retrieving revision 1.4
diff -u -p -r1.4 poll.tokens.inc
--- modules/poll/poll.tokens.inc 7 Jan 2010 20:55:49 -0000 1.4
+++ modules/poll/poll.tokens.inc 15 Jan 2010 04:33:28 -0000
@@ -81,6 +81,7 @@ function poll_tokens($type, $tokens, arr
break;
case 'poll-duration':
+ // TODO: undefined variable $language_code
$replacements[$original] = format_interval($node->runtime, 1, $language_code);
break;
}
Index: modules/search/search.api.php
===================================================================
RCS file: /cvs/drupal/drupal/modules/search/search.api.php,v
retrieving revision 1.22
diff -u -p -r1.22 search.api.php
--- modules/search/search.api.php 9 Jan 2010 21:54:01 -0000 1.22
+++ modules/search/search.api.php 15 Jan 2010 04:33:28 -0000
@@ -231,6 +231,7 @@ function hook_search_page($results) {
$output = '
';
foreach ($results as $entry) {
+ // TODO: undefined variable $type
$output .= theme('search_result', $entry, $type);
}
$output .= '
';
Index: modules/search/search.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/search/search.module,v
retrieving revision 1.335
diff -u -p -r1.335 search.module
--- modules/search/search.module 10 Jan 2010 21:46:16 -0000 1.335
+++ modules/search/search.module 15 Jan 2010 04:33:28 -0000
@@ -600,6 +600,7 @@ function search_index($sid, $type, $text
if ($link) {
// Check to see if the node link text is its URL. If so, we use the target node title instead.
if (preg_match('!^https?://!i', $value)) {
+ // TODO: undefined variable $linktitle
$value = $linktitle;
}
}
@@ -617,6 +618,7 @@ function search_index($sid, $type, $text
// Links score mainly for the target.
if ($link) {
+ // TODO: undefined variable $linknid
if (!isset($results[$linknid])) {
$results[$linknid] = array();
}
Index: modules/simpletest/tests/filetransfer.test
===================================================================
RCS file: /cvs/drupal/drupal/modules/simpletest/tests/filetransfer.test,v
retrieving revision 1.6
diff -u -p -r1.6 filetransfer.test
--- modules/simpletest/tests/filetransfer.test 10 Nov 2009 17:27:53 -0000 1.6
+++ modules/simpletest/tests/filetransfer.test 15 Jan 2010 04:33:28 -0000
@@ -131,6 +131,7 @@ class TestFileTransfer extends FileTrans
}
function removeFileJailed($destination) {
+ // TODO: undefined variable $item
if (!ftp_delete($this->connection, $item)) {
throw new FileTransferException('Unable to remove to file @file.', NULL, array('@file' => $item));
}
Index: modules/simpletest/tests/graph.test
===================================================================
RCS file: /cvs/drupal/drupal/modules/simpletest/tests/graph.test,v
retrieving revision 1.6
diff -u -p -r1.6 graph.test
--- modules/simpletest/tests/graph.test 13 Jul 2009 21:51:41 -0000 1.6
+++ modules/simpletest/tests/graph.test 15 Jan 2010 04:33:29 -0000
@@ -23,7 +23,7 @@ class GraphUnitTest extends DrupalUnitTe
*/
function testDepthFirstSearch() {
// Provoke the inclusion of graph.inc.
- require_once 'includes/graph.inc';
+ require_once DRUPAL_ROOT . '/includes/graph.inc';
// The sample graph used is:
// 1 --> 2 --> 3 5 ---> 6
Index: modules/simpletest/tests/https.php
===================================================================
RCS file: /cvs/drupal/drupal/modules/simpletest/tests/https.php,v
retrieving revision 1.2
diff -u -p -r1.2 https.php
--- modules/simpletest/tests/https.php 4 Nov 2009 05:05:52 -0000 1.2
+++ modules/simpletest/tests/https.php 15 Jan 2010 04:33:29 -0000
@@ -25,4 +25,4 @@ foreach ($_SERVER as $key => $value) {
$_SERVER[$key] = str_replace('http://', 'https://', $_SERVER[$key]);
}
-require_once 'index.php';
+require_once DRUPAL_ROOT . '/index.php';
Index: modules/system/system.api.php
===================================================================
RCS file: /cvs/drupal/drupal/modules/system/system.api.php,v
retrieving revision 1.120
diff -u -p -r1.120 system.api.php
--- modules/system/system.api.php 13 Jan 2010 06:26:49 -0000 1.120
+++ modules/system/system.api.php 15 Jan 2010 04:33:29 -0000
@@ -1671,6 +1671,7 @@ function hook_file_references($file) {
$file_used = (bool) db_query_range('SELECT 1 FROM {upload} WHERE fid = :fid', 0, 1, array(':fid' => $file->fid))->fetchField();
if ($file_used) {
// Return the name of the module and how many references it has to the file.
+ // TODO: undefined variable $count
return array('upload' => $count);
}
}
@@ -2154,7 +2155,7 @@ function hook_update_N(&$sandbox) {
// We'll -1 to disregard the uid 0...
$sandbox['max'] = db_query('SELECT COUNT(DISTINCT uid) FROM {users}')->fetchField() - 1;
}
- db_select('users', 'u')
+ $users = db_select('users', 'u')
->fields('u', array('uid', 'name'))
->condition('uid', $sandbox['current_uid'], '>')
->range(0, 3)
Index: modules/system/system.install
===================================================================
RCS file: /cvs/drupal/drupal/modules/system/system.install,v
retrieving revision 1.442
diff -u -p -r1.442 system.install
--- modules/system/system.install 13 Jan 2010 06:15:39 -0000 1.442
+++ modules/system/system.install 15 Jan 2010 04:33:29 -0000
@@ -1565,7 +1565,7 @@ function system_update_6050() {
* Create a signature_format column.
*/
function system_update_6051() {
-
+ $ret = array();
if (!db_column_exists('users', 'signature_format')) {
// Set future text formats to FILTER_FORMAT_DEFAULT to ensure a safe default
Index: modules/system/system.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/system/system.module,v
retrieving revision 1.876
diff -u -p -r1.876 system.module
--- modules/system/system.module 13 Jan 2010 23:03:31 -0000 1.876
+++ modules/system/system.module 15 Jan 2010 04:33:29 -0000
@@ -2871,6 +2871,7 @@ function system_send_email_action($objec
$recipient = token_replace($context['recipient'], $context);
+ // TODO: undefined variable $account
$language = user_preferred_language($account);
$params = array('context' => $context);
@@ -3405,6 +3406,7 @@ function _system_date_formats_build() {
// If another module already set this format, merge in the new settings.
if (isset($date_formats[$module_format['type']][$module_format['format']])) {
+ // TODO: undefined variable $format
$date_formats[$module_format['type']][$module_format['format']] = array_merge_recursive($date_formats[$module_format['type']][$module_format['format']], $format);
}
else {
Index: modules/system/system.tar.inc
===================================================================
RCS file: /cvs/drupal/drupal/modules/system/system.tar.inc,v
retrieving revision 1.3
diff -u -p -r1.3 system.tar.inc
--- modules/system/system.tar.inc 9 Jan 2010 23:03:21 -0000 1.3
+++ modules/system/system.tar.inc 15 Jan 2010 04:33:30 -0000
@@ -1407,6 +1407,7 @@ class Archive_Tar
While (strlen($v_binary_data = $this->_readBlock()) != 0)
{
+ $v_header = array();
if (!$this->_readHeader($v_binary_data, $v_header))
return NULL;
@@ -1490,6 +1491,7 @@ class Archive_Tar
{
$v_extract_file = FALSE;
$v_extraction_stopped = 0;
+ $v_header = array();
if (!$this->_readHeader($v_binary_data, $v_header))
return false;
Index: modules/system/system.updater.inc
===================================================================
RCS file: /cvs/drupal/drupal/modules/system/system.updater.inc,v
retrieving revision 1.4
diff -u -p -r1.4 system.updater.inc
--- modules/system/system.updater.inc 14 Jan 2010 06:39:37 -0000 1.4
+++ modules/system/system.updater.inc 15 Jan 2010 04:33:30 -0000
@@ -53,9 +53,11 @@ class ModuleUpdater extends Updater impl
* Return available database schema updates one a new version is installed.
*/
public function getSchemaUpdates() {
- require_once './includes/install.inc';
- require_once './includes/update.inc';
+ require_once DRUPAL_ROOT . '/includes/install.inc';
+ require_once DRUPAL_ROOT . '/includes/update.inc';
+ // TODO: undefined function _update_get_project_type()
+ // TODO: undefined variable $project
if (_update_get_project_type($project) != 'module') {
return array();
}
Index: modules/update/update.manager.inc
===================================================================
RCS file: /cvs/drupal/drupal/modules/update/update.manager.inc,v
retrieving revision 1.15
diff -u -p -r1.15 update.manager.inc
--- modules/update/update.manager.inc 14 Jan 2010 18:38:02 -0000 1.15
+++ modules/update/update.manager.inc 15 Jan 2010 04:33:30 -0000
@@ -685,6 +685,7 @@ function update_manager_archive_extract(
function update_manager_archive_verify($project, $archive_file, $directory) {
$failures = module_invoke_all('verify_update_archive', $project, $archive_file, $directory);
if (!empty($failures)) {
+ // TODO: undefined variable $file
throw new Exception(t('Unable to extract %file', array('%file' => $file)));
}
}
Index: modules/user/user.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/user/user.module,v
retrieving revision 1.1112
diff -u -p -r1.1112 user.module
--- modules/user/user.module 14 Jan 2010 19:21:55 -0000 1.1112
+++ modules/user/user.module 15 Jan 2010 04:33:30 -0000
@@ -808,6 +808,7 @@ function user_file_references($file) {
$file_used = (bool) db_query_range('SELECT 1 FROM {users} WHERE picture = :fid', 0, 1, array(':fid' => $file->fid))->fetchField();
if ($file_used) {
// Return the name of the module and how many references it has to the file.
+ // TODO: undefined variable $count
return array('user' => $count);
}
}
Index: scripts/run-tests.sh
===================================================================
RCS file: /cvs/drupal/drupal/scripts/run-tests.sh,v
retrieving revision 1.39
diff -u -p -r1.39 run-tests.sh
--- scripts/run-tests.sh 9 Jan 2010 23:03:22 -0000 1.39
+++ scripts/run-tests.sh 15 Jan 2010 04:33:30 -0000
@@ -351,6 +351,7 @@ function simpletest_script_execute_batch
// Check if some children finished.
foreach ($children as $cid => $child) {
+ $status = 0;
if (pcntl_waitpid($child['pid'], $status, WUNTRACED | WNOHANG)) {
// This particular child exited.
unset($children[$cid]);