diff --git a/core/lib/Drupal/Component/PhpStorage/FileStorage.php b/core/lib/Drupal/Component/PhpStorage/FileStorage.php
index 1e6a2b3..474429f 100644
--- a/core/lib/Drupal/Component/PhpStorage/FileStorage.php
+++ b/core/lib/Drupal/Component/PhpStorage/FileStorage.php
@@ -120,9 +120,6 @@ public static function htaccessLines($private = TRUE) {
* The directory path.
* @param int $mode
* The mode, permissions, the directory should have.
- *
- * @return bool
- * TRUE if the directory exists or has been created, FALSE otherwise.
*/
protected function ensureDirectory($directory, $mode = 0777) {
if ($this->createDirectory($directory, $mode)) {
diff --git a/core/lib/Drupal/Core/Config/ConfigBase.php b/core/lib/Drupal/Core/Config/ConfigBase.php
index 6dfa962..ae722f4 100644
--- a/core/lib/Drupal/Core/Config/ConfigBase.php
+++ b/core/lib/Drupal/Core/Config/ConfigBase.php
@@ -197,11 +197,12 @@ public function set($key, $value) {
/**
* Validates all keys in a passed in config array structure.
*
+ * The function does not return anything but will raise an exception
+ * if there are issues with keys passed.
+ *
* @param array $data
* Configuration array structure.
*
- * @return null
- *
* @throws \Drupal\Core\Config\ConfigValueException
* If any key in $data in any depth contains a dot.
*/
diff --git a/core/lib/Drupal/Core/Config/ImmutableConfig.php b/core/lib/Drupal/Core/Config/ImmutableConfig.php
index b0d4e8d..d6916bb 100644
--- a/core/lib/Drupal/Core/Config/ImmutableConfig.php
+++ b/core/lib/Drupal/Core/Config/ImmutableConfig.php
@@ -49,6 +49,7 @@ public function save($has_trusted_data = FALSE) {
*/
public function delete() {
throw new ImmutableConfigException("Can not delete immutable configuration {$this->getName()}. Use \\Drupal\\Core\\Config\\ConfigFactoryInterface::getEditable() to retrieve a mutable configuration object");
+ return $this;
}
}
diff --git a/core/lib/Drupal/Core/Config/StorableConfigBase.php b/core/lib/Drupal/Core/Config/StorableConfigBase.php
index 40a25ef..701d903 100644
--- a/core/lib/Drupal/Core/Config/StorableConfigBase.php
+++ b/core/lib/Drupal/Core/Config/StorableConfigBase.php
@@ -139,13 +139,14 @@ protected function getSchemaWrapper() {
/**
* Validate the values are allowed data types.
*
+ * The function does not return anything but will raise an exception if
+ * the value is unsupported in the configuration.
+ *
* @param string $key
* A string that maps to a key within the configuration data.
* @param string $value
* Value to associate with the key.
*
- * @return null
- *
* @throws \Drupal\Core\Config\UnsupportedDataTypeConfigException
* If the value is unsupported in configuration.
*/
diff --git a/core/lib/Drupal/Core/Database/Connection.php b/core/lib/Drupal/Core/Database/Connection.php
index 2002e9e..4ee00e7 100644
--- a/core/lib/Drupal/Core/Database/Connection.php
+++ b/core/lib/Drupal/Core/Database/Connection.php
@@ -173,7 +173,9 @@ public function __construct(\PDO $connection, array $connection_options) {
* @return \PDO
* A \PDO object.
*/
- public static function open(array &$connection_options = array()) { }
+ public static function open(array &$connection_options = array()) {
+ return $this->connection;
+ }
/**
* Destroys this Connection object.
diff --git a/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorageSchema.php b/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorageSchema.php
index d76c132..8a35090 100644
--- a/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorageSchema.php
+++ b/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorageSchema.php
@@ -995,9 +995,6 @@ protected function addTableDefaults(&$schema) {
* The entity type.
* @param array $schema
* The table schema, passed by reference.
- *
- * @return array
- * A partial schema array for the base table.
*/
protected function processBaseTable(ContentEntityTypeInterface $entity_type, array &$schema) {
$this->processIdentifierSchema($schema, $entity_type->getKey('id'));
@@ -1010,9 +1007,6 @@ protected function processBaseTable(ContentEntityTypeInterface $entity_type, arr
* The entity type.
* @param array $schema
* The table schema, passed by reference.
- *
- * @return array
- * A partial schema array for the base table.
*/
protected function processRevisionTable(ContentEntityTypeInterface $entity_type, array &$schema) {
$this->processIdentifierSchema($schema, $entity_type->getKey('revision'));
@@ -1025,9 +1019,6 @@ protected function processRevisionTable(ContentEntityTypeInterface $entity_type,
* The entity type.
* @param array $schema
* The table schema, passed by reference.
- *
- * @return array
- * A partial schema array for the base table.
*/
protected function processDataTable(ContentEntityTypeInterface $entity_type, array &$schema) {
// Marking the respective fields as NOT NULL makes the indexes more
@@ -1042,9 +1033,6 @@ protected function processDataTable(ContentEntityTypeInterface $entity_type, arr
* The entity type.
* @param array $schema
* The table schema, passed by reference.
- *
- * @return array
- * A partial schema array for the base table.
*/
protected function processRevisionDataTable(ContentEntityTypeInterface $entity_type, array &$schema) {
// Marking the respective fields as NOT NULL makes the indexes more
diff --git a/core/lib/Drupal/Core/FileTransfer/FileTransfer.php b/core/lib/Drupal/Core/FileTransfer/FileTransfer.php
index dbe2559..495d74f 100644
--- a/core/lib/Drupal/Core/FileTransfer/FileTransfer.php
+++ b/core/lib/Drupal/Core/FileTransfer/FileTransfer.php
@@ -75,6 +75,7 @@ function __construct($jail) {
*/
static function factory($jail, $settings) {
throw new FileTransferException('FileTransfer::factory() static method not overridden by FileTransfer subclass.');
+ return new stdClass();
}
/**
diff --git a/core/lib/Drupal/Core/Menu/DefaultMenuLinkTreeManipulators.php b/core/lib/Drupal/Core/Menu/DefaultMenuLinkTreeManipulators.php
index 43c4468..c20e399 100644
--- a/core/lib/Drupal/Core/Menu/DefaultMenuLinkTreeManipulators.php
+++ b/core/lib/Drupal/Core/Menu/DefaultMenuLinkTreeManipulators.php
@@ -168,9 +168,6 @@ public function checkNodeAccess(array $tree) {
* The menu link tree to manipulate.
* @param array $node_links
* Stores references to menu link elements to effectively set access.
- *
- * @return \Drupal\Core\Menu\MenuLinkTreeElement[]
- * The manipulated menu link tree.
*/
protected function collectNodeLinks(array &$tree, array &$node_links) {
foreach ($tree as $key => &$element) {
diff --git a/core/modules/locale/locale.compare.inc b/core/modules/locale/locale.compare.inc
index e24490c..3f80762 100644
--- a/core/modules/locale/locale.compare.inc
+++ b/core/modules/locale/locale.compare.inc
@@ -176,9 +176,6 @@ function locale_translation_default_translation_server() {
* @param string $langcodes
* Array of language codes. Defaults to all translatable languages.
*
- * @return array
- * Available sources indexed by project and language.
- *
* @todo Return batch or NULL.
*/
function locale_translation_check_projects($projects = array(), $langcodes = array()) {
diff --git a/core/modules/locale/locale.module b/core/modules/locale/locale.module
index aecad6c..71f8b98 100644
--- a/core/modules/locale/locale.module
+++ b/core/modules/locale/locale.module
@@ -1124,9 +1124,6 @@ function _locale_strip_quotes($string) {
* @param string $filepath
* File name to parse.
*
- * @return array
- * Array of string objects to update indexed by context and source.
- *
* @throws Exception
* If a non-local file is attempted to be parsed.
*/
diff --git a/core/modules/locale/src/PluralFormula.php b/core/modules/locale/src/PluralFormula.php
index 827cc88..98110ef 100644
--- a/core/modules/locale/src/PluralFormula.php
+++ b/core/modules/locale/src/PluralFormula.php
@@ -91,8 +91,6 @@ public function getFormula($langcode) {
/**
* Loads the formulae and stores them on the PluralFormula object if not set.
- *
- * @return []
*/
protected function loadFormulae() {
if (!isset($this->formulae)) {
diff --git a/core/modules/menu_link_content/src/Plugin/Menu/MenuLinkContent.php b/core/modules/menu_link_content/src/Plugin/Menu/MenuLinkContent.php
index fea0211..fb0256b 100644
--- a/core/modules/menu_link_content/src/Plugin/Menu/MenuLinkContent.php
+++ b/core/modules/menu_link_content/src/Plugin/Menu/MenuLinkContent.php
@@ -198,7 +198,7 @@ public function getTranslateRoute() {
* The menu link ID.
*/
protected function getUuid() {
- $this->getDerivativeId();
+ return $this->getDerivativeId();
}
/**
diff --git a/core/modules/node/node.module b/core/modules/node/node.module
index fa9d3e9..9d3902a 100644
--- a/core/modules/node/node.module
+++ b/core/modules/node/node.module
@@ -470,7 +470,7 @@ function node_revision_load($vid = NULL) {
* TRUE if the revision deletion was successful; otherwise, FALSE.
*/
function node_revision_delete($revision_id) {
- entity_revision_delete('node', $revision_id);
+ return entity_revision_delete('node', $revision_id);
}
/**
diff --git a/core/modules/rest/src/Routing/ResourceRoutes.php b/core/modules/rest/src/Routing/ResourceRoutes.php
index e88f18b..1a05bcc 100644
--- a/core/modules/rest/src/Routing/ResourceRoutes.php
+++ b/core/modules/rest/src/Routing/ResourceRoutes.php
@@ -55,7 +55,6 @@ public function __construct(ResourcePluginManager $manager, ConfigFactoryInterfa
*
* @param \Symfony\Component\Routing\RouteCollection $collection
* The route collection for adding routes.
- * @return array
*/
protected function alterRoutes(RouteCollection $collection) {
$routes = array();
diff --git a/core/modules/views/tests/modules/views_test_data/src/Plugin/views/filter/FilterTest.php b/core/modules/views/tests/modules/views_test_data/src/Plugin/views/filter/FilterTest.php
index 4d6cd29..91e18e9 100644
--- a/core/modules/views/tests/modules/views_test_data/src/Plugin/views/filter/FilterTest.php
+++ b/core/modules/views/tests/modules/views_test_data/src/Plugin/views/filter/FilterTest.php
@@ -24,8 +24,6 @@ protected function defineOptions() {
/**
* Overrides Drupal\views\Plugin\views\row\RowPluginBase::buildOptionsForm().
- *
- * @return array
*/
public function buildOptionsForm(&$form, FormStateInterface $form_state) {
parent::buildOptionsForm($form, $form_state);
diff --git a/core/modules/views/tests/src/Unit/ViewsDataTest.php b/core/modules/views/tests/src/Unit/ViewsDataTest.php
index 21ef9c3..b229d8a 100644
--- a/core/modules/views/tests/src/Unit/ViewsDataTest.php
+++ b/core/modules/views/tests/src/Unit/ViewsDataTest.php
@@ -128,8 +128,6 @@ protected function viewsDataWithProvider() {
/**
* Mocks the basic module handler used for the test.
- *
- * @return \Drupal\Core\Extension\ModuleHandlerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected function setupMockedModuleHandler() {
$views_data = $this->viewsData();
diff --git a/core/phpcs.xml.dist b/core/phpcs.xml.dist
index 8619917..7e579bf 100644
--- a/core/phpcs.xml.dist
+++ b/core/phpcs.xml.dist
@@ -45,7 +45,6 @@
-
diff --git a/core/tests/Drupal/Tests/Core/Image/ImageTest.php b/core/tests/Drupal/Tests/Core/Image/ImageTest.php
index 844dadb..ef0c8f8 100644
--- a/core/tests/Drupal/Tests/Core/Image/ImageTest.php
+++ b/core/tests/Drupal/Tests/Core/Image/ImageTest.php
@@ -93,9 +93,6 @@ protected function getToolkitOperationMock($class_name, ImageToolkitInterface $t
* to TRUE.
* @param array $stubs
* (optional) Array containing toolkit methods to be replaced with stubs.
- *
- * @return \Drupal\Core\Image\Image
- * An image object.
*/
protected function getTestImage($load_expected = TRUE, array $stubs = array()) {
if (!$load_expected && !in_array('load', $stubs)) {
@@ -121,9 +118,6 @@ protected function getTestImage($load_expected = TRUE, array $stubs = array()) {
*
* @param string $class_name
* The name of the GD toolkit operation class to be mocked.
- *
- * @return \Drupal\Core\Image\Image
- * An image object.
*/
protected function getTestImageForOperation($class_name) {
$this->toolkit = $this->getToolkitMock(array('getToolkitOperation'));
diff --git a/core/tests/Drupal/Tests/Core/Utility/LinkGeneratorTest.php b/core/tests/Drupal/Tests/Core/Utility/LinkGeneratorTest.php
index 1299b3f..3dc7185 100644
--- a/core/tests/Drupal/Tests/Core/Utility/LinkGeneratorTest.php
+++ b/core/tests/Drupal/Tests/Core/Utility/LinkGeneratorTest.php
@@ -554,9 +554,6 @@ public static function assertLink(array $properties, MarkupInterface $html, $cou
* The XPath query to execute.
* @param string $html
* The HTML snippet to check.
- *
- * @return int
- * The number of results that are found.
*/
protected function assertNoXPathResults($query, $html) {
$document = new \DOMDocument();