? coding-standards-299778-D7-UNSTABLE2.patch2 ? modules/syndication Index: install.php =================================================================== RCS file: /cvs/drupal/drupal/install.php,v retrieving revision 1.135 diff -u -p -r1.135 install.php --- install.php 11 Oct 2008 18:20:53 -0000 1.135 +++ install.php 12 Oct 2008 05:39:53 -0000 @@ -669,7 +669,7 @@ function install_tasks($profile, $task) // to the same address, until the batch finished callback is invoked // and the task advances to 'locale-initial-import'. if ($task == 'profile-install-batch') { - include_once DRUPAL_ROOT .'/includes/batch.inc'; + include_once DRUPAL_ROOT . '/includes/batch.inc'; $output = _batch_page(); } @@ -921,7 +921,7 @@ function install_check_requirements($pro 'title' => st('Settings file'), 'value' => st('The settings file does not exist.'), 'severity' => REQUIREMENT_ERROR, - 'description' => st('The @drupal installer requires that you create a settings file as part of the installation process. Copy the %default_file file to %file. More details about installing Drupal are available in INSTALL.txt.', array('@drupal' => drupal_install_profile_name(), '%file' => $file, '%default_file' => $conf_path .'/default.settings.php')), + 'description' => st('The @drupal installer requires that you create a settings file as part of the installation process. Copy the %default_file file to %file. More details about installing Drupal are available in INSTALL.txt.', array('@drupal' => drupal_install_profile_name(), '%file' => $file, '%default_file' => $conf_path . '/default.settings.php')), ); } elseif ($exists) { @@ -940,7 +940,7 @@ function install_check_requirements($pro } elseif ($writable) { $requirements['settings file'] = array( - 'title' => st('Settings file'), + 'title' => st('Settings file'), 'value' => st('Settings file is writable.'), ); } Index: update.php =================================================================== RCS file: /cvs/drupal/drupal/update.php,v retrieving revision 1.263 diff -u -p -r1.263 update.php --- update.php 12 Oct 2008 04:30:05 -0000 1.263 +++ update.php 12 Oct 2008 05:39:54 -0000 @@ -236,7 +236,7 @@ function update_script_selection_form() foreach (array_keys($updates) as $update) { if ($update > $schema_version) { // The description for an update comes from its Doxygen. - $func = new ReflectionFunction($module. '_update_'. $update); + $func = new ReflectionFunction($module . '_update_' . $update); $description = str_replace(array("\n", '*', '/'), '', $func->getDocComment()); $pending[] = "$update - $description"; if (!isset($default)) { @@ -329,7 +329,7 @@ function update_finished($success, $resu $_SESSION['update_results'] = $results; $_SESSION['update_success'] = $success; $_SESSION['updates_remaining'] = $operations; - + // Now that the update is done, we can disable site maintenance if it was // previously turned off. if (isset($_SESSION['site_offline']) && $_SESSION['site_offline'] == FALSE) { Index: includes/bootstrap.inc =================================================================== RCS file: /cvs/drupal/drupal/includes/bootstrap.inc,v retrieving revision 1.233 diff -u -p -r1.233 bootstrap.inc --- includes/bootstrap.inc 12 Oct 2008 02:47:50 -0000 1.233 +++ includes/bootstrap.inc 12 Oct 2008 05:39:54 -0000 @@ -1563,7 +1563,7 @@ function registry_load_path_files($retur $menu = menu_get_item(); $cache = cache_get('registry:' . $menu['path'], 'cache_registry'); if (!empty($cache->data)) { - foreach(explode(';', $cache->data) as $file) { + foreach (explode(';', $cache->data) as $file) { require_once DRUPAL_ROOT . '/' . $file; $file_cache_data[] = $file; } Index: includes/common.inc =================================================================== RCS file: /cvs/drupal/drupal/includes/common.inc,v retrieving revision 1.806 diff -u -p -r1.806 common.inc --- includes/common.inc 12 Oct 2008 04:30:05 -0000 1.806 +++ includes/common.inc 12 Oct 2008 05:39:57 -0000 @@ -2704,7 +2704,7 @@ function drupal_system_listing($mask, $d /** * Hands off structured Drupal arrays to type-specific *_alter implementations. - * + * * This dispatch function hands off structured Drupal arrays to type-specific * *_alter implementations. It ensures a consistent interface for all altering * operations. @@ -3340,7 +3340,7 @@ function drupal_write_record($table, &$o $query .= $field . ' = ' . $placeholders[$id]; } - foreach ($update as $key){ + foreach ($update as $key) { $conditions[] = "$key = " . db_type_placeholder($schema['fields'][$key]['type']); $values[] = $object->$key; } Index: includes/file.inc =================================================================== RCS file: /cvs/drupal/drupal/includes/file.inc,v retrieving revision 1.139 diff -u -p -r1.139 file.inc --- includes/file.inc 12 Oct 2008 04:30:05 -0000 1.139 +++ includes/file.inc 12 Oct 2008 05:39:59 -0000 @@ -1779,7 +1779,7 @@ function file_get_mimetype($filename, $m )); } foreach ($mapping as $ext_preg => $mime_match) { - if (preg_match('!\.('. $ext_preg .')$!i', $filename)) { + if (preg_match('!\.(' . $ext_preg . ')$!i', $filename)) { return $mime_match; } } Index: includes/form.inc =================================================================== RCS file: /cvs/drupal/drupal/includes/form.inc,v retrieving revision 1.294 diff -u -p -r1.294 form.inc --- includes/form.inc 12 Oct 2008 04:30:05 -0000 1.294 +++ includes/form.inc 12 Oct 2008 05:40:01 -0000 @@ -1761,7 +1761,7 @@ function form_process_radios($element) { /** * Add input format selector to text elements with the #input_format property. * - * The #input_format property should be the ID of an input format, found in + * The #input_format property should be the ID of an input format, found in * {filter_formats}.format, which gets passed to filter_form(). * * If the property #input_format is set, the form element will be expanded into @@ -1777,7 +1777,7 @@ function form_process_radios($element) { * '#type' => 'textarea', * '#title' => t('Body'), * '#input_format' => isset($node->format) ? $node->format : FILTER_FORMAT_DEFAULT, - * ); + * ); * @endcode * * Becomes: Index: includes/install.inc =================================================================== RCS file: /cvs/drupal/drupal/includes/install.inc,v retrieving revision 1.73 diff -u -p -r1.73 install.inc --- includes/install.inc 11 Oct 2008 22:46:21 -0000 1.73 +++ includes/install.inc 12 Oct 2008 05:40:01 -0000 @@ -88,7 +88,7 @@ function drupal_load_updates() { * @param $module * A module name. * @return - * If the module has updates, an array of available updates sorted by version. + * If the module has updates, an array of available updates sorted by version. * Otherwise, FALSE. */ function drupal_get_schema_versions($module) { @@ -105,10 +105,10 @@ function drupal_get_schema_versions($mod if (count($updates) == 0) { return FALSE; } - + // Make sure updates are run in numeric order, not in definition order. sort($updates, SORT_NUMERIC); - + return $updates; } @@ -231,7 +231,7 @@ function drupal_detect_database_types() unset($databases['mysql']); $databases = array('mysql' => $mysql_database) + $databases; } - + return $databases; } @@ -409,7 +409,7 @@ function drupal_rewrite_settings($settin function drupal_get_install_files($module_list = array()) { $installs = array(); foreach ($module_list as $module) { - $installs = array_merge($installs, drupal_system_listing('/'. $module . '.install$/', 'modules')); + $installs = array_merge($installs, drupal_system_listing('/' . $module . '.install$/', 'modules')); } return $installs; } @@ -465,7 +465,7 @@ function drupal_verify_profile($profile, $missing_modules = array_diff($module_list, $present_modules); $requirements = array(); - + if (count($missing_modules)) { $modules = array(); foreach ($missing_modules as $module) { @@ -543,7 +543,7 @@ function _drupal_install_module($module) */ function drupal_install_init_database() { static $included = FALSE; - + if (!$included) { $connection_info = Database::getConnectionInfo(); $driver = $connection_info['default']['driver']; @@ -567,7 +567,7 @@ function drupal_install_system() { require_once DRUPAL_ROOT . '/' . $system_path . '/system.install'; drupal_install_init_database(); module_invoke('system', 'install'); - + $system_versions = drupal_get_schema_versions('system'); $system_version = $system_versions ? max($system_versions) : SCHEMA_INSTALLED; db_query("INSERT INTO {system} (filename, name, type, owner, status, bootstrap, schema_version) VALUES('%s', '%s', '%s', '%s', %d, %d, %d)", $system_path . '/system.module', 'system', 'module', '', 1, 0, $system_version); @@ -827,7 +827,7 @@ function drupal_install_fix_file($file, /** - * Send the user to a different installer page. + * Send the user to a different installer page. * * This issues an on-site HTTP redirect. Messages (and errors) are erased. * @@ -926,7 +926,7 @@ function drupal_check_profile($profile) * Extract highest severity from requirements array. * * @param $requirements - * An array of requirements, in the same format as is returned by + * An array of requirements, in the same format as is returned by * hook_requirements(). * @return * The highest severity in the array. Index: includes/locale.inc =================================================================== RCS file: /cvs/drupal/drupal/includes/locale.inc,v retrieving revision 1.189 diff -u -p -r1.189 locale.inc --- includes/locale.inc 12 Oct 2008 04:30:05 -0000 1.189 +++ includes/locale.inc 12 Oct 2008 05:40:03 -0000 @@ -97,7 +97,7 @@ function theme_locale_languages_overview $header = array(array('data' => t('English name')), array('data' => t('Native name')), array('data' => t('Code')), array('data' => t('Direction')), array('data' => t('Enabled')), array('data' => t('Default')), array('data' => t('Weight')), array('data' => t('Operations'))); $output = theme('table', $header, $rows, array('id' => 'language-order')); $output .= drupal_render($form); - + drupal_add_tabledrag('language-order', 'order', 'sibling', 'language-order-weight'); return $output; @@ -1952,19 +1952,19 @@ function _locale_translate_seek() { case 'translated': $where = "WHERE (t.translation LIKE ?)"; $orderby = "ORDER BY t.translation"; - $arguments[] = '%'. $query['string'] .'%'; + $arguments[] = '%' . $query['string'] . '%'; break; case 'untranslated': $where = "WHERE (s.source LIKE ? AND t.translation IS NULL)"; $orderby = "ORDER BY s.source"; - $arguments[] = '%'. $query['string'] .'%'; + $arguments[] = '%' . $query['string'] . '%'; break; case 'all' : default: $where = "WHERE (s.source LIKE ? OR t.translation LIKE ?)"; $orderby = ''; - $arguments[] = '%'. $query['string'] .'%'; - $arguments[] = '%'. $query['string'] .'%'; + $arguments[] = '%' . $query['string'] . '%'; + $arguments[] = '%' . $query['string'] . '%'; break; } $grouplimit = ''; Index: includes/mail.inc =================================================================== RCS file: /cvs/drupal/drupal/includes/mail.inc,v retrieving revision 1.16 diff -u -p -r1.16 mail.inc --- includes/mail.inc 6 Oct 2008 11:00:01 -0000 1.16 +++ includes/mail.inc 12 Oct 2008 05:40:04 -0000 @@ -42,7 +42,7 @@ * function example_mail($key, &$message, $params) { * $language = $message['language']; * $variables = user_mail_tokens($params['account'], $language); - * switch($key) { + * switch ($key) { * case 'notice': * $message['subject'] = t('Notification from !site', $variables, $language->language); * $message['body'] = t("Dear !username\n\nThere is new content available on the site.", $variables, $language->language); Index: includes/menu.inc =================================================================== RCS file: /cvs/drupal/drupal/includes/menu.inc,v retrieving revision 1.293 diff -u -p -r1.293 menu.inc --- includes/menu.inc 8 Oct 2008 01:42:16 -0000 1.293 +++ includes/menu.inc 12 Oct 2008 05:40:05 -0000 @@ -207,7 +207,7 @@ define('MENU_SITE_OFFLINE', 4); * Menu tree */ - /** +/** * The maximum number of path elements for a menu callback */ define('MENU_MAX_PARTS', 7); @@ -1890,7 +1890,7 @@ function _menu_delete_item($item, $force * - plid The mlid of the parent. * - router_path The path of the relevant router item. * @return - * The mlid of the saved menu link, or FALSE if the menu link could not be + * The mlid of the saved menu link, or FALSE if the menu link could not be * saved. */ function menu_link_save(&$item) { @@ -1962,7 +1962,7 @@ function menu_link_save(&$item) { if (!$existing_item) { db_query("INSERT INTO {menu_links} ( - menu_name, plid, link_path, + menu_name, plid, link_path, hidden, external, has_children, expanded, weight, module, link_title, options, Index: includes/session.inc =================================================================== RCS file: /cvs/drupal/drupal/includes/session.inc,v retrieving revision 1.61 diff -u -p -r1.61 session.inc --- includes/session.inc 11 Oct 2008 16:37:38 -0000 1.61 +++ includes/session.inc 12 Oct 2008 05:40:06 -0000 @@ -222,7 +222,7 @@ function drupal_session_destroy_uid($uid * * @param int $lifetime * The value of session.gc_maxlifetime, passed by PHP. - * Sessions not updated for more than $lifetime seconds will be removed. + * Sessions not updated for more than $lifetime seconds will be removed. */ function _sess_gc($lifetime) { // Be sure to adjust 'php_value session.gc_maxlifetime' to a large enough Index: includes/theme.inc =================================================================== RCS file: /cvs/drupal/drupal/includes/theme.inc,v retrieving revision 1.438 diff -u -p -r1.438 theme.inc --- includes/theme.inc 12 Oct 2008 04:30:05 -0000 1.438 +++ includes/theme.inc 12 Oct 2008 05:40:07 -0000 @@ -790,7 +790,7 @@ function drupal_find_theme_templates($ca $subtheme_paths = isset($theme_paths[$theme]) ? $theme_paths[$theme] : array(); // Escape the periods in the extension. - $regex = '/'. str_replace('.', '\.', $extension) . '$/'; + $regex = '/' . str_replace('.', '\.', $extension) . '$/'; // Because drupal_system_listing works the way it does, we check for real // templates separately from checking for patterns. $files = drupal_system_listing($regex, $path, 'name', 0); Index: includes/database/database.inc =================================================================== RCS file: /cvs/drupal/drupal/includes/database/database.inc,v retrieving revision 1.12 diff -u -p -r1.12 database.inc --- includes/database/database.inc 8 Oct 2008 11:21:37 -0000 1.12 +++ includes/database/database.inc 12 Oct 2008 05:40:09 -0000 @@ -43,7 +43,7 @@ define('DB_ERROR', 'a515ac9c2796ca0e23ad * @code * $result = db_query_range('SELECT n.nid, n.title, n.created * FROM {node} n WHERE n.uid = :uid', array(':uid' => $uid), 0, 10); - * foreach($result as $record) { + * foreach ($result as $record) { * // Perform operations on $node->title, etc. here. * } * @endcode @@ -283,7 +283,7 @@ abstract class DatabaseConnection extend * A table prefix-parsed string for the sequence name. */ public function makeSequenceName($table, $field) { - return $this->prefixTables('{'. $table .'}_'. $field .'_seq'); + return $this->prefixTables('{' . $table . '}_' . $field . '_seq'); } /** @@ -552,7 +552,7 @@ abstract class DatabaseConnection extend * A database query result resource, or NULL if the query was not executed * correctly. */ - abstract public function queryRange($query, Array $args, $from, $count, Array $options); + abstract public function queryRange($query, Array $args, $from, $count, Array $options); /** * Runs a SELECT query and stores its results in a temporary table. @@ -577,7 +577,7 @@ abstract class DatabaseConnection extend * A database query result resource, or FALSE if the query was not executed * correctly. */ - abstract function queryTemporary($query, Array $args, $tablename); + abstract function queryTemporary($query, Array $args, $tablename); /** * Returns the type of database driver. @@ -2025,7 +2025,7 @@ function db_rewrite_sql($query, $primary if ($where) { $n = strlen($matches[1]); $second_part = substr($query, $n); - $first_part = substr($matches[1], 0, $n - 5) ." $join WHERE $where AND ( "; + $first_part = substr($matches[1], 0, $n - 5) . " $join WHERE $where AND ( "; // PHP 4 does not support strrpos for strings. We emulate it. $haystack_reverse = strrev($second_part); // No need to use strrev on the needle, we supply GROUP, ORDER, LIMIT Index: includes/database/query.inc =================================================================== RCS file: /cvs/drupal/drupal/includes/database/query.inc,v retrieving revision 1.5 diff -u -p -r1.5 query.inc --- includes/database/query.inc 6 Oct 2008 14:39:40 -0000 1.5 +++ includes/database/query.inc 12 Oct 2008 05:40:11 -0000 @@ -422,7 +422,7 @@ class InsertQuery extends Query { $placeholders = array_pad($placeholders, count($this->defaultFields), 'default'); $placeholders = array_pad($placeholders, count($this->insertFields), '?'); - return 'INSERT INTO {'. $this->table .'} ('. implode(', ', $insert_fields) .') VALUES ('. implode(', ', $placeholders) .')'; + return 'INSERT INTO {' . $this->table . '} (' . implode(', ', $insert_fields) . ') VALUES (' . implode(', ', $placeholders) . ')'; } } @@ -563,7 +563,7 @@ class MergeQuery extends Query { * The called object. */ public function update(Array $fields, Array $values = array()) { - if ($values) { + if ($values) { $fields = array_combine($fields, $values); } $this->updateFields = $fields; Index: includes/database/mysql/query.inc =================================================================== RCS file: /cvs/drupal/drupal/includes/database/mysql/query.inc,v retrieving revision 1.3 diff -u -p -r1.3 query.inc --- includes/database/mysql/query.inc 27 Sep 2008 20:10:26 -0000 1.3 +++ includes/database/mysql/query.inc 12 Oct 2008 05:40:11 -0000 @@ -55,16 +55,16 @@ class InsertQuery_mysql extends InsertQu $new_placeholder = $max_placeholder + count($insert_values); for ($i = $max_placeholder; $i < $new_placeholder; ++$i) { - $placeholders[] = ':db_insert_placeholder_'. $i; + $placeholders[] = ':db_insert_placeholder_' . $i; } $max_placeholder = $new_placeholder; - $values[] = '('. implode(', ', $placeholders) .')'; + $values[] = '(' . implode(', ', $placeholders) . ')'; } } else { // If there are no values, then this is a default-only query. We still need to handle that. $placeholders = array_fill(0, count($this->defaultFields), 'default'); - $values[] = '(' . implode(', ', $placeholders) .')'; + $values[] = '(' . implode(', ', $placeholders) . ')'; } $query .= implode(', ', $values); Index: includes/database/mysql/schema.inc =================================================================== RCS file: /cvs/drupal/drupal/includes/database/mysql/schema.inc,v retrieving revision 1.4 diff -u -p -r1.4 schema.inc --- includes/database/mysql/schema.inc 8 Oct 2008 11:09:16 -0000 1.4 +++ includes/database/mysql/schema.inc 12 Oct 2008 05:40:11 -0000 @@ -184,7 +184,7 @@ class DatabaseSchema_mysql extends Datab } if (!empty($spec['unique keys'])) { foreach ($spec['unique keys'] as $key => $fields) { - $keys[] = 'UNIQUE KEY ' . $key .' ('. $this->createKeysSqlHelper($fields) . ')'; + $keys[] = 'UNIQUE KEY ' . $key . ' (' . $this->createKeysSqlHelper($fields) . ')'; } } if (!empty($spec['indexes'])) { @@ -299,7 +299,7 @@ class DatabaseSchema_mysql extends Datab } public function changeField(&$ret, $table, $field, $field_new, $spec, $keys_new = array()) { - $sql = 'ALTER TABLE {' . $table . '} CHANGE `' . $field . '` ' . $this->createFieldSql($field_new, $this->processField($spec)); + $sql = 'ALTER TABLE {' . $table . '} CHANGE `' . $field . '` ' . $this->createFieldSql($field_new, $this->processField($spec)); if (count($keys_new)) { $sql .= ', ADD ' . implode(', ADD ', $this->createKeysSql($keys_new)); } Index: includes/database/pgsql/query.inc =================================================================== RCS file: /cvs/drupal/drupal/includes/database/pgsql/query.inc,v retrieving revision 1.2 diff -u -p -r1.2 query.inc --- includes/database/pgsql/query.inc 15 Sep 2008 20:48:07 -0000 1.2 +++ includes/database/pgsql/query.inc 12 Oct 2008 05:40:11 -0000 @@ -43,7 +43,7 @@ class InsertQuery_pgsql extends InsertQu break; default: - $stmt->bindParam(':db_insert_placeholder_'. $max_placeholder++, $insert_values[$idx]); + $stmt->bindParam(':db_insert_placeholder_' . $max_placeholder++, $insert_values[$idx]); break; } } @@ -94,7 +94,7 @@ class InsertQuery_pgsql extends InsertQu else { // If there are no values, then this is a default-only query. We still need to handle that. $placeholders = array_fill(0, count($this->defaultFields), 'default'); - $values[] = '(' . implode(', ', $placeholders) .')'; + $values[] = '(' . implode(', ', $placeholders) . ')'; } $query .= implode(', ', $values); Index: modules/blogapi/blogapi.module =================================================================== RCS file: /cvs/drupal/drupal/modules/blogapi/blogapi.module,v retrieving revision 1.132 diff -u -p -r1.132 blogapi.module --- modules/blogapi/blogapi.module 12 Oct 2008 02:58:23 -0000 1.132 +++ modules/blogapi/blogapi.module 12 Oct 2008 05:40:11 -0000 @@ -328,10 +328,10 @@ function blogapi_blogger_get_post($appke * TRUE if no error, or the blogapi_error(). */ function blogapi_status_error_check($node, $original_status) { - + $node = (object) $node; - $node_type_default = variable_get('node_options_'. $node->type, array('status', 'promote')); + $node_type_default = variable_get('node_options_' . $node->type, array('status', 'promote')); // If we don't have the 'administer nodes' permission and the status is // changing or for a new node the status is not the content type's default, @@ -584,7 +584,7 @@ function blogapi_mt_validate_terms($node $term_list = array_unique($node->taxonomy); $params = $term_list; $params[] = $node->type; - $result = db_query(db_rewrite_sql("SELECT t.tid, t.vid FROM {term_data} t INNER JOIN {vocabulary_node_types} n ON t.vid = n.vid WHERE t.tid IN (". db_placeholders($term_list) .") AND n.type = '%s'", 't', 'tid'), $params); + $result = db_query(db_rewrite_sql("SELECT t.tid, t.vid FROM {term_data} t INNER JOIN {vocabulary_node_types} n ON t.vid = n.vid WHERE t.tid IN (" . db_placeholders($term_list) . ") AND n.type = '%s'", 't', 'tid'), $params); $found_terms = array(); $found_count = 0; while ($term = db_fetch_object($result)) { @@ -768,7 +768,7 @@ function blogapi_admin_settings() { '#field_suffix' => t('MB') ); - $form['settings_general']['upload_max_size'] = array('#value' => '
'. t('Your PHP settings limit the maximum file size per upload to %size.', array('%size' => format_size(file_upload_max_size()))).'
'); + $form['settings_general']['upload_max_size'] = array('#value' => '' . t('Your PHP settings limit the maximum file size per upload to %size.', array('%size' => format_size(file_upload_max_size()))) . '
'); $roles = user_roles(FALSE, 'administer content with blog api'); $form['roles'] = array('#type' => 'value', '#value' => $roles); @@ -971,4 +971,3 @@ function _blogapi_get_node_types() { function _blogapi_space_used($uid) { return db_query('SELECT SUM(filesize) FROM {blogapi_files} f WHERE f.uid = :uid', array(':uid' => $uid))->fetchField(); } - Index: modules/book/book.module =================================================================== RCS file: /cvs/drupal/drupal/modules/book/book.module,v retrieving revision 1.471 diff -u -p -r1.471 book.module --- modules/book/book.module 9 Oct 2008 15:15:50 -0000 1.471 +++ modules/book/book.module 12 Oct 2008 05:40:11 -0000 @@ -324,11 +324,11 @@ function book_form_alter(&$form, $form_s $form['book']['pick-book'] = array( '#type' => 'submit', '#value' => t('Change book (update list of parents)'), - // Submit the node form so the parent select options get updated. - // This is typically only used when JS is disabled. Since the parent options - // won't be changed via AJAX, a button is provided in the node form to submit - // the form and generate options in the parent select corresponding to the - // selected book. This is similar to what happens during a node preview. + // Submit the node form so the parent select options get updated. + // This is typically only used when JS is disabled. Since the parent options + // won't be changed via AJAX, a button is provided in the node form to submit + // the form and generate options in the parent select corresponding to the + // selected book. This is similar to what happens during a node preview. '#submit' => array('node_form_submit_build_node'), '#weight' => 20, ); Index: modules/comment/comment.module =================================================================== RCS file: /cvs/drupal/drupal/modules/comment/comment.module,v retrieving revision 1.656 diff -u -p -r1.656 comment.module --- modules/comment/comment.module 11 Oct 2008 21:10:59 -0000 1.656 +++ modules/comment/comment.module 12 Oct 2008 05:40:12 -0000 @@ -719,7 +719,7 @@ function comment_save($edit) { // Strip the "/" from the end of the parent thread. $parent->thread = (string) rtrim((string) $parent->thread, '/'); // Get the max value in *this* thread. - $max = db_query("SELECT MAX(thread) FROM {comments} WHERE thread LIKE :thread AND nid = :nid", array(':thread' => $parent->thread .'%', ':nid' => $edit['nid']))->fetchField(); + $max = db_query("SELECT MAX(thread) FROM {comments} WHERE thread LIKE :thread AND nid = :nid", array(':thread' => $parent->thread . '%', ':nid' => $edit['nid']))->fetchField(); if ($max == '') { // First child of this parent. Index: modules/comment/comment.test =================================================================== RCS file: /cvs/drupal/drupal/modules/comment/comment.test,v retrieving revision 1.15 diff -u -p -r1.15 comment.test --- modules/comment/comment.test 24 Sep 2008 22:38:20 -0000 1.15 +++ modules/comment/comment.test 12 Oct 2008 05:40:13 -0000 @@ -144,7 +144,7 @@ class CommentHelperCase extends DrupalWe * Comments per page value. */ function setCommentsPerPage($number) { - $this->setCommentSettings('comment_default_per_page_article', $number, 'Number of comments per page set to ' . $number .'.'); + $this->setCommentSettings('comment_default_per_page_article', $number, 'Number of comments per page set to ' . $number . '.'); } /** @@ -308,7 +308,7 @@ class CommentInterfaceTest extends Comme $this->assertText('This discussion is closed', t('Posting to node with comments disabled')); $this->assertNoField('edit-comment', t('Comment body field found.')); - // Attempt to post to node with read-only comments. + // Attempt to post to node with read-only comments. $this->node = $this->drupalCreateNode(array('type' => 'article', 'promote' => 1, 'comment' => COMMENT_NODE_READ_ONLY)); $this->assertTrue($this->node, t('Article node created.')); $this->drupalGet('comment/reply/' . $this->node->nid); @@ -449,14 +449,14 @@ class CommentAnonymous extends CommentHe $this->drupalLogin($this->admin_user); $this->setAnonymousUserComment(FALSE, FALSE); - // Attempt to view comments while disallowed. + // Attempt to view comments while disallowed. // NOTE: if authenticated user has permission to post comments, then a // "Login or register to post comments" type link may be shown. $this->drupalLogout(); $this->drupalGet('node/' . $this->node->nid); $this->assertNoRaw('
' . t('Deleted') . ''), 'ins' => array( t('Inserted'), '' . t('Inserted') . ''), - // Assumes and describes li. + // Assumes and describes li. 'ol' => array( t('Ordered list - use the <li> to begin each list item'), '' . t('The SimpleTest module is a framework for running automated unit tests in Drupal. It can be used to verify a working state of Drupal before and after any code changes, or as a means for developers to write and execute tests for their modules.') .'
'; - $output .= '' . t('Visit Administer >> Site building >> SimpleTest to display a list of available tests. For comprehensive testing, select all tests, or individually select tests for more targeted testing. Note that it might take several minutes for all tests to complete.)', array('@admin-simpletest' => url('admin/build/testing'))) .'
'; - $output .= '' . t('After the tests have run, a message will be displayed next to each test group indicating whether tests within it passed, failed, or had exceptions. A pass means that a test returned the expected results, while fail means that it did not. An exception normally indicates an error outside of the test, such as a PHP warning or notice. If there were fails or exceptions, the results are expanded, and the tests that had issues will be indicated in red or pink rows. Use these results to refine your code and tests until all tests return a pass.') .'
'; - $output .= '' . t('For more information on creating and modifying your own tests, see the SimpleTest API Documentation in the Drupal handbook.', array('@simpletest-api' => 'http://drupal.org/simpletest')) .'
'; - $output .= '' . t('For more information, see the online handbook entry for SimpleTest module.', array('@simpletest' => 'http://drupal.org/handbook/modules/simpletest')) .'
'; + $output = '' . t('The SimpleTest module is a framework for running automated unit tests in Drupal. It can be used to verify a working state of Drupal before and after any code changes, or as a means for developers to write and execute tests for their modules.') . '
'; + $output .= '' . t('Visit Administer >> Site building >> SimpleTest to display a list of available tests. For comprehensive testing, select all tests, or individually select tests for more targeted testing. Note that it might take several minutes for all tests to complete.)', array('@admin-simpletest' => url('admin/build/testing'))) . '
'; + $output .= '' . t('After the tests have run, a message will be displayed next to each test group indicating whether tests within it passed, failed, or had exceptions. A pass means that a test returned the expected results, while fail means that it did not. An exception normally indicates an error outside of the test, such as a PHP warning or notice. If there were fails or exceptions, the results are expanded, and the tests that had issues will be indicated in red or pink rows. Use these results to refine your code and tests until all tests return a pass.') . '
'; + $output .= '' . t('For more information on creating and modifying your own tests, see the SimpleTest API Documentation in the Drupal handbook.', array('@simpletest-api' => 'http://drupal.org/simpletest')) . '
'; + $output .= '' . t('For more information, see the online handbook entry for SimpleTest module.', array('@simpletest' => 'http://drupal.org/handbook/modules/simpletest')) . '
'; return $output; } } @@ -102,7 +102,7 @@ function simpletest_test_form() { // This reporter can only handle pass, fail and exception. if (isset($map[$status])) { $element['#title'] = $info['name']; - $status_index = '#'. $status; + $status_index = '#' . $status; $form['summary'][$status_index]++; $group_summary[$group][$status_index]++; $element['summary'][$status_index]++; @@ -263,7 +263,7 @@ function theme_simpletest_test_table($ta $row[] = '