', // error
+ '#base' => 'my_shared_form_id', // An error.
+ '#pre_render' => '
', // An error.
);
$form['#base'] = 'http://example.com';
- $form['#submit']['my_submit_function'] = array($param1, $param2); // error
- $form['#submit']['my_validate_function'] = array(); // error
+ $form['#submit']['my_submit_function'] = array($param1, $param2); // An error.
+ $form['#submit']['my_validate_function'] = array(); // An error.
$form['#multistep'] = TRUE;
$form['#DANGEROUS_SKIP_CHECK'] = TRUE;
- drupal_retrieve_form('testform'); // missing second arg
- drupal_retrieve_form($form_id, $form_state); // ok
+ drupal_retrieve_form('testform'); // Missing second arg.
+ drupal_retrieve_form($form_id, $form_state); // Ok.
- form_set_value($element, 'value', $form_status); // This one is okay
- form_set_value($element, 'value'); // error
+ form_set_value($element, 'value', $form_status); // Ok.
+ form_set_value($element, 'value'); // An error.
- confirm_form($form, t('Do you really want to delete this?'), "node/$nid", t("Don't do it unless you're really sure!"), t('Delete it'), t('Go back'), 'delete'); // should fail
+ confirm_form($form, t('Do you really want to delete this?'), "node/$nid", t("Don't do it unless you're really sure!"), t('Delete it'), t('Go back'), 'delete'); // Should fail.
- confirm_form($form, t('Do you really want to delete this?'), "node/$nid", $options); // is ok
- confirm_form($form, t('Do you really want to delete this?'), "node/$nid", array()); // also ok
+ confirm_form($form, t('Do you really want to delete this?'), "node/$nid", $options); // Ok.
+ confirm_form($form, t('Do you really want to delete this?'), "node/$nid", array()); // Ok.
- custom_url_rewrite($url); // not ok
- custom_url_rewrite_inbound($url); // ok
+ custom_url_rewrite($url); // An error.
+ custom_url_rewrite_inbound($url); // Ok.
- $form_location = variable_get('comment_form_location', COMMENT_FORM_SEPARATE_PAGE); // not ok
- $form_location = variable_get('comment_form_location_page', COMMENT_FORM_SEPARATE_PAGE); // ok
- $variable_name = 'comment_form_location'.'_abc'; // ok
+ $form_location = variable_get('comment_form_location', COMMENT_FORM_SEPARATE_PAGE); // An error.
+ $form_location = variable_get('comment_form_location_page', COMMENT_FORM_SEPARATE_PAGE); // Ok.
+ $variable_name = 'comment_form_location'.'_abc'; // Ok.
$log_path = 'admin/logs/';
@@ -85,76 +94,76 @@
taxonomy_get_vocabulary($vid);
db_result($result, $row);
- db_result($result); // ok
- $number = db_result(db_query("SELECT COUNT(*) FROM {flood} WHERE event = '%s' AND hostname = '%s' AND timestamp > %d", $name, ip_address(), time() - 3600)); //ok
+ db_result($result); // Ok.
+ $number = db_result(db_query("SELECT COUNT(*) FROM {flood} WHERE event = '%s' AND hostname = '%s' AND timestamp > %d", $name, ip_address(), time() - 3600)); // Ok.
- // book api tests
- book_admin_orphan(); // deprecated
- book_content(); // deprecated
- book_form(); // deprecated
- book_insert(); // deprecated
- book_location(); // deprecated
- book_location_down(); // deprecated
- book_node_visitor_html_post(); // deprecated
- book_node_visitor_html_pre(); // deprecated
- book_recurse(); // deprecated
- book_toc_recurse(); // deprecated
- book_tree(); // deprecated
- book_tree_recurse(); // deprecated
-
- book_admin_edit($nid); // not ok
- book_admin_edit($form_state, $node); // ok
-
- book_toc(); // not ok
- book_toc($exclude); // not ok
- book_toc($bid, array(), $depth); // ok
-
- book_export_html($nid, $depth); // not ok
- book_export_html($nid); // ok
-
- book_export(); // not ok
- book_export($type); // not ok
- book_export($type, $nid); // ok
-
- book_outline($nid); // not ok
- book_outline($node->nid); // not ok
- book_outline($node); // ok
-
- book_prev($node); // not ok
- book_prev($book_link); // ok
- book_next($node); // not ok
- book_next($book_link); // ok
- // end book api tests
-
- drupal_mail($action, $to, $subject, $body, $from); // not ok
- drupal_mail('action_email', $recipient, $subject, $body, $from); // not ok
- drupal_mail('action_email', $account->mail, $subject, $body, $from); // not ok
- drupal_mail('action_email', 'foo@foo.com', $subject, $body, $from); // not ok
- drupal_mail('system', 'action_email', $recipient, $language, $params); // ok
+ // Book api tests.
+ book_admin_orphan(); // Deprecated.
+ book_content(); // Deprecated.
+ book_form(); // Deprecated.
+ book_insert(); // Deprecated.
+ book_location(); // Deprecated.
+ book_location_down(); // Deprecated.
+ book_node_visitor_html_post(); // Deprecated.
+ book_node_visitor_html_pre(); // Deprecated.
+ book_recurse(); // Deprecated.
+ book_toc_recurse(); // Deprecated.
+ book_tree(); // Deprecated.
+ book_tree_recurse(); // Deprecated.
+
+ book_admin_edit($nid); // Not ok.
+ book_admin_edit($form_state, $node); // Ok.
+
+ book_toc(); // Not ok.
+ book_toc($exclude); // Not ok.
+ book_toc($bid, array(), $depth); // Ok.
+
+ book_export_html($nid, $depth); // Not ok.
+ book_export_html($nid); // Ok.
+
+ book_export(); // Not ok.
+ book_export($type); // Not ok.
+ book_export($type, $nid); // Ok.
+
+ book_outline($nid); // Not ok.
+ book_outline($node->nid); // Not ok.
+ book_outline($node); // Ok.
+
+ book_prev($node); // Not ok.
+ book_prev($book_link); // Ok.
+ book_next($node); // Not ok.
+ book_next($book_link); // Ok.
+ // End book api tests.
+
+ drupal_mail($action, $to, $subject, $body, $from); // Not ok.
+ drupal_mail('action_email', $recipient, $subject, $body, $from); // Not ok.
+ drupal_mail('action_email', $account->mail, $subject, $body, $from); // Not ok.
+ drupal_mail('action_email', 'foo@foo.com', $subject, $body, $from); // Not ok.
+ drupal_mail('system', 'action_email', $recipient, $language, $params); // Ok.
}
-function _coder_6x_test_link_alter($node, &$links) { // an error
+function _coder_6x_test_link_alter($node, &$links) { // An error.
}
-function _coder_6x_test2_link_alter(&$links, $node) { // not an error
+function _coder_6x_test2_link_alter(&$links, $node) { // Not an error.
}
-function _coder_6x_test_mail_alter(&$mailkey, &$to, &$subject, &$body, &$from, &$headers) { // this is an error
+function _coder_6x_test_mail_alter(&$mailkey, &$to, &$subject, &$body, &$from, &$headers) { // An error.
}
-function _coder_6x_test2_mail_alter(&$message) { // not an error
+function _coder_6x_test2_mail_alter(&$message) { // An error.
}
function coder_node_get_name() {
node_get_name('name');
}
-function myform_validate($form_id, $form) { // this will fail.
+function myform_validate($form_id, $form) { // This will fail.
}
-function myform_submit($form_id, $form) { //this willfail
+function myform_submit($form_id, $form) { // This will fail.
$form['#submit']['newsubmit'] = array();
$form['#submit'][] = "newsubmit";
}
@@ -165,16 +174,16 @@
function mymodule_auth($username, $password, $server) {
}
-function mymodule_help($section) { // not ok
+function mymodule_help($section) { // Not ok.
}
-function mymodule_help($section, $arg) { // ok
+function mymodule_help($section, $arg) { // Ok.
}
function mymodule_enable() {
- node_access_rebuild(); // not ok in node access modules
+ node_access_rebuild(); // Not ok in node access modules.
}
function mymodule_disable() {
- node_access_rebuild(); // not ok in node access modules
+ node_access_rebuild(); // Not ok in node access modules.
}
Index: tests/coder_comment.inc
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/coder/tests/coder_comment.inc,v
retrieving revision 1.1.4.1
diff -u -r1.1.4.1 coder_comment.inc
--- tests/coder_comment.inc 21 Nov 2007 10:41:04 -0000 1.1.4.1
+++ tests/coder_comment.inc 8 Jan 2008 01:53:43 -0000
@@ -1,7 +1,9 @@
camelCase; // but camel case objects elements are
- new camcelCase(); // is ok
+ $camelCaseVar = 'whatever'; // Camel case functions and vars not allowed.
+ $var = $obj->camelCase; // But camel case objects elements are.
+ new camcelCase(); // Is ok.
}
function coder_test_two_errors_on_same_line() {
- if('test=' . $test == 'test='){ // there are 3 errors on this line
+ if('test=' . $test == 'test='){ // There are 3 errors on this line.
}
}
@@ -38,10 +41,10 @@
}
function coder_hex_number() {
- $var = 0xFF; // should NOT be camelcase
+ $var = 0xFF; // Should NOT be camelcase.
}
-function coder_multiline_quote() { // from Drupal5 block.module
+function coder_multiline_quote() { // From Drupal5 block.module.
return t('
Blocks are boxes of content that may be rendered into certain regions of your web pages, for example, into sidebars. They are usually generated automatically by modules, but administrators can create blocks manually.
Only enabled blocks are shown. You can position blocks by specifying which area of the page they should appear in (e.g., a sidebar). Highlighted labels on this page show the regions into which blocks can be rendered. You can specify where within a region a block will appear by adjusting its weight.
If you want certain blocks to disable themselves temporarily during high server loads, check the "Throttle" box. You can configure the auto-throttle on the throttle configuration page after having enabled the throttle module.
@@ -49,8 +52,8 @@
}
function coder_break() {
- print '
'; // should generate an error, and will throw performance warning
- ?>
'; // Should generate an error, and will throw performance warning.
+ ?>